Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip Spotless skip #42634

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

alzimmermsft
Copy link
Member

Description

Flips the spotless.skip from defaulting to true in the parent POM to false. Libraries which still haven't migrated to having Spotless enabled have <spotless.skip>true</spotless.skip> added to their POM and all other instances of spotless.skip have been removed.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit e9f1ef0 into Azure:main Oct 28, 2024
4 checks passed
@alzimmermsft alzimmermsft deleted the AzParent_FlipSpotlessSkip branch October 28, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants