Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep db.cosmosdb.* attributes #42460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep db.cosmosdb.* attributes #42460

wants to merge 1 commit into from

Conversation

trask
Copy link
Member

@trask trask commented Oct 18, 2024

Resolves #34128

trask
trask commented Oct 18, 2024
View reviewed changes
...r/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MappingsBuilder.java
Comment on lines -25 to -27
public static final Mappings EMPTY_MAPPINGS
= new Mappings(Collections.emptyMap(), Trie.<PrefixMapping>newBuilder().build());

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this was unused)

@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Oct 18, 2024
@trask trask mentioned this pull request Oct 18, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ]Keep Open Telemetry attributes prefixed with db.comsosdb.* for dependency/span events
1 participant
@trask