Fixes Configuration package names #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
added
the
Client
JonathanGiles
approved these changes
Jun 19, 2019
|
Created an issue for those hanging tests: #4013 |
conniey
commented
Jun 20, 2019
| @@ -56,6 +56,8 @@ | |||
| static final String ACCEPT_LANGUAGE = "en-US"; | |||
| static final int DEFAULT_MAX_PAGE_RESULTS = 25; | |||
| static final String CONTENT_TYPE_HEADER_VALUE = "application/json"; | |||
| static final String KEY_VAULT_SCOPE = "https://vault.azure.net/.default"; | |||
There was a problem hiding this comment.
I wasn't sure where all the KV constants go. So I duplicated it in 4 places similar to all the other clients I saw. I'm sure there is a better place for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build issues due to Configuration names being in a different package