Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAI-Assistant] Function ToolCall #38594

Closed

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Feb 2, 2024

No description provided.

@mssfang mssfang changed the base branch from main to feature/openai/assistant/beta.1 February 2, 2024 07:07
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-ai-openai-assistants

@@ -62,7 +63,7 @@ public String getDescription() {
* @return the parameters value.
*/
@Generated
public Object getParameters() {
public BinaryData getParameters() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to include this customization. Is this a hand crafted customization?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I would like this to be an upstream change from TSP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is hand crafted now and will revert it back to Object and add customization.

@mssfang
Copy link
Member Author

mssfang commented Feb 6, 2024

The FunctionCall already fixed in Azure/azure-rest-api-specs#27638

@mssfang mssfang closed this Feb 6, 2024
@mssfang mssfang deleted the Assistants-Tool branch February 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants