Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure AI HealthInsights - RadiologyInsigts] Java SDK version V2 #38314

Conversation

asaflevi-ms
Copy link
Member

@asaflevi-ms asaflevi-ms commented Jan 15, 2024

Description

Radiology Insights is a new model/skill that is going for public in V2 of HealthInsights public service .

Typespec PR: Azure/azure-rest-api-specs#27223

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

asaflevi-ms and others added 22 commits January 4, 2024 09:33
…logyinsights-java-sdk

Tomderay/healthinsights radiologyinsights java sdk
…s, but currently BinaryData return is empty in live. Tested in Rest api against same endpoint, should work. Need to investigate how to interprete return values
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-health-insights-radiologyinsights

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

PS: 0.13.3 merged with a minor change to "RadiologyInsightsServiceVersion.java" (actually reverted it back to that from 0.13.1)

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Feb 7, 2024

From teams chat, please try add a src/samples/README.md

A simple one would do, just the link to the sample file, and what it does.
(note there could be CI report on link because it's not in main; if so, you can add link after the PR merged)

Example:

@weidongxu-microsoft weidongxu-microsoft merged commit c5d9a28 into Azure:main Feb 8, 2024
17 checks passed
@asaflevi-ms asaflevi-ms deleted the asaflevi/healthinsights-radiologyinsights-java-sdk branch February 13, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants