Close OkHttp ResponseBody after writeBodyTo and writeBodyToAsync #36650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
requested review from
mssfang,
JonathanGiles,
ibrahimrabab,
seanmcc-msft,
ibrandes,
srnagar,
anuchandy,
lmolkova,
vcolin7 and
billwert
as code owners
joshfree
approved these changes
Sep 12, 2023
...http-okhttp/src/main/java/com/azure/core/http/okhttp/implementation/OkHttpAsyncResponse.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/io/IOUtils.java
Outdated
Show resolved
Hide resolved
anuchandy
approved these changes
Sep 12, 2023
...core/azure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClient.java
Outdated
Show resolved
Hide resolved
...core/azure-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClient.java
Outdated
Show resolved
Hide resolved
anuchandy
reviewed
Sep 12, 2023
...http-okhttp/src/main/java/com/azure/core/http/okhttp/implementation/OkHttpAsyncResponse.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a call to close the OkHttp
ResponseBodyafterwriteBodyToandwriteBodyToAsynccompletes, either sucessfully or unsuccessfully. Additionally, a new set of APIs are added toIOUtilsto give better control to the shared buffer used to write aReadableByteChannelto aWritableByteChannel/AsynchronousByteChannelin the aim to reduce read and write calls.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines