Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Package Links on central.sonatype.com #36637

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Standardize Package Links on central.sonatype.com #36637

merged 5 commits into from
Sep 8, 2023

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Sep 5, 2023 •
edited
Loading

Description

Fixes #36574

Replaces search.maven.org and mvnrepository.com links with central.sonatype.com links. search.maven.org is being replaced by central.sonatype.com, mvnrepository.com is being replaced as it's a 3rd party system for presenting Maven package data.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Event Grid Event Hubs KeyVault Mixed Reality Authentication Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation Schema Registry Search Service Bus Storage Storage Service (Queues, Blobs, Files) Tables labels Sep 5, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

srnagar
srnagar reviewed Sep 5, 2023
View reviewed changes
sdk/applicationinsights/microsoft-azure-applicationinsights-query/pom.xml Outdated Show resolved Hide resolved
sdk/eventhubs/microsoft-azure-eventhubs-eph/pom.xml Outdated Show resolved Hide resolved
sdk/eventhubs/microsoft-azure-eventhubs-extensions/pom.xml Outdated Show resolved Hide resolved
sdk/eventhubs/microsoft-azure-eventhubs/pom.xml Outdated Show resolved Hide resolved
...stry/src/test/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClientPlaybackTests.java Outdated Show resolved Hide resolved
sdk/agrifood/azure-verticals-agrifood-farming/README.md Outdated
@@ -166,7 +166,7 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
[product_documentation]: https://aka.ms/FarmBeatsProductDocumentationPaaS
[azure_portal]: https://portal.azure.com
[jdk_link]: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable
[package]: https://mvnrepository.com/artifact/com.azure/azure-verticals-agrifood-farming
[package]: https://central.sonatype.com/search?namespace=com.azure&name=azure-verticals-agrifood-farming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the overview link instead of the search link.

This link takes directly to the latest version of the library.
https://central.sonatype.com/artifact/com.azure/azure-verticals-agrifood-farming

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Let's use this instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use the better URL pattern.

joshfree
joshfree requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the simpler link, e.g., https://central.sonatype.com/artifact/com.azure/azure-verticals-agrifood-farming

sdk/agrifood/azure-verticals-agrifood-farming/README.md Outdated
@@ -166,7 +166,7 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
[product_documentation]: https://aka.ms/FarmBeatsProductDocumentationPaaS
[azure_portal]: https://portal.azure.com
[jdk_link]: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable
[package]: https://mvnrepository.com/artifact/com.azure/azure-verticals-agrifood-farming
[package]: https://central.sonatype.com/search?namespace=com.azure&name=azure-verticals-agrifood-farming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Let's use this instead

weidongxu-microsoft
weidongxu-microsoft approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on resourcemanager

@joshfree joshfree mentioned this pull request Sep 8, 2023
Closed
@alzimmermsft
Copy link
Member Author

Data plane (Track 1) pipelines are failing analyze due to RevApi trying to run which isn't configured for data-plane libraries. Being resolved here: https://github.com/Azure/azure-sdk-for-java/pull/36685/checks?check_run_id=16630213720

Storage CI is failing due to a known issue with test playback.

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft enabled auto-merge (squash) September 8, 2023 21:10
@alzimmermsft alzimmermsft merged commit fd60439 into Azure:main Sep 8, 2023
@alzimmermsft alzimmermsft deleted the AzDocs_ChangePackageLinks branch September 8, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@srnagar srnagar srnagar approved these changes

@samvaity samvaity samvaity approved these changes

@joshfree joshfree joshfree approved these changes

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@mrm9084 mrm9084 Awaiting requested review from mrm9084 mrm9084 is a code owner

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

@trask trask Awaiting requested review from trask trask is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@quentinRobinson quentinRobinson Awaiting requested review from quentinRobinson quentinRobinson is a code owner

@jairmyree jairmyree Awaiting requested review from jairmyree jairmyree is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@ibrahimrabab ibrahimrabab Awaiting requested review from ibrahimrabab ibrahimrabab is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@ibrandes ibrandes Awaiting requested review from ibrandes ibrandes is a code owner

@shankarsama shankarsama Awaiting requested review from shankarsama shankarsama is a code owner

@yvgopal yvgopal Awaiting requested review from yvgopal yvgopal is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@sjkwak sjkwak Awaiting requested review from sjkwak sjkwak is a code owner

@RamonArguelles RamonArguelles Awaiting requested review from RamonArguelles RamonArguelles is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@mengaims mengaims Awaiting requested review from mengaims mengaims is a code owner

@JamesBirdsall JamesBirdsall Awaiting requested review from JamesBirdsall

@billwert billwert Awaiting requested review from billwert billwert is a code owner

@johngallardo johngallardo Awaiting requested review from johngallardo johngallardo is a code owner

@abhinav-ghai abhinav-ghai Awaiting requested review from abhinav-ghai abhinav-ghai is a code owner

@Aashish93-stack Aashish93-stack Awaiting requested review from Aashish93-stack Aashish93-stack is a code owner

@sjiherzig sjiherzig Awaiting requested review from sjiherzig sjiherzig is a code owner

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@milismsft milismsft Awaiting requested review from milismsft

@aayush3011 aayush3011 Awaiting requested review from aayush3011

@simorenoh simorenoh Awaiting requested review from simorenoh

@jeet1995 jeet1995 Awaiting requested review from jeet1995

@Pilchie Pilchie Awaiting requested review from Pilchie

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@minnieliu minnieliu Awaiting requested review from minnieliu minnieliu is a code owner

@paolamvhz paolamvhz Awaiting requested review from paolamvhz paolamvhz is a code owner

@Mrayyan Mrayyan Awaiting requested review from Mrayyan

@shwali-msft shwali-msft Awaiting requested review from shwali-msft shwali-msft is a code owner

@allchiang-msft allchiang-msft Awaiting requested review from allchiang-msft allchiang-msft is a code owner

@mikehang-msft mikehang-msft Awaiting requested review from mikehang-msft mikehang-msft is a code owner

@DimaKolomiiets DimaKolomiiets Awaiting requested review from DimaKolomiiets

@ozgurcivi-msft ozgurcivi-msft Awaiting requested review from ozgurcivi-msft

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft gfeitosa-msft is a code owner

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft phermanov-msft is a code owner

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft ilyapaliakou-msft is a code owner

@miguhern miguhern Awaiting requested review from miguhern miguhern is a code owner

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@RoyHerrod RoyHerrod Awaiting requested review from RoyHerrod

@danielav7 danielav7 Awaiting requested review from danielav7 danielav7 is a code owner

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit ankitarorabit is a code owner

@jingjlii jingjlii Awaiting requested review from jingjlii

@ljiaqi1998 ljiaqi1998 Awaiting requested review from ljiaqi1998

@JJJessieWang JJJessieWang Awaiting requested review from JJJessieWang

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@gracewilcox gracewilcox Awaiting requested review from gracewilcox gracewilcox is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@nisha-bhatia nisha-bhatia Awaiting requested review from nisha-bhatia nisha-bhatia is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration Azure.Core azure-core azure-spring All azure-spring related issues Batch Cognitive - Anomaly Detector Cognitive - Form Recognizer Cognitive - Metrics Advisor Cognitive - Text Analytics Communication - Chat Communication - Identity Communication - Phone Numbers Communication - Rooms Communication - SMS Container Registry Cosmos Digital Twins Event Grid Event Hubs KeyVault Mixed Reality Authentication Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation Schema Registry Search Service Bus Storage Storage Service (Queues, Blobs, Files) Tables
Projects
Azure SDK for Key Vault
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container Registry Readme Issue
6 participants
@alzimmermsft @azure-sdk @joshfree @samvaity @srnagar @weidongxu-microsoft