Perf test core implement InputStream.available() #27907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
approved these changes
Mar 28, 2022
joshfree
approved these changes
Mar 28, 2022
joshfree
added
pillar-performance
kasobol-msft
added a commit
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InputStream.available()is used to estimate bytes available for read and JDK docs prescribe implementing that method in subclasses. Some implementations (like Netty) rely on this method to efficiently read bytes from stream. Leaving this unimplemented may skew perf results as it seems that real InputStream subclasses found in nature usually implement this method.