Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add * in children list #27861

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Add * in children list #27861

merged 6 commits into from
Mar 28, 2022

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Mar 25, 2022

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1465625&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=77c1d216-7286-5491-da68-92a28675e9c9
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@sima-zhu sima-zhu requested a review from danieljurek March 25, 2022 00:19
@sima-zhu sima-zhu requested a review from danieljurek March 25, 2022 17:32
@sima-zhu
Copy link
Contributor Author

/azp run java - template - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@sima-zhu
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@sima-zhu sima-zhu requested a review from danieljurek March 25, 2022 20:42
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to defer to @danieljurek to sign-off on this PR.

@danieljurek
Copy link
Member

We found an issue where some entries were duplicated and managed to trace a likely source in the code. @sima-zhu is fixing.

@sima-zhu
Copy link
Contributor Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@sima-zhu
Copy link
Contributor Author

/azp run java - template - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@sima-zhu
Copy link
Contributor Author

@sima-zhu
Copy link
Contributor Author

/check-enforcer override

@sima-zhu sima-zhu merged commit 9302e6c into Azure:main Mar 28, 2022
@sima-zhu sima-zhu deleted the toc_comparison branch March 28, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants