Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose condition api #26316

Merged

Conversation

XiaofeiCao
Copy link
Contributor

Description

fix #25815
This PR exposes condition() api on RoleAssignment.
Test is done locally.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jan 6, 2022

Could you show us a sample string of this condition in real case?

@XiaofeiCao
Copy link
Contributor Author

The condition string looks like this:

(
 (
  !(ActionMatches{'Microsoft.Storage/storageAccounts/blobServices/containers/blobs/read'} AND SubOperationMatches{'Blob.Read.WithTagConditions'})
 )
 OR 
 (
  @Resource[Microsoft.Storage/storageAccounts/blobServices/containers:name] StringEquals 'test'
 )
)

Corresponding portal assign parameters:
image

@XiaofeiCao XiaofeiCao merged commit 1c04973 into Azure:main Jan 6, 2022
@XiaofeiCao XiaofeiCao deleted the mgmt_authorization_condition_support branch January 6, 2022 09:12
samvaity pushed a commit to samvaity/azure-sdk-for-java that referenced this pull request Jan 11, 2022
samvaity pushed a commit to samvaity/azure-sdk-for-java that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mgmt, condition in RBAC (ABAC support)
3 participants