Update SDK with latest swagger schema. #25560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zihzhan-msft
requested review from
navali-msft,
satyakonmsft and
arifsaikat-microsoft
zihzhan-msft
requested review from
ankitarorabit,
JianpingChen,
minnieliu and
a team
as code owners
ghost
added
the
zihzhan-msft
removed request for
a team,
JianpingChen,
minnieliu and
ankitarorabit
|
API changes have been detected in |
|
API changes have been detected in |
| @@ -1472,41 +1464,33 @@ private PlayAudioWithCallLocatorRequest getPlayAudioWithCallLocatorRequest(CallL | |||
| } | |||
| } | |||
|
|
|||
| private RedirectCallRequest getRedirectCallRequest(String incomingCallContext, List<CommunicationIdentifier> targets, | |||
| URI callbackUri, Integer timeoutInSeconds) { | |||
| private RedirectCallRequest getRedirectCallRequest(String incomingCallContext, CommunicationIdentifier target) { | |||
| Objects.requireNonNull(incomingCallContext, "'redirectCallRequest' cannot be null."); | |||
There was a problem hiding this comment.
shouldnt we let PMA throw these errors, and not the SDK
satyakonmsft
approved these changes
Nov 20, 2021
zihzhan-msft
merged commit 5b08e6b
into
Azure:feature/communication-CallingServer-preview
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Sep 28, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-08-02-preview (Azure#25891) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview * Updates readme * Updates API version in new specs and examples * update (Azure#25469) * Fix the IstioComponents structure (Azure#25492) * add netorkPolicy "none" (Azure#25511) * add netorkPolicy "none" value and description * add "none" enum value to networkPolicy * add addon autoscaling api (Azure#25479) * Update trusted access put and delete to async operation (Azure#25537) * Update trusted access put and delete to async operation * Update example * Update header * Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (Azure#25487) * Adding json changes * adding "daemonsets" to the custom-words * Editing "Expander" to "expander" * Removing daemonset custom word from this pr. look at: Azure/azure-rest-api-specs#25533 * Add AzureServiceMesh example (Azure#25560) * Add AzureServiceMesh example * Fix AKV resource id format * enrich ASM examples (Azure#25598) --------- Co-authored-by: deveshdama <[email protected]> Co-authored-by: robogatikov <[email protected]> Co-authored-by: Chih-Sheng Huang <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Youn Jae Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines