Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErrorOptions #25338

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Remove ErrorOptions #25338

merged 4 commits into from
Nov 16, 2021

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Nov 11, 2021

Currently, we do not have enough data points on how ErrorOptions will be used. So, making ErrorOptions enum and setErrorOptions in RequestOptions package-private. It may be re-introduced later if needed when we have more customer scenarios.

cc: @JonathanGiles

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes

-     public enum ErrorOptions {
-         THROW,
-         NO_THROW;
-     }
-         public RequestOptions setErrorOptions(EnumSet<ErrorOptions> errorOptions) 

@lmolkova
Copy link
Member

lmolkova commented Nov 12, 2021

The ErrorOptions came up in .NET partially to address users' complaints on traces and logs wrongfully reporting errors/warnings for cases like predictable 404 or 409/412. E.g. this one Azure/azure-sdk-for-net#21511, I can dig up multiple issues related to this on Application Insights in the context of e.g. storage or cosmos.

Having this option gives users control to silence noisy false negatives. We can wait for feedback to come and return it back of course.

related: #25157
#24195 - FYI - this was an ICM ticket.

@srnagar
Copy link
Member Author

srnagar commented Nov 12, 2021

@lmolkova yes, this is something we need to support but I guess the current ErrorOptions/RequestOptions will need to be modified a little to support high-level APIs too. So, this PR was to remove it for now until we have a design for both LLC & HLC.

@srnagar srnagar merged commit eb1b534 into Azure:main Nov 16, 2021
XiaofeiCao pushed a commit to XiaofeiCao/azure-sdk-for-java that referenced this pull request Nov 18, 2021
* Remove ErrorOptions

* revapi exclusion

* fix unit tests in WPS

* fix checkstyle
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Sep 22, 2023
[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2023-09-15 (Azure#25266)

* Adds base for updating Microsoft.DocumentDB from version stable/2023-04-15 to version 2023-09-15

* Updates readme

* Updates API version in new specs and examples

* burst capacity changes (Azure#25116) (Azure#25267)

* burst capacity changes

* Updated cosmos-db.json to include "type" of "Operation"

* Update cosmos-db.json to reflect customerManagedKeyStatus.

* lint fix (Azure#25336)

* Fixed typo and removed semantic reference

* Validation fix (Azure#25338)

* lint fix

* validation fix

* Added CustomerManagedKeyStatus enum and correspondent references.

* Update custom-words.txt

* Update cosmos-db.json

* rollback lint fix

* suppressing avocado errors

* Added space to rerun checks.

* prettier fix

* undo suppression as it is not working

* Added clarification for throughput/autoscaleSettings option

* removing added space

---------

Co-authored-by: vchske <[email protected]>
Co-authored-by: AdrianSibajaRetana <[email protected]>
Co-authored-by: carjackson-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants