-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ErrorOptions #25338
Remove ErrorOptions #25338
Conversation
API changes have been detected in API changes - public enum ErrorOptions {
- THROW,
- NO_THROW;
- }
- public RequestOptions setErrorOptions(EnumSet<ErrorOptions> errorOptions) |
The Having this option gives users control to silence noisy false negatives. We can wait for feedback to come and return it back of course. |
@lmolkova yes, this is something we need to support but I guess the current ErrorOptions/RequestOptions will need to be modified a little to support high-level APIs too. So, this PR was to remove it for now until we have a design for both LLC & HLC. |
* Remove ErrorOptions * revapi exclusion * fix unit tests in WPS * fix checkstyle
[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2023-09-15 (Azure#25266) * Adds base for updating Microsoft.DocumentDB from version stable/2023-04-15 to version 2023-09-15 * Updates readme * Updates API version in new specs and examples * burst capacity changes (Azure#25116) (Azure#25267) * burst capacity changes * Updated cosmos-db.json to include "type" of "Operation" * Update cosmos-db.json to reflect customerManagedKeyStatus. * lint fix (Azure#25336) * Fixed typo and removed semantic reference * Validation fix (Azure#25338) * lint fix * validation fix * Added CustomerManagedKeyStatus enum and correspondent references. * Update custom-words.txt * Update cosmos-db.json * rollback lint fix * suppressing avocado errors * Added space to rerun checks. * prettier fix * undo suppression as it is not working * Added clarification for throughput/autoscaleSettings option * removing added space --------- Co-authored-by: vchske <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> Co-authored-by: carjackson-msft <[email protected]>
Currently, we do not have enough data points on how ErrorOptions will be used. So, making
ErrorOptions
enum andsetErrorOptions
in RequestOptions package-private. It may be re-introduced later if needed when we have more customer scenarios.cc: @JonathanGiles