Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor Query - transition to new codesnippets tool #25262

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Nov 9, 2021

Fixes #24974

@srnagar srnagar requested a review from alzimmermsft November 9, 2021 20:51
@srnagar srnagar requested a review from pallavit as a code owner November 9, 2021 20:51
@srnagar srnagar enabled auto-merge (squash) November 9, 2021 20:51
@@ -178,7 +213,28 @@
*
* <p><strong>Execute a batch of logs queries</strong></p>
*
* {@codesnippet com.azure.monitor.query.LogsQueryAsyncClient.queryBatch#LogsBatchQuery}
* <!-- src_embed com.azure.monitor.query.LogsQueryAsyncClient.queryBatch#LogsBatchQuery -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should know this but ....

Did you have to manually add this to each method or did the javadoc build step did this automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags (<!-- src_embed) have to be updated manually (IntelliJ's find and replace helped) and then when you run mvn install, it should inject the code snippets.

Copy link
Contributor

@pallavit pallavit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@srnagar srnagar merged commit 31bf9d6 into Azure:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition azure-monitor-query to New Codesnippet Tooling
2 participants