Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Access Helper to JacksonAdapter #25004

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Oct 22, 2021

This PR adds a new configuration flag to JacksonAdapter which enables support for JacksonAdapter to use it's security permissions when making serialization calls. This helps resolve scenarios where an external application using an Azure SDK doesn't have reflective permissions that JacksonAdapter does.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels Oct 22, 2021
@alzimmermsft alzimmermsft self-assigned this Oct 22, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes

+         public static void setAccessHelper(Function<Callable<Object>, Object> accessHelper) 

@alzimmermsft
Copy link
Member Author

Another potential solution to this, which prevents changes to the public API, would be an environment configuration which points to a fully qualified Method to be used as the access helper. Ex, AZURE_JACKSONADAPTER_ACCESS_HELPER=com.myapp.apackagepath.AClass#theMethod

@lmolkova

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes

-         public static synchronized SerializerAdapter createDefaultSerializerAdapter() 
+         public static SerializerAdapter createDefaultSerializerAdapter() 

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes

-         public static synchronized SerializerAdapter createDefaultSerializerAdapter() 
+         public static SerializerAdapter createDefaultSerializerAdapter() 

@alzimmermsft alzimmermsft merged commit c2bd346 into Azure:main Nov 4, 2021
@alzimmermsft alzimmermsft deleted the AzCore_AddHookToSerializerAdapter branch November 4, 2021 23:31
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 29, 2023
[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2023-06-01 (Azure#25004)

* Adds base for updating Microsoft.AzureStackHCI from version stable/2023-03-01 to version 2023-06-01

* Updates readme

* Updates API version in new specs and examples

* Added changes for `2023-06-01`

* Added `x-ms-identifiers`

* Fixed prettier issue

---------

Co-authored-by: Prateek Prasher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants