In azure-spring-boot-bom, change certificate-starter's version to "${project.version}". #24734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"${project.version}".
2. Fix version error in certificate-starter's README.md.
chenrujun
requested review from
backwind1233,
michaelqi793,
moarychan,
saragluna,
stliu,
yiliuTo,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
ghost
added
the
chenrujun
commented
Oct 12, 2021
| @@ -92,7 +91,7 @@ | |||
| <dependency> | |||
| <groupId>com.azure.spring</groupId> | |||
| <artifactId>azure-spring-boot-starter-keyvault-certificates</artifactId> | |||
| <version>${azure.spring.boot.starter.keyvault.certificates.version}</version> | |||
| <version>${project.version}</version> | |||
There was a problem hiding this comment.
Hi, @mnriem .
FYI: If appconfiguration related modules' version same to other spring-cloud-azure-xxx, our bom will be much simplier.
If you don't want to change in main branch, could you please change in 4.0 branch?
chenrujun
changed the title
chenrujun
deleted the
In_azure-spring-boot-bom_change_certificate_starter_version_to_project_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24459.