Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated versions, changelog, and readme for monthly release #24727

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Updated versions, changelog, and readme for monthly release #24727

merged 4 commits into from
Oct 11, 2021

Conversation

rickle-msft
Copy link
Contributor

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Oct 11, 2021
@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests

@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

g2vinay
g2vinay reviewed Oct 11, 2021
View reviewed changes
sdk/storage/azure-storage-file-share/CHANGELOG.md
### Breaking Changes

### Bugs Fixed
#### Dependency Updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other Changes section should be above this header.

Copy link
Contributor

@kasobol-msft kasobol-msft Oct 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems odd to have 3 levels of header for just one paragraph. Should we aim to reduce number of paragraphs if list of changes for a version is simple enough?

g2vinay
g2vinay reviewed Oct 11, 2021
View reviewed changes
sdk/storage/azure-storage-internal-avro/CHANGELOG.md

### Other Changes
- Updated `azure-storage-common` to version `12.13.1`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add #### Dependency Updates section as sub header.

g2vinay
g2vinay reviewed Oct 11, 2021
View reviewed changes
sdk/storage/azure-storage-file-share/CHANGELOG.md Outdated
### Bugs Fixed
#### Dependency Updates
- Updated to version `12.13.1` of `azure-storage-common`
- Updated to version `1.21.0` of `azure-core`

### Other Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this above dep update section

@rickle-msft rickle-msft requested a review from mssfang as a code owner October 11, 2021 19:36
@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pallavit
Copy link
Contributor

@rickle-msft consider using the patch script next time, it will generate the right sections in the changelogs for you - https://github.com/Azure/azure-sdk-for-java/blob/main/eng/scripts/Generate-Patch.ps1

@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests-weekly

@rickle-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rickle-msft
Copy link
Contributor Author

@pallavit Thanks for the tip!! That looks like it'll save some time next month!

@rickle-msft rickle-msft merged commit 86ea64e into Azure:main Oct 11, 2021
pradomota pushed a commit to Telefonica/azure-sdk-for-java that referenced this pull request Feb 10, 2022
@rickle-msft @pradomota
Updated versions, changelog, and readme for monthly release (Azure#24727
5e2751f 
)

* Updated versions, changelog, and readme for monthly release

* Fixed a typo

* Added revapi suppression and pr feedback

* Updated revapi suppression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasobol-msft kasobol-msft kasobol-msft approved these changes

@g2vinay g2vinay g2vinay approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@samvaity samvaity Awaiting requested review from samvaity

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickle-msft @pallavit @g2vinay @kasobol-msft