Fix redirect policy to check header name for valid Redirect requests #24570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
samvaity
changed the title
chrwhit
reviewed
Oct 6, 2021
| && redirectUrl != null | ||
| && !alreadyAttemptedRedirectUrl(redirectUrl, attemptedRedirectUrls) | ||
| && isValidRedirectStatusCode(httpResponse.getStatusCode()) | ||
| if (isValidRedirectStatusCode(httpResponse.getStatusCode()) |
There was a problem hiding this comment.
To reduce nesting, you can check for (!isValidRedirectCount || !isAllowedRedirectMethod) then return false. That will allow you to remove the nested if statement.
Not Blocking
chrwhit
approved these changes
Oct 6, 2021
samvaity
requested review from
alzimmermsft,
anuchandy,
JonathanGiles,
lmolkova,
mssfang,
pallavit,
srnagar and
vcolin7
as code owners
alzimmermsft
reviewed
Oct 6, 2021
| String redirectUrl = tryGetRedirectHeader(httpResponse.getHeaders(), getLocationHeader()); | ||
| if (redirectUrl != null && !alreadyAttemptedRedirectUrl(redirectUrl, attemptedRedirectUrls)) { | ||
| logger.verbose("[Redirecting] Try count: {}, Attempted Redirect URLs: {}", tryCount, | ||
| attemptedRedirectUrls.toString()); |
There was a problem hiding this comment.
nit: Given that we aren't guaranteed to be able to log at INFO we should use the ClientLogger.log(LogLevel, Supplier<String>) log method that will defer the toString call here.
alzimmermsft
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix redirect policy to extract redirect header name only for Redirect requests.