-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure-search-documents to Use New Codesnippet Tooling #24527
Merged
alzimmermsft
merged 10 commits into
Azure:main
from
alzimmermsft:AzSearch_UseNewCodesnippetTooling
Oct 6, 2021
Merged
Update azure-search-documents to Use New Codesnippet Tooling #24527
alzimmermsft
merged 10 commits into
Azure:main
from
alzimmermsft:AzSearch_UseNewCodesnippetTooling
Oct 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Search
Client
This issue points to a problem in the data-plane of the library.
labels
Oct 4, 2021
alzimmermsft
requested review from
mssfang,
pallavit and
samvaity
as code owners
October 4, 2021 20:50
alzimmermsft
requested review from
anuchandy,
conniey,
JonathanGiles,
joshfree,
lmolkova and
srnagar
as code owners
October 4, 2021 23:02
alzimmermsft
requested review from
backwind1233,
chenrujun,
g2vinay,
michaelqi793,
moarychan,
saragluna,
stliu,
yiliuTo,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
October 5, 2021 20:37
mssfang
reviewed
Oct 6, 2021
@@ -128,8 +128,7 @@ The SDK provides three clients. | |||
To create a `SearchIndexClient/SearchIndexAsyncClient`, you will need the values of the Azure Cognitive Search service | |||
URL endpoint and admin key. | |||
|
|||
<!-- embedme ./src/samples/java/com/azure/search/documents/ReadmeSamples.java#L66-L69 --> | |||
```java | |||
```java readme-sample-createIndexClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow. Nice feature.
mssfang
approved these changes
Oct 6, 2021
32 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jun 26, 2023
update typescript.md in storagecache (Azure#24527) * update typescript.md in storagecache * update files * revert compute change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.