-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update identity api september 2021 #24512
Merged
g2vinay
merged 15 commits into
Azure:main
from
g2vinay:update-identity-api-september-2021
Oct 13, 2021
Merged
Update identity api september 2021 #24512
g2vinay
merged 15 commits into
Azure:main
from
g2vinay:update-identity-api-september-2021
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Azure.Identity
label
Oct 4, 2021
API changes have been detected in API changes + public AzureCliCredentialBuilder tenantId(String tenantId)
+ public AzurePowerShellCredentialBuilder tenantId(String tenantId)
- public T allowMultiTenantAuthentication() |
API changes have been detected in |
srnagar
approved these changes
Oct 8, 2021
sdk/identity/azure-identity/src/main/java/com/azure/identity/CredentialBuilderBase.java
Show resolved
Hide resolved
...ty/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientOptions.java
Outdated
Show resolved
Hide resolved
pallavit
reviewed
Oct 8, 2021
sdk/identity/azure-identity/src/main/java/com/azure/identity/AzurePowerShellCredential.java
Show resolved
Hide resolved
pallavit
reviewed
Oct 8, 2021
sdk/identity/azure-identity/src/main/java/com/azure/identity/DefaultAzureCredentialBuilder.java
Show resolved
Hide resolved
pallavit
reviewed
Oct 8, 2021
sdk/identity/azure-identity/src/main/java/com/azure/identity/CredentialBuilderBase.java
Show resolved
Hide resolved
pallavit
approved these changes
Oct 8, 2021
vcolin7
reviewed
Oct 8, 2021
sdk/identity/azure-identity/src/main/java/com/azure/identity/OnBehalfOfCredentialBuilder.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/OnBehalfOfCredentialBuilder.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/EnvironmentCredentialBuilder.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/ClientSecretCredentialBuilder.java
Show resolved
Hide resolved
...tity/azure-identity/src/main/java/com/azure/identity/ClientCertificateCredentialBuilder.java
Show resolved
Hide resolved
...ntity/azure-identity/src/main/java/com/azure/identity/AzureApplicationCredentialBuilder.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AzureApplicationCredential.java
Show resolved
Hide resolved
API changes have been detected in API changes - public OnBehalfOfCredential(String clientId, String tenantId, String clientSecret, String certificatePath, String certificatePassword, IdentityClientOptions identityClientOptions)
+ // This class does not have any public constructors, and is not able to be instantiated using 'new'. |
g2vinay
commented
Oct 12, 2021
g2vinay
requested review from
anuchandy,
conniey,
JonathanGiles and
lmolkova
as code owners
October 13, 2021 15:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24432 , #24728, #24610, #24282
Hides:
AzureApplicationCredential API
RegionalAuthority API
Addresses Arch board feedback.
Updates README.
Updates Tests.
Updates Multi Tenant Auth API as mentioned in #24432