-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for setting throughput on database creation #24456
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4ddf06e
add support for setting throughput on database creation
Blackbaud-MikeLueders d3fd91f
added section to readme
Blackbaud-MikeLueders 0882369
removed locale from links
Blackbaud-MikeLueders ab366c5
fix checkstyle issues
Blackbaud-MikeLueders e2b9378
do not overwrite cosmosTemplate
Blackbaud-MikeLueders File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...ta-cosmos/src/main/java/com/azure/spring/data/cosmos/config/DatabaseThroughputConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
package com.azure.spring.data.cosmos.config; | ||
|
||
/** | ||
* Throughput config for database creation | ||
*/ | ||
public class DatabaseThroughputConfig { | ||
|
||
private final boolean autoScale; | ||
private final int requestUnits; | ||
|
||
public DatabaseThroughputConfig(boolean autoScale, int requestUnits) { | ||
this.autoScale = autoScale; | ||
this.requestUnits = requestUnits; | ||
} | ||
|
||
public boolean isAutoScale() { | ||
return autoScale; | ||
} | ||
|
||
public int getRequestUnits() { | ||
return requestUnits; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return "DatabaseThroughputConfig{" | ||
+ "autoScale=" + autoScale | ||
+ ", requestUnits=" + requestUnits | ||
+ '}'; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 700 here ?
Where are we setting this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason for 700, the test is simply intended to verify that if the database throughput is provided, the database is created with that specific throughput. When defining the database throughput, some value for the request units needs to be provided - i just pulled 700 out of the air but it can be whatever. If you'd prefer another value, let me know and I can put that in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in answer to your question, it's used just below, when the CosmosConfig is created...
and then again when comparing the value of the created database actual throughput...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change the value, I was just curious about 700 :)
The test looks good to me.