Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audience for multi-cloud support #24237

Merged
merged 6 commits into from
Oct 5, 2021
Merged

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Sep 21, 2021

This PR adds builder methods to configure audience for multi-cloud support. This pattern is similar to the one used in ACR.

@srnagar srnagar requested a review from pallavit as a code owner September 21, 2021 20:15
@srnagar
Copy link
Member Author

srnagar commented Oct 4, 2021

/azp run java - monitor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-monitor-query. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-monitor-query. You can review API changes here

API changes

+         public static final LogsQueryClientAudience DEFAULT = fromString("https://api.monitor.azure.com");
+         public static final MetricsQueryClientAudience DEFAULT = fromString("https://management.azure.com");

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-monitor-query. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-monitor-query. You can review API changes here

API changes

+         public MetricResult getMetricByName(String metricName) 
-         public MetricResult getMetrics(String metricName) 

Copy link
Contributor

@pallavit pallavit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@srnagar srnagar enabled auto-merge (squash) October 5, 2021 21:47
@srnagar srnagar merged commit 4bf9b1e into Azure:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants