Fixed issue with onErrorDropped being called when using concatWith in QuorumReader #24180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagraThapar
requested review from
aayush3011,
FabianMeiswinkel,
kirankumarkolli,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
moderakh
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Thanks @kushagraThapar nice catch on the bug. Thanks for fixing it.
LGTM.
...re-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/QuorumReader.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
srnagar
approved these changes
Sep 16, 2021
srnagar
pushed a commit
to srnagar/azure-sdk-for-java
that referenced
this pull request
Sep 17, 2021
srnagar
pushed a commit
to srnagar/azure-sdk-for-java
that referenced
this pull request
Sep 20, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
May 29, 2023
Update REST documentation (Azure#24180) * modify doc * change all api versions * change description --------- Co-authored-by: Chenghui Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concatWithoperator in QuorumReader is not used correctly, and the error surfaced when reactor core fixed the behavior of FluxConcatArray in this PR - Rework FluxConcatArray to avoid unexpected thread switch reactor/reactor-core#2742 in the version 3.4.9 and above.