Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing the issue of not terminating unconfirmed-sends due to the termination of link with no error #24141

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Addressing the issue of not terminating unconfirmed-sends due to the termination of link with no error #24141

merged 2 commits into from
Sep 15, 2021

Conversation

anuchandy
Copy link
Member

  • Addressing the issue of not terminating unconfirmed-sends due to the server-side termination of link/session/connection endpoints with no error, not terminating such unconfirmed-sends was causing the Receiver to hang.
  • Adding Javadoc/comment to the implementation type RequestResponseChannel, rename / grouping its member variables to improve the readability (no functional/logic change).
  • None of the existing logging messages/formats are changed, as it's crucial for debugging.

@anuchandy
Addressing the issue of not terminating unconfirmed-sends due to the …
1dfbbd8 
…termination of link with no error, not terminating such unconfirmed-sends was causing the Receiver to hang.
@anuchandy anuchandy requested review from conniey and ki1729 September 15, 2021 00:48
@anuchandy anuchandy self-assigned this Sep 15, 2021
@anuchandy anuchandy requested a review from srnagar as a code owner September 15, 2021 00:48
@ghost ghost added the Azure.Core azure-core label Sep 15, 2021
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Event Hubs pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing) labels Sep 15, 2021
conniey
conniey approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for commenting the code!

...azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/RequestResponseChannel.java Outdated Show resolved Hide resolved
...azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/RequestResponseChannel.java Outdated Show resolved Hide resolved
@anuchandy anuchandy merged commit b703fe5 into Azure:main Sep 15, 2021
srnagar pushed a commit to srnagar/azure-sdk-for-java that referenced this pull request Sep 20, 2021
@anuchandy @srnagar
Addressing the issue of not terminating unconfirmed-sends due to the …
d73f32e 
…termination of link with no error (Azure#24141)

* Addressing the issue of not terminating unconfirmed-sends due to the termination of link with no error, not terminating such unconfirmed-sends was causing the Receiver to hang.

* Using this. qualifier consisent with rest of the code base
@conniey conniey mentioned this pull request Sep 20, 2021
Closed
3 tasks
@conniey conniey mentioned this pull request Sep 29, 2021
Closed
@my3sons my3sons mentioned this pull request Oct 7, 2021
Closed
@haolingdong-msft haolingdong-msft mentioned this pull request Feb 10, 2022
Closed
@anuchandy anuchandy mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conniey conniey conniey approved these changes

@joshfree joshfree joshfree approved these changes

@ki1729 ki1729 Awaiting requested review from ki1729

@srnagar srnagar Awaiting requested review from srnagar

Assignees

@anuchandy anuchandy

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Event Hubs pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuchandy @joshfree @conniey