Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support models repo metadata functionality and eliminate TryFromExpanded from API surface #24083

Merged
merged 25 commits into from
Oct 7, 2021

Conversation

avagraw
Copy link
Contributor

@avagraw avagraw commented Sep 13, 2021

No description provided.

@drwill-ms
Copy link

@avagraw Can you give more context to this change? Why are we deprecating?

@avagraw avagraw marked this pull request as draft September 14, 2021 00:18
@avagraw avagraw changed the title Deprecate Model Resolution TRY_FROM_EXPANDED from GetModels API Support models repo metadata functionality and eliminate TryFromExpanded from API surface Sep 27, 2021
@avagraw
Copy link
Contributor Author

avagraw commented Sep 27, 2021

Test changes to follow soon

@avagraw avagraw marked this pull request as ready for review September 27, 2021 22:34
@azabbasi azabbasi marked this pull request as draft October 6, 2021 01:44
@avagraw avagraw marked this pull request as ready for review October 7, 2021 18:55
Copy link
Contributor

@azabbasi azabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nit comments and more attention to new type's visibility is all. LGTM

@azabbasi azabbasi merged commit e329a8a into Azure:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants