Updating Schema Registry to cache responses. Adding tests #23565

conniey · 2021-08-13T21:16:49Z

Update Schema Registry to cache responses.
Adding integration tests.

…n/json.

...-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryClientBuilder.java

...y/src/test/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClientIntegrationTests.java

...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java

...y/src/test/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClientIntegrationTests.java

...re-data-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryClient.java

...ta-schemaregistry/src/main/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClient.java

...hemaregistry/src/test/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClientTests.java

conniey added 13 commits August 12, 2021 11:33

Make maxCacheSize package-private.

5541d53

Removes references to cache removal.

7f8cd6c

Move max/min sizes into builder.

a0a4ab1

Make SchemaRegistryClient's get with Response APIs package-private.

b8900d6

Make SchemaRegistryAsyncClient's get with Response APIs package-private.

dbc8cb5

Adding ErrorResponse.

1b287b3

Remove null checks (they're not needed according to spec).

ff6560d

(WIP)

4b55453

Returning HttpResponses when 404 or 400 is returned.

66ee1a7

Change content type to text/plain because it does not like applicatio…

405f230

…n/json.

Adding to idCache when registering/getting schema.

a00b577

Adding integration tests.

87cee52

Fixing expectations.

9468817

conniey requested a review from sjkwak as a code owner August 13, 2021 21:16

conniey self-assigned this Aug 13, 2021

conniey requested a review from srnagar as a code owner August 13, 2021 21:16

ghost added the Schema Registry label Aug 13, 2021

Update CHANGELOG.md

cd53c3c

conniey force-pushed the update-responses branch from 2a77d7d to cd53c3c Compare August 13, 2021 21:17

conniey added 5 commits August 13, 2021 15:17

Fix headers because they are no longer prefaced with x-

555aa2f

Fix response body to return byte[] so we stop deserializing it.

d857f38

Make SerializationType case-insensitive.

a071764

Fix response to decode byte[]

bb6e6e2

Update assertions.

dbd5d0d

srnagar reviewed Aug 13, 2021

View reviewed changes

conniey added 5 commits August 13, 2021 15:34

Update based on comments.

ea303d2

Remove unused class. Add test for 404.

234a8fb

Fix assertion logic.

af4f3f5

Updating tests.

29a2ec1

Adding one more test for querying.

9fbafc7

srnagar reviewed Aug 13, 2021

View reviewed changes

conniey added 5 commits August 13, 2021 16:42

Make correct ones package-private.

a7d1d8d

Remove mockito tests.

19e2d84

Rename session-records.

7df7847

Fixing checkstyle.

0eed94f

Remove uncalled method.

61c7d3e

srnagar approved these changes Aug 13, 2021

View reviewed changes

...hemaregistry/src/test/java/com/azure/data/schemaregistry/SchemaRegistryAsyncClientTests.java Outdated Show resolved Hide resolved

conniey added 9 commits August 15, 2021 09:07

Remove initializeBuilder()

3f7dbed

Replace with asyncClient calls.

69dc5b1

Updating headers.

60ff36e

Adding SchemaRegistryAsyncClient tests.

98c73e4

Adding session-records.json

cdcf7a9

Fixing extraction of schemaName.

b7adf08

Fixing mockito issues.

1eb1874

FIxing checkstyle issues.

4db474f

Fixing checkstyle issues.

c66c13a

conniey merged commit 91a4393 into Azure:main Aug 16, 2021

conniey deleted the update-responses branch August 16, 2021 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating Schema Registry to cache responses. Adding tests #23565

Updating Schema Registry to cache responses. Adding tests #23565

conniey commented Aug 13, 2021

Updating Schema Registry to cache responses. Adding tests #23565

Updating Schema Registry to cache responses. Adding tests #23565

Conversation

conniey commented Aug 13, 2021