Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description in azure-eventgrid to tell users to use azure-messaging-eventgrid #22326

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

YijunXieMS
Copy link
Contributor

@YijunXieMS YijunXieMS commented Jun 16, 2021

closes #22135

azure-eventgrid isn't in version_client.txt so there is no need to update there.
The last azure-eventgrid version on maven is 1.4.0-beta.1 (https://mvnrepository.com/artifact/com.microsoft.azure/azure-eventgrid). So this PR uses 1.4.0-beta.2.

@YijunXieMS YijunXieMS self-assigned this Jun 16, 2021
@YijunXieMS YijunXieMS requested a review from srnagar as a code owner June 16, 2021 19:24
@ghost ghost added the Event Grid label Jun 16, 2021
@ramya-rao-a
Copy link
Contributor

The last azure-eventgrid version on maven is 1.4.0-beta.1 (https://mvnrepository.com/artifact/com.microsoft.azure/azure-eventgrid). So this PR uses 1.4.0-beta.2.

We will soon be marking this package as deprecated. So it does not make sense to me to continue using the beta nomenclature. Can we get details from the package owners on what features were in beta in the last version and whether there are plans to ever make them GA?

I would recommend the following options

  • If the beta features are not meant to go GA, then either remove them and ship 1.4.0 or do a 1.3.1
  • If the beta features are meant to go GA, then do a direct 1.4.0

@YijunXieMS
Copy link
Contributor Author

The last azure-eventgrid version on maven is 1.4.0-beta.1 (https://mvnrepository.com/artifact/com.microsoft.azure/azure-eventgrid). So this PR uses 1.4.0-beta.2.

We will soon be marking this package as deprecated. So it does not make sense to me to continue using the beta nomenclature. Can we get details from the package owners on what features were in beta in the last version and whether there are plans to ever make them GA?

I would recommend the following options

  • If the beta features are not meant to go GA, then either remove them and ship 1.4.0 or do a 1.3.1
  • If the beta features are meant to go GA, then do a direct 1.4.0

The repo doesn't have a tag/release for the last GA version 1.2.0. Will need to use a tool to compare the current code in repo vs 1.2.0 source code to see if there is any risk. Will update this PR if the current code is good for GA.

@YijunXieMS YijunXieMS merged commit 692b9ce into Azure:main Jun 25, 2021
@YijunXieMS YijunXieMS deleted the azure-eventgrid-migration branch June 25, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Event Grid] Update package description for older package to point to the new one
3 participants