Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare azure-sdk-bom for Release #22001

Merged
merged 8 commits into from
Jun 3, 2021
Merged

Prepare azure-sdk-bom for Release #22001

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efedc26
Prepare azure-sdk-bom for Release
alzimmermsft Jun 1, 2021
9337435
Update to latest dependency checker version
alzimmermsft Jun 1, 2021
d758fc7
Merge branch 'master' into AzBom_NewRelease
alzimmermsft Jun 2, 2021
2b7b150
Update Checkpoint Store version
alzimmermsft Jun 2, 2021
51cedb2
Fix CHANGELOG version
alzimmermsft Jun 2, 2021
442765f
Test out wagon configurations for pipeline timeout issue
alzimmermsft Jun 2, 2021
57593f7
Merge branch 'master' into AzBom_NewRelease
alzimmermsft Jun 3, 2021
bbd2ed5
Revert wagon changes
alzimmermsft Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/versioning/external_dependencies.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ io.dropwizard.metrics:metrics-graphite;4.1.21
io.dropwizard.metrics:metrics-jvm;4.1.21
io.reactivex.rxjava2:rxjava;2.2.21
net.java.dev.jna:jna-platform;5.6.0
net.jonathangiles.tools:dependencyChecker-maven-plugin;1.0.5
net.jonathangiles.tools:dependencyChecker-maven-plugin;1.0.6
net.jonathangiles.tools:whitelistgenerator-maven-plugin;1.0.2
org.apache.commons:commons-collections4;4.2
org.apache.commons:commons-text;1.6
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@
<!-- <plugin>-->
<!-- <groupId>net.jonathangiles.tools</groupId>-->
<!-- <artifactId>dependencyChecker-maven-plugin</artifactId>-->
<!-- <version>1.0.5</version> &lt;!&ndash; {x-version-update;net.jonathangiles.tools:dependencyChecker-maven-plugin;external_dependency} &ndash;&gt;-->
<!-- <version>1.0.6</version> &lt;!&ndash; {x-version-update;net.jonathangiles.tools:dependencyChecker-maven-plugin;external_dependency} &ndash;&gt;-->
<!-- <inherited>false</inherited>-->
<!-- <executions>-->
<!-- <execution>-->
Expand Down
2 changes: 1 addition & 1 deletion sdk/boms/azure-sdk-bom/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release History

## 1.0.3-beta.1 (Unreleased)
## 1.0.3-beta.1 (2021-06-02)

### Dependency Updates

Expand Down
6 changes: 3 additions & 3 deletions sdk/boms/azure-sdk-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.azure</groupId>
<artifactId>azure-sdk-bom</artifactId>
<version>1.0.3-beta.1</version>
Copy link
Contributor

@pallavit pallavit Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For BOM - when do we choose to beta vs non-beta? #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BOM will be in beta status between releases but when being released it changes to GA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being unclear - do we want to GA every 3 months and then be in beta in between? Do we expect some feedback on the BOM files while we are in beta?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current plan is releasing a new azure-sdk-bom version at least once every three months. There are no plans on having betas in-between as the azure-sdk-bom provides no functionality but just manages dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that is why I was curious why we chose beta the last time :)

<version>1.0.3</version>
<packaging>pom</packaging>
<name>Azure Java SDK BOM (Bill of Materials)</name>
<description>Azure Java SDK BOM (Bill of Materials)</description>
Expand Down Expand Up @@ -179,7 +179,7 @@
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-messaging-eventhubs-checkpointstore-blob</artifactId>
<version>1.7.0</version>
<version>1.7.1</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -385,7 +385,7 @@
<plugin>
<groupId>net.jonathangiles.tools</groupId>
<artifactId>dependencyChecker-maven-plugin</artifactId>
<version>1.0.5</version> <!-- {x-version-update;net.jonathangiles.tools:dependencyChecker-maven-plugin;external_dependency} -->
<version>1.0.6</version> <!-- {x-version-update;net.jonathangiles.tools:dependencyChecker-maven-plugin;external_dependency} -->
<executions>
<execution>
<phase>package</phase>
Expand Down
2 changes: 1 addition & 1 deletion sdk/parents/azure-client-sdk-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@
<plugin>
<groupId>net.jonathangiles.tools</groupId>
<artifactId>dependencyChecker-maven-plugin</artifactId>
<version>1.0.5</version> <!-- {x-version-update;net.jonathangiles.tools:dependencyChecker-maven-plugin;external_dependency} -->
<version>1.0.6</version> <!-- {x-version-update;net.jonathangiles.tools:dependencyChecker-maven-plugin;external_dependency} -->
Copy link
Contributor

@pallavit pallavit Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this version include the changes you had done for error validation etc? #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version added better support for logging (which helped make dependency validation more performant) and added support for outputting the report into /target instead of the directory where the command was ran.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

<inherited>false</inherited>
<executions>
<execution>
Expand Down