Set AMQP connection idle timeout to 60 seconds. #21995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YijunXieMS
added
Azure.Core
YijunXieMS
requested review from
alzimmermsft,
anuchandy,
hemanttanwar,
jianghaolu and
srnagar
as code owners
conniey
approved these changes
Jun 1, 2021
...re-core-amqp/src/main/java/com/azure/core/amqp/implementation/handler/ConnectionHandler.java
Outdated
Show resolved
Hide resolved
hemanttanwar
approved these changes
Jun 1, 2021
chrwhit
added a commit
that referenced
this pull request
Jun 7, 2021
* Use different connection strings for Spring ServiceBus binders integration tests. (#21966) * update changelog (#21427) * update changelog for 3.5.0 entry * Upgrade Spring UTs/ITs to use JUnit 5. (#21670) * Fix Broken Link Explaining Spring Duration Conversions (#21942) * [Communication]: Remove unused code in pom and test files (#21654) * Remove unused code in pom and test files * Restore unintended change * Revert a test file change * Restore tests.yml * Remove unused env variable in tests.yml * Remove tests.yml * Keep skipping SMS tests in INT * Try to skip jacoco in INT * try different syntax * Try use string as much as we can * Try escape quotes * Try use a variable inside loop * Fix a typo * Move variable to a different place * Try Macro syntax * Remove variable, use stage name instead * Fix syntax * Try a different syntax * Try something simple * Move variables to the right place * Flip logic * Renamve variable * Give up on customizing jacoco.skip * Try to use variable to skp jacoco * Try different syntax * Move variable declaration * Try to set variable * Try PreSteps * Remove local variable * Remove unnecessary overwrite * Remove quotes Co-authored-by: JP Chen <[email protected]> * [Automation] Generate Fluent Lite from deviceprovisioningservices#package-2020-03 (#21938) Co-authored-by: timtay-microsoft <[email protected]> * Adds AsyncCloseable (#21991) * Adding AsyncCloseable with codesnippet. * Implementing AsyncCloseable and deleting AsyncAutoCloseable. * Add CHANGELOG entry. * Removing azure-core as an explicit dependency. * Fix use in AmqpReceiveLinkProcessor. * Sync eng/common directory with azure-sdk-tools for PR 1611 (#21853) * Add API status check * Increment package version after release of com.azure.resourcemanager azure-resourcemanager-deviceprovisioningservices (#21994) * Update Build Script to Perform Additional Tasks (#21993) * Arch board review feedback for ACR (#21913) * Update ACR changes * Update the swagger to the new values. * read me update * Add support for ACR beta 3 * Incorporate CR comments * Set AMQP connection idle timeout to 60 seconds. (#21995) * Angiurgiu/add missing chat thread async client options methods (#21939) * Removed the item return check on listReadReceipts for Live/Record tests. Removed .sleep statements * Added missing Options methods in ChatThreadAsyncClient * Updated incorrect test name used for logging Co-authored-by: Andrei Giurgiu <[email protected]> * add ut test for jre certificates (#21989) * Update the default authentication scope for the public cloud. (#22005) * Support getting rows as objects and map errors (#21997) * Update samples and map errors * Fix version tag * mgmt, support multiple source/destination ASG in NSG (#21980) * mgmt, support multiple source/destination ASG in NSG * checkstyle * changelog * Add integration test for keyvault certificate (#21573) * mgmt, fix sample as previous ARM template get deleted (#22011) * Add more test for jca integration test. (#21523) * azure-messaging-eventhubs-checkpointstore-blob Post Release Version Increment (#22010) * Update CODEOWNERs for Mixed Reality Authentication (#22004) This change adds me as a code owner of the Mixed Reality Authentication library. * Bump versions of core amqp and servicebus (#22020) * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22031) * Add autoscale RU support for azure-spring-data-cosmos (#21851) * Add autoscale RU support for azure-spring-data-cosmos Resolves #12711 * Added sample to read me for auto scale throughput * Fixed readme link Co-authored-by: Kushagra Thapar <[email protected]> * Adding a No Op version of the List RR with Options test, for code coverage (#22035) Co-authored-by: Andrei Giurgiu <[email protected]> * Prepare azure-sdk-bom for Release (#22001) Prepare azure-sdk-bom for Release * mgmt core, move ArmChallengeAuthenticationPolicy from experimental (#21961) * mgmt core, move ArmChallengeAuthenticationPolicy from experimental * reuse ArmChallengeAuthenticationPolicy in azure-resourcemanager-resources * Check if a queue exists but the name is used for a topic and vice versa (#19513) * add check existing queue * return an empty simple response * Make Library/Libraries Used in Bug Report More Explicit (#22047) Make Library/Libraries Used in Bug and Query Issue Templates More Explicit * Updaing AAP jar version for signed jar and moving it it azure devops feed from blob storage (#22046) * Add the ability to check for open pull request to a different repo. (#22059) Co-authored-by: Chidozie Ononiwu <[email protected]> * Use sparse-checkout When Performing a POM Only Release (#22037) Use sparse-checkout When Performing a POM Only Release * Dispose link immediately if updateDisposition timeout. (#22036) * Set azure-sdk-bom to In-Dev (#22052) Set azure-sdk-bom to In-Dev * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22062) * mgmt, aks support spot vm (#22016) * support spot vm in aks * changlog * rename method * Expose CbsAuthorizationType (#22072) * Adding CbsAuthorizationType model. * Deleting implementation CbsAuthorizationType. * Update AzureTokenManagerProvider to use ExpandableEnum CbsAuthorizationType. * Fix CbsAuthorizationType imports. * Fixing Event Hubs breaks. * Fix Service Bus breaks. * Addressed API Feedback for Storage STG77 (#22023) * Metrics Advisor SDK APIs aligning with most recent swagger updates (#21936) * Adding more doc to FeedType types and correcting typo in addFeedback API name * Using the name Sql, MongoDb, InfluxDb * Initial impl of credential entities and its integration with data feed * Apply Fluent, Immutable as appropriate * Updating listMetricEnrichedSeriesData signature to take detectionId as first argument * Renaming listAnomaliesForAlert and listAnomaliesForDetectionConfig to listAnomalies * Adding ClientOptions * Renaming listIncidentsForAlert and listIncidentsForDetectionConfig to listIncidents * Adding DimensionKey::get(..) and renaming TOPN enum-value to TOP_N * Add options overload API's * revert DataFeedIngestionOption changes * Updating BoundaryDirection, DataFeedRollupType, DataFeedSourceType and SingleBoundaryDirection to ExpandableStringEnum * Adding doc for DataFeedSource abstract type, renaming AzureCosmosDataFeedSource to AzureCosmosDbDataFeedSource, deleting unused ElasticsearchDataFeedSource and HttpRequestDataFeedSource * Removing setSubscriptionKey() and setApiKey(), instead adding an update method to atomically update the keys * MA Credentials: Removing Entity suffix and adding DataSource prefix * Rename ErrorCode to MetricsAdvisorErrorCode * update listDataFeedIngestionStatus * Addressing feedback for the last commit (Fixingspotbug and checkstyle) * consider datasource prefix for credential as one word (archfeedback) * Renaming DataSourceCredentialType to DatasourceCredentialType * Adding tests for Data Source Credentials. Rename userfacing type DataSourceAuthenticationType to DatasourceAuthenticationType (Datasource as one word) * Adding junit tests for data source cred async apis * Adding sync tests for Data Source Credentials and recordings * Adding samples and code snippets for Credential Entity API * Adding test skeleton for associating cred to datafeed * Use single word datasource for DataSourceDataLakeGen2SharedKey * Removing unsupported value 'Secondly' from Granularity * Hiding clientSecret getter from AzureLogAnalyticsDataFeedSource * Finishing Cred association with DataFeedSources * Completing tests for Cred association with DataFeedSources * Adding test recordings for Cred to DataFeedSource association * Adding cred association to AzureLogAnalytics DataFeed * Add valid cred for log analytics * rename to updateKey * rename env vars * Moving admin models to admininstration.models package * Removing equality assert on LogAna ids * Update Changelog (#7) * Fix pipeline error - export admin models (#8) * Moving MetricsAdvisorServiceVersion to root package * Override setDimensionFilter in Feedback types to ensure fluent chain * Adding addFeedbackWithResponse in sync client * Use the param name credentialId consistently, removing unsupported connectionstring cred from data-explorer * Rename DATA_LAKE_GEN2SHARED_KEY enum-val to DATA_LAKE_GEN2_SHARED_KEY, use DataFeedRollupSettings::rollupIdentificationValue param name consiistently * Use from prefix (instead of using prefix) for all factory methods to create data-source with credentials * Introduced MetricsAdvisorKeys that composes subscription and api key * Renaming error types to MetricsAdvisorError and MetricsAdvisorResponseException * update module info and add final Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> * Update AMQP Error Context and adding more AMQP error codes (#22060) * Adding documentation to potential Amqp errors. * Making valueMap for AmqpResponseCode final. * Update AmqpErrorContext to contain ErrorInfo. * Add revapi.json suppression. The serialization itself is compatible based on "Compatible changes" in https://docs.oracle.com/javase/6/docs/platform/serialization/spec/version.html#6678 * Adding test case. * Adding more error conditions. * Fixed mapping cosmos converter to handle value nodes (#22073) * Added value query suport to spring data cosmos query annotation * Fixed mapping cosmos converter regression * Test Wagon Changes to Determine Install Performance (#22082) Wagon Changes to Improve Install Performance * [Storage] Use FluxUtil for reliable download. (#22080) * first draft. * indent. * npes. * timeout. * fix empty case. * checkstyle * tests * Rename confidential ledger package (#22056) * Rename confidential ledger package * Use 1.0.0-beta.2 as dependency version * Added support for generating SAS tokens at the account and Table service level. (#21944) * Added support for generating SAS tokens at the Account and Table Service in all clients. Updated CHANGELOG. * Added partition key and row key values for SAS generation. * Fixed CheckStyle issues. * Fixed SpotBugs issue. * Removed more unused imports. * Renamed classes used for generating table-level SAS tokens. Made clients throw an exception when trying to generate SAS tokens if not authenticated with an AzureNamedKeyCredential. * Made client builders throw an IllegalStateException if more than one authentication setting is applied. * Changed module-info.java to export the tables package to all other packages. * Added tests for SAS models. * Added builder tests for when multiple forms of authentication are set. * Updated builders to throw when no endpoint or form of authentication are provided. * Fixed CheckStyle issues. * Fixed test name. * Removed unnecessary exports for implementation packages in module-info.java * Applied PR feedback: - Added extra clarity to when SAS models' toString() methods can return an empty String. - Removed unnecessary empty constructors in TableSasIpRange and TableSasPermission. - Changed builder parameter validation logic to the `buildClient()` and `buildAsyncClient()` methods. - Builders now also throw an IllegalStateException when calling `buildClient()` and `buildAsyncClient()` if multiple forms of authentication are provided, with the exception of 'sasToken' + 'connectionString'; or if 'endpoint' and/or 'sasToken' are set alongside a 'connectionString' and the endpoint and/or SAS token in the latter are different, respectively. - Removed "en-us" from all links in JavaDoc. - Updated CHANGELOG. * Added tests and renamed test classes to match clients and builders. * Updated CHANGELOG and client builders' JavaDoc. * Applied APIView feedback. * Updated CHANGELOG again. * Removed unused imports. Simplified SAS token comparison logic. * Fixed SAS token generation at the table level. Re-ordered query parameters in SAS tokens for both accounts and tables. Added tests for SAS tokens. * Updated CHANGELOG. * Fixed test and CheckStyle issues. * Added @immutable and @fluent annotations where appropriate. Made more models and classes in the sas package final. * Added more @immutable annotations. * Fetch specific branch name only in git-branch-push script (#21998) Co-authored-by: Ben Broderick Phillips <[email protected]> * Use generate matrix job name parameter as display name (#22089) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update proton-j and qpid-proton-j-extensions (#22081) * Use sparse checkout for Update Package Version release stage (#22002) * Fix subscription bugs in ReactorSession and ReactorConnection (#22085) * Fix error where Mono for dispose of was not being subscribed to. * Fix error where close operations were not being subscribed to. * Fixing distinct to distinctUntilChanged * Update CHANGELOG with authorization type. * mgmt, support parameters in policy (#22103) * mgmt, support parameters in policy * changelog * use immutable collection * Fixing max length of userAgent header (#22018) * Fixing max length of userAgent header * Addressed CR feedback * Restricting the total UserAgent length to 255 characters * Fixing unit test regression Co-authored-by: Xiaobing Zhu <[email protected]> Co-authored-by: zhihaoguo <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: timtay-microsoft <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Pallavi Taneja <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: angiurgiu <[email protected]> Co-authored-by: Andrei Giurgiu <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: lzc-1997-abel <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Craig Treasure <[email protected]> Co-authored-by: John Mannix <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]> Co-authored-by: Francesco Scuccimarri <[email protected]> Co-authored-by: Naveen Singh <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Gauri Prasad <[email protected]> Co-authored-by: Anu Thomas Chandy <[email protected]> Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Jianghao Lu <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]>
chrwhit
added a commit
that referenced
this pull request
Jun 9, 2021
* Use different connection strings for Spring ServiceBus binders integration tests. (#21966) * update changelog (#21427) * update changelog for 3.5.0 entry * Upgrade Spring UTs/ITs to use JUnit 5. (#21670) * Fix Broken Link Explaining Spring Duration Conversions (#21942) * [Communication]: Remove unused code in pom and test files (#21654) * Remove unused code in pom and test files * Restore unintended change * Revert a test file change * Restore tests.yml * Remove unused env variable in tests.yml * Remove tests.yml * Keep skipping SMS tests in INT * Try to skip jacoco in INT * try different syntax * Try use string as much as we can * Try escape quotes * Try use a variable inside loop * Fix a typo * Move variable to a different place * Try Macro syntax * Remove variable, use stage name instead * Fix syntax * Try a different syntax * Try something simple * Move variables to the right place * Flip logic * Renamve variable * Give up on customizing jacoco.skip * Try to use variable to skp jacoco * Try different syntax * Move variable declaration * Try to set variable * Try PreSteps * Remove local variable * Remove unnecessary overwrite * Remove quotes Co-authored-by: JP Chen <[email protected]> * [Automation] Generate Fluent Lite from deviceprovisioningservices#package-2020-03 (#21938) Co-authored-by: timtay-microsoft <[email protected]> * Adds AsyncCloseable (#21991) * Adding AsyncCloseable with codesnippet. * Implementing AsyncCloseable and deleting AsyncAutoCloseable. * Add CHANGELOG entry. * Removing azure-core as an explicit dependency. * Fix use in AmqpReceiveLinkProcessor. * Sync eng/common directory with azure-sdk-tools for PR 1611 (#21853) * Add API status check * Increment package version after release of com.azure.resourcemanager azure-resourcemanager-deviceprovisioningservices (#21994) * Update Build Script to Perform Additional Tasks (#21993) * Arch board review feedback for ACR (#21913) * Update ACR changes * Update the swagger to the new values. * read me update * Add support for ACR beta 3 * Incorporate CR comments * Set AMQP connection idle timeout to 60 seconds. (#21995) * Angiurgiu/add missing chat thread async client options methods (#21939) * Removed the item return check on listReadReceipts for Live/Record tests. Removed .sleep statements * Added missing Options methods in ChatThreadAsyncClient * Updated incorrect test name used for logging Co-authored-by: Andrei Giurgiu <[email protected]> * add ut test for jre certificates (#21989) * Update the default authentication scope for the public cloud. (#22005) * Support getting rows as objects and map errors (#21997) * Update samples and map errors * Fix version tag * mgmt, support multiple source/destination ASG in NSG (#21980) * mgmt, support multiple source/destination ASG in NSG * checkstyle * changelog * Add integration test for keyvault certificate (#21573) * mgmt, fix sample as previous ARM template get deleted (#22011) * Add more test for jca integration test. (#21523) * azure-messaging-eventhubs-checkpointstore-blob Post Release Version Increment (#22010) * Update CODEOWNERs for Mixed Reality Authentication (#22004) This change adds me as a code owner of the Mixed Reality Authentication library. * Bump versions of core amqp and servicebus (#22020) * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22031) * Add autoscale RU support for azure-spring-data-cosmos (#21851) * Add autoscale RU support for azure-spring-data-cosmos Resolves #12711 * Added sample to read me for auto scale throughput * Fixed readme link Co-authored-by: Kushagra Thapar <[email protected]> * Adding a No Op version of the List RR with Options test, for code coverage (#22035) Co-authored-by: Andrei Giurgiu <[email protected]> * Prepare azure-sdk-bom for Release (#22001) Prepare azure-sdk-bom for Release * mgmt core, move ArmChallengeAuthenticationPolicy from experimental (#21961) * mgmt core, move ArmChallengeAuthenticationPolicy from experimental * reuse ArmChallengeAuthenticationPolicy in azure-resourcemanager-resources * Check if a queue exists but the name is used for a topic and vice versa (#19513) * add check existing queue * return an empty simple response * Make Library/Libraries Used in Bug Report More Explicit (#22047) Make Library/Libraries Used in Bug and Query Issue Templates More Explicit * Updaing AAP jar version for signed jar and moving it it azure devops feed from blob storage (#22046) * Add the ability to check for open pull request to a different repo. (#22059) Co-authored-by: Chidozie Ononiwu <[email protected]> * Use sparse-checkout When Performing a POM Only Release (#22037) Use sparse-checkout When Performing a POM Only Release * Dispose link immediately if updateDisposition timeout. (#22036) * Set azure-sdk-bom to In-Dev (#22052) Set azure-sdk-bom to In-Dev * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22062) * mgmt, aks support spot vm (#22016) * support spot vm in aks * changlog * rename method * Expose CbsAuthorizationType (#22072) * Adding CbsAuthorizationType model. * Deleting implementation CbsAuthorizationType. * Update AzureTokenManagerProvider to use ExpandableEnum CbsAuthorizationType. * Fix CbsAuthorizationType imports. * Fixing Event Hubs breaks. * Fix Service Bus breaks. * Addressed API Feedback for Storage STG77 (#22023) * Metrics Advisor SDK APIs aligning with most recent swagger updates (#21936) * Adding more doc to FeedType types and correcting typo in addFeedback API name * Using the name Sql, MongoDb, InfluxDb * Initial impl of credential entities and its integration with data feed * Apply Fluent, Immutable as appropriate * Updating listMetricEnrichedSeriesData signature to take detectionId as first argument * Renaming listAnomaliesForAlert and listAnomaliesForDetectionConfig to listAnomalies * Adding ClientOptions * Renaming listIncidentsForAlert and listIncidentsForDetectionConfig to listIncidents * Adding DimensionKey::get(..) and renaming TOPN enum-value to TOP_N * Add options overload API's * revert DataFeedIngestionOption changes * Updating BoundaryDirection, DataFeedRollupType, DataFeedSourceType and SingleBoundaryDirection to ExpandableStringEnum * Adding doc for DataFeedSource abstract type, renaming AzureCosmosDataFeedSource to AzureCosmosDbDataFeedSource, deleting unused ElasticsearchDataFeedSource and HttpRequestDataFeedSource * Removing setSubscriptionKey() and setApiKey(), instead adding an update method to atomically update the keys * MA Credentials: Removing Entity suffix and adding DataSource prefix * Rename ErrorCode to MetricsAdvisorErrorCode * update listDataFeedIngestionStatus * Addressing feedback for the last commit (Fixingspotbug and checkstyle) * consider datasource prefix for credential as one word (archfeedback) * Renaming DataSourceCredentialType to DatasourceCredentialType * Adding tests for Data Source Credentials. Rename userfacing type DataSourceAuthenticationType to DatasourceAuthenticationType (Datasource as one word) * Adding junit tests for data source cred async apis * Adding sync tests for Data Source Credentials and recordings * Adding samples and code snippets for Credential Entity API * Adding test skeleton for associating cred to datafeed * Use single word datasource for DataSourceDataLakeGen2SharedKey * Removing unsupported value 'Secondly' from Granularity * Hiding clientSecret getter from AzureLogAnalyticsDataFeedSource * Finishing Cred association with DataFeedSources * Completing tests for Cred association with DataFeedSources * Adding test recordings for Cred to DataFeedSource association * Adding cred association to AzureLogAnalytics DataFeed * Add valid cred for log analytics * rename to updateKey * rename env vars * Moving admin models to admininstration.models package * Removing equality assert on LogAna ids * Update Changelog (#7) * Fix pipeline error - export admin models (#8) * Moving MetricsAdvisorServiceVersion to root package * Override setDimensionFilter in Feedback types to ensure fluent chain * Adding addFeedbackWithResponse in sync client * Use the param name credentialId consistently, removing unsupported connectionstring cred from data-explorer * Rename DATA_LAKE_GEN2SHARED_KEY enum-val to DATA_LAKE_GEN2_SHARED_KEY, use DataFeedRollupSettings::rollupIdentificationValue param name consiistently * Use from prefix (instead of using prefix) for all factory methods to create data-source with credentials * Introduced MetricsAdvisorKeys that composes subscription and api key * Renaming error types to MetricsAdvisorError and MetricsAdvisorResponseException * update module info and add final Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> * Update AMQP Error Context and adding more AMQP error codes (#22060) * Adding documentation to potential Amqp errors. * Making valueMap for AmqpResponseCode final. * Update AmqpErrorContext to contain ErrorInfo. * Add revapi.json suppression. The serialization itself is compatible based on "Compatible changes" in https://docs.oracle.com/javase/6/docs/platform/serialization/spec/version.html#6678 * Adding test case. * Adding more error conditions. * Fixed mapping cosmos converter to handle value nodes (#22073) * Added value query suport to spring data cosmos query annotation * Fixed mapping cosmos converter regression * Test Wagon Changes to Determine Install Performance (#22082) Wagon Changes to Improve Install Performance * [Storage] Use FluxUtil for reliable download. (#22080) * first draft. * indent. * npes. * timeout. * fix empty case. * checkstyle * tests * Rename confidential ledger package (#22056) * Rename confidential ledger package * Use 1.0.0-beta.2 as dependency version * Added support for generating SAS tokens at the account and Table service level. (#21944) * Added support for generating SAS tokens at the Account and Table Service in all clients. Updated CHANGELOG. * Added partition key and row key values for SAS generation. * Fixed CheckStyle issues. * Fixed SpotBugs issue. * Removed more unused imports. * Renamed classes used for generating table-level SAS tokens. Made clients throw an exception when trying to generate SAS tokens if not authenticated with an AzureNamedKeyCredential. * Made client builders throw an IllegalStateException if more than one authentication setting is applied. * Changed module-info.java to export the tables package to all other packages. * Added tests for SAS models. * Added builder tests for when multiple forms of authentication are set. * Updated builders to throw when no endpoint or form of authentication are provided. * Fixed CheckStyle issues. * Fixed test name. * Removed unnecessary exports for implementation packages in module-info.java * Applied PR feedback: - Added extra clarity to when SAS models' toString() methods can return an empty String. - Removed unnecessary empty constructors in TableSasIpRange and TableSasPermission. - Changed builder parameter validation logic to the `buildClient()` and `buildAsyncClient()` methods. - Builders now also throw an IllegalStateException when calling `buildClient()` and `buildAsyncClient()` if multiple forms of authentication are provided, with the exception of 'sasToken' + 'connectionString'; or if 'endpoint' and/or 'sasToken' are set alongside a 'connectionString' and the endpoint and/or SAS token in the latter are different, respectively. - Removed "en-us" from all links in JavaDoc. - Updated CHANGELOG. * Added tests and renamed test classes to match clients and builders. * Updated CHANGELOG and client builders' JavaDoc. * Applied APIView feedback. * Updated CHANGELOG again. * Removed unused imports. Simplified SAS token comparison logic. * Fixed SAS token generation at the table level. Re-ordered query parameters in SAS tokens for both accounts and tables. Added tests for SAS tokens. * Updated CHANGELOG. * Fixed test and CheckStyle issues. * Added @immutable and @fluent annotations where appropriate. Made more models and classes in the sas package final. * Added more @immutable annotations. * Fetch specific branch name only in git-branch-push script (#21998) Co-authored-by: Ben Broderick Phillips <[email protected]> * Use generate matrix job name parameter as display name (#22089) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update proton-j and qpid-proton-j-extensions (#22081) * Use sparse checkout for Update Package Version release stage (#22002) * Fix subscription bugs in ReactorSession and ReactorConnection (#22085) * Fix error where Mono for dispose of was not being subscribed to. * Fix error where close operations were not being subscribed to. * Fixing distinct to distinctUntilChanged * Update CHANGELOG with authorization type. * mgmt, support parameters in policy (#22103) * mgmt, support parameters in policy * changelog * use immutable collection * Fixing max length of userAgent header (#22018) * Fixing max length of userAgent header * Addressed CR feedback * Restricting the total UserAgent length to 255 characters * Fixing unit test regression Co-authored-by: Xiaobing Zhu <[email protected]> Co-authored-by: zhihaoguo <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: timtay-microsoft <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Pallavi Taneja <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: angiurgiu <[email protected]> Co-authored-by: Andrei Giurgiu <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: lzc-1997-abel <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Craig Treasure <[email protected]> Co-authored-by: John Mannix <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]> Co-authored-by: Francesco Scuccimarri <[email protected]> Co-authored-by: Naveen Singh <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Gauri Prasad <[email protected]> Co-authored-by: Anu Thomas Chandy <[email protected]> Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Jianghao Lu <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]>
chrwhit
added a commit
that referenced
this pull request
Jun 10, 2021
* Use different connection strings for Spring ServiceBus binders integration tests. (#21966) * update changelog (#21427) * update changelog for 3.5.0 entry * Upgrade Spring UTs/ITs to use JUnit 5. (#21670) * Fix Broken Link Explaining Spring Duration Conversions (#21942) * [Communication]: Remove unused code in pom and test files (#21654) * Remove unused code in pom and test files * Restore unintended change * Revert a test file change * Restore tests.yml * Remove unused env variable in tests.yml * Remove tests.yml * Keep skipping SMS tests in INT * Try to skip jacoco in INT * try different syntax * Try use string as much as we can * Try escape quotes * Try use a variable inside loop * Fix a typo * Move variable to a different place * Try Macro syntax * Remove variable, use stage name instead * Fix syntax * Try a different syntax * Try something simple * Move variables to the right place * Flip logic * Renamve variable * Give up on customizing jacoco.skip * Try to use variable to skp jacoco * Try different syntax * Move variable declaration * Try to set variable * Try PreSteps * Remove local variable * Remove unnecessary overwrite * Remove quotes Co-authored-by: JP Chen <[email protected]> * [Automation] Generate Fluent Lite from deviceprovisioningservices#package-2020-03 (#21938) Co-authored-by: timtay-microsoft <[email protected]> * Adds AsyncCloseable (#21991) * Adding AsyncCloseable with codesnippet. * Implementing AsyncCloseable and deleting AsyncAutoCloseable. * Add CHANGELOG entry. * Removing azure-core as an explicit dependency. * Fix use in AmqpReceiveLinkProcessor. * Sync eng/common directory with azure-sdk-tools for PR 1611 (#21853) * Add API status check * Increment package version after release of com.azure.resourcemanager azure-resourcemanager-deviceprovisioningservices (#21994) * Update Build Script to Perform Additional Tasks (#21993) * Arch board review feedback for ACR (#21913) * Update ACR changes * Update the swagger to the new values. * read me update * Add support for ACR beta 3 * Incorporate CR comments * Set AMQP connection idle timeout to 60 seconds. (#21995) * Angiurgiu/add missing chat thread async client options methods (#21939) * Removed the item return check on listReadReceipts for Live/Record tests. Removed .sleep statements * Added missing Options methods in ChatThreadAsyncClient * Updated incorrect test name used for logging Co-authored-by: Andrei Giurgiu <[email protected]> * add ut test for jre certificates (#21989) * Update the default authentication scope for the public cloud. (#22005) * Support getting rows as objects and map errors (#21997) * Update samples and map errors * Fix version tag * mgmt, support multiple source/destination ASG in NSG (#21980) * mgmt, support multiple source/destination ASG in NSG * checkstyle * changelog * Add integration test for keyvault certificate (#21573) * mgmt, fix sample as previous ARM template get deleted (#22011) * Add more test for jca integration test. (#21523) * azure-messaging-eventhubs-checkpointstore-blob Post Release Version Increment (#22010) * Update CODEOWNERs for Mixed Reality Authentication (#22004) This change adds me as a code owner of the Mixed Reality Authentication library. * Bump versions of core amqp and servicebus (#22020) * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22031) * Add autoscale RU support for azure-spring-data-cosmos (#21851) * Add autoscale RU support for azure-spring-data-cosmos Resolves #12711 * Added sample to read me for auto scale throughput * Fixed readme link Co-authored-by: Kushagra Thapar <[email protected]> * Adding a No Op version of the List RR with Options test, for code coverage (#22035) Co-authored-by: Andrei Giurgiu <[email protected]> * Prepare azure-sdk-bom for Release (#22001) Prepare azure-sdk-bom for Release * mgmt core, move ArmChallengeAuthenticationPolicy from experimental (#21961) * mgmt core, move ArmChallengeAuthenticationPolicy from experimental * reuse ArmChallengeAuthenticationPolicy in azure-resourcemanager-resources * Check if a queue exists but the name is used for a topic and vice versa (#19513) * add check existing queue * return an empty simple response * Make Library/Libraries Used in Bug Report More Explicit (#22047) Make Library/Libraries Used in Bug and Query Issue Templates More Explicit * Updaing AAP jar version for signed jar and moving it it azure devops feed from blob storage (#22046) * Add the ability to check for open pull request to a different repo. (#22059) Co-authored-by: Chidozie Ononiwu <[email protected]> * Use sparse-checkout When Performing a POM Only Release (#22037) Use sparse-checkout When Performing a POM Only Release * Dispose link immediately if updateDisposition timeout. (#22036) * Set azure-sdk-bom to In-Dev (#22052) Set azure-sdk-bom to In-Dev * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22062) * mgmt, aks support spot vm (#22016) * support spot vm in aks * changlog * rename method * Expose CbsAuthorizationType (#22072) * Adding CbsAuthorizationType model. * Deleting implementation CbsAuthorizationType. * Update AzureTokenManagerProvider to use ExpandableEnum CbsAuthorizationType. * Fix CbsAuthorizationType imports. * Fixing Event Hubs breaks. * Fix Service Bus breaks. * Addressed API Feedback for Storage STG77 (#22023) * Metrics Advisor SDK APIs aligning with most recent swagger updates (#21936) * Adding more doc to FeedType types and correcting typo in addFeedback API name * Using the name Sql, MongoDb, InfluxDb * Initial impl of credential entities and its integration with data feed * Apply Fluent, Immutable as appropriate * Updating listMetricEnrichedSeriesData signature to take detectionId as first argument * Renaming listAnomaliesForAlert and listAnomaliesForDetectionConfig to listAnomalies * Adding ClientOptions * Renaming listIncidentsForAlert and listIncidentsForDetectionConfig to listIncidents * Adding DimensionKey::get(..) and renaming TOPN enum-value to TOP_N * Add options overload API's * revert DataFeedIngestionOption changes * Updating BoundaryDirection, DataFeedRollupType, DataFeedSourceType and SingleBoundaryDirection to ExpandableStringEnum * Adding doc for DataFeedSource abstract type, renaming AzureCosmosDataFeedSource to AzureCosmosDbDataFeedSource, deleting unused ElasticsearchDataFeedSource and HttpRequestDataFeedSource * Removing setSubscriptionKey() and setApiKey(), instead adding an update method to atomically update the keys * MA Credentials: Removing Entity suffix and adding DataSource prefix * Rename ErrorCode to MetricsAdvisorErrorCode * update listDataFeedIngestionStatus * Addressing feedback for the last commit (Fixingspotbug and checkstyle) * consider datasource prefix for credential as one word (archfeedback) * Renaming DataSourceCredentialType to DatasourceCredentialType * Adding tests for Data Source Credentials. Rename userfacing type DataSourceAuthenticationType to DatasourceAuthenticationType (Datasource as one word) * Adding junit tests for data source cred async apis * Adding sync tests for Data Source Credentials and recordings * Adding samples and code snippets for Credential Entity API * Adding test skeleton for associating cred to datafeed * Use single word datasource for DataSourceDataLakeGen2SharedKey * Removing unsupported value 'Secondly' from Granularity * Hiding clientSecret getter from AzureLogAnalyticsDataFeedSource * Finishing Cred association with DataFeedSources * Completing tests for Cred association with DataFeedSources * Adding test recordings for Cred to DataFeedSource association * Adding cred association to AzureLogAnalytics DataFeed * Add valid cred for log analytics * rename to updateKey * rename env vars * Moving admin models to admininstration.models package * Removing equality assert on LogAna ids * Update Changelog (#7) * Fix pipeline error - export admin models (#8) * Moving MetricsAdvisorServiceVersion to root package * Override setDimensionFilter in Feedback types to ensure fluent chain * Adding addFeedbackWithResponse in sync client * Use the param name credentialId consistently, removing unsupported connectionstring cred from data-explorer * Rename DATA_LAKE_GEN2SHARED_KEY enum-val to DATA_LAKE_GEN2_SHARED_KEY, use DataFeedRollupSettings::rollupIdentificationValue param name consiistently * Use from prefix (instead of using prefix) for all factory methods to create data-source with credentials * Introduced MetricsAdvisorKeys that composes subscription and api key * Renaming error types to MetricsAdvisorError and MetricsAdvisorResponseException * update module info and add final Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> * Update AMQP Error Context and adding more AMQP error codes (#22060) * Adding documentation to potential Amqp errors. * Making valueMap for AmqpResponseCode final. * Update AmqpErrorContext to contain ErrorInfo. * Add revapi.json suppression. The serialization itself is compatible based on "Compatible changes" in https://docs.oracle.com/javase/6/docs/platform/serialization/spec/version.html#6678 * Adding test case. * Adding more error conditions. * Fixed mapping cosmos converter to handle value nodes (#22073) * Added value query suport to spring data cosmos query annotation * Fixed mapping cosmos converter regression * Test Wagon Changes to Determine Install Performance (#22082) Wagon Changes to Improve Install Performance * [Storage] Use FluxUtil for reliable download. (#22080) * first draft. * indent. * npes. * timeout. * fix empty case. * checkstyle * tests * Rename confidential ledger package (#22056) * Rename confidential ledger package * Use 1.0.0-beta.2 as dependency version * Added support for generating SAS tokens at the account and Table service level. (#21944) * Added support for generating SAS tokens at the Account and Table Service in all clients. Updated CHANGELOG. * Added partition key and row key values for SAS generation. * Fixed CheckStyle issues. * Fixed SpotBugs issue. * Removed more unused imports. * Renamed classes used for generating table-level SAS tokens. Made clients throw an exception when trying to generate SAS tokens if not authenticated with an AzureNamedKeyCredential. * Made client builders throw an IllegalStateException if more than one authentication setting is applied. * Changed module-info.java to export the tables package to all other packages. * Added tests for SAS models. * Added builder tests for when multiple forms of authentication are set. * Updated builders to throw when no endpoint or form of authentication are provided. * Fixed CheckStyle issues. * Fixed test name. * Removed unnecessary exports for implementation packages in module-info.java * Applied PR feedback: - Added extra clarity to when SAS models' toString() methods can return an empty String. - Removed unnecessary empty constructors in TableSasIpRange and TableSasPermission. - Changed builder parameter validation logic to the `buildClient()` and `buildAsyncClient()` methods. - Builders now also throw an IllegalStateException when calling `buildClient()` and `buildAsyncClient()` if multiple forms of authentication are provided, with the exception of 'sasToken' + 'connectionString'; or if 'endpoint' and/or 'sasToken' are set alongside a 'connectionString' and the endpoint and/or SAS token in the latter are different, respectively. - Removed "en-us" from all links in JavaDoc. - Updated CHANGELOG. * Added tests and renamed test classes to match clients and builders. * Updated CHANGELOG and client builders' JavaDoc. * Applied APIView feedback. * Updated CHANGELOG again. * Removed unused imports. Simplified SAS token comparison logic. * Fixed SAS token generation at the table level. Re-ordered query parameters in SAS tokens for both accounts and tables. Added tests for SAS tokens. * Updated CHANGELOG. * Fixed test and CheckStyle issues. * Added @immutable and @fluent annotations where appropriate. Made more models and classes in the sas package final. * Added more @immutable annotations. * Fetch specific branch name only in git-branch-push script (#21998) Co-authored-by: Ben Broderick Phillips <[email protected]> * Use generate matrix job name parameter as display name (#22089) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update proton-j and qpid-proton-j-extensions (#22081) * Use sparse checkout for Update Package Version release stage (#22002) * Fix subscription bugs in ReactorSession and ReactorConnection (#22085) * Fix error where Mono for dispose of was not being subscribed to. * Fix error where close operations were not being subscribed to. * Fixing distinct to distinctUntilChanged * Update CHANGELOG with authorization type. * mgmt, support parameters in policy (#22103) * mgmt, support parameters in policy * changelog * use immutable collection * Fixing max length of userAgent header (#22018) * Fixing max length of userAgent header * Addressed CR feedback * Restricting the total UserAgent length to 255 characters * Fixing unit test regression Co-authored-by: Xiaobing Zhu <[email protected]> Co-authored-by: zhihaoguo <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: timtay-microsoft <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Pallavi Taneja <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: angiurgiu <[email protected]> Co-authored-by: Andrei Giurgiu <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: lzc-1997-abel <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Craig Treasure <[email protected]> Co-authored-by: John Mannix <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]> Co-authored-by: Francesco Scuccimarri <[email protected]> Co-authored-by: Naveen Singh <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Gauri Prasad <[email protected]> Co-authored-by: Anu Thomas Chandy <[email protected]> Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Jianghao Lu <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]>
JianpingChen
added a commit
that referenced
this pull request
Jun 14, 2021
* Onboard Communication CallingServer Client SDK. * fix(callingServer): correct most style issues (#21915) * fix(callingServer): correct most style issues * fix(callingServer): correct most style issues * fix(*): revert generated files out of scope * Update FarmBeats SDK (#21836) * Update FarmBeats SDK * Release prep * Regenerate computer vision SDK (#21788) * Regenerate computer vision SDK * Update computer vision version * Unify README embedme Usage into a Wrapper Script (#21859) Unify README embedme Usage into a Wrapper Script * Enable caching of local maven repository (#21797) - Normalize the maven options across the pipelines - Use json/ps to produce artifact list instead of yml * Increment package version after release of com.azure azure-verticals-agrifood-farming (#21904) * Skip non-existant files during version update for hardcoded exceptions (#21905) * Fix build. * fix(*): finish style check, add test base (#21941) * Update swagger location and obj models. * Zihzhan/communication server calling (#21943) * Update swagger location and obj models. * Fix sourceAlternateIdentity not pass issue. * Style check fix. * Update API version. * unit test for CallClientBuilder and other samll fixes (#21964) * fix(*): add unit tests * fix(*): add sync conversation client tests * Fix AddParticipant issues (#21967) * Playback unit test for CallClient and CallAsyncClient (#22014) * Added Unit tests for CallClient and CallAsyncClient * comment change * Add-remove participant unit tests (#22025) * fix(*): remove test url * fix(*): style issues * Using the latest swagger file (#22038) * Added join call, add-remove participant for out-call (#22040) * sync with dot net sdk (#22044) * Adding PlayAudio Api to Conversation Client (Out-Call) (#22021) * Added the PlayAudio Api for Out-call/ConversationClient * Added test for the playAudio apis * Fixed test caused due to merge coonflicts * Minor fixes Co-authored-by: Paresh Arvind Patil <[email protected]> * Refactor code (#22053) * Deserialize events (#22064) * Fix review suggestions (#22068) * fix(*): fix issue with tests failing in maven (#22067) * fix(*): fix issue with tests failing in maven * fix(*): remove pom changes * fix review feedbacks (#22071) * unit tests for out-call add/remove (#22074) * unit tests for delete call (#22075) * remove unused generated events (#22076) * fix(*): fix package version issues * fix(*): add callingserver to version.txt * fix(*): update readme.md (not complete) * fix(*): fix package version issues * fix(*): update readme.md * fix(*): update readme.md * fix(*): remove instances of 'var' and adding correct type. 'var' fails in CI. * fix(*): update readme.md * fix(*): update readme.md * fix event de-serialization issue by adding deafult constructors (#22090) * fix(*): fix pom issue * PR review fixes (#22099) * fix review feedbacks * fix reviews * Use JSON annotated event definition (#22101) * Use json annotated event definition * update newly generated classes * pr review fix (#22108) * PR review fixes * PR review fixes * Merge latest master (#22113) * Use different connection strings for Spring ServiceBus binders integration tests. (#21966) * update changelog (#21427) * update changelog for 3.5.0 entry * Upgrade Spring UTs/ITs to use JUnit 5. (#21670) * Fix Broken Link Explaining Spring Duration Conversions (#21942) * [Communication]: Remove unused code in pom and test files (#21654) * Remove unused code in pom and test files * Restore unintended change * Revert a test file change * Restore tests.yml * Remove unused env variable in tests.yml * Remove tests.yml * Keep skipping SMS tests in INT * Try to skip jacoco in INT * try different syntax * Try use string as much as we can * Try escape quotes * Try use a variable inside loop * Fix a typo * Move variable to a different place * Try Macro syntax * Remove variable, use stage name instead * Fix syntax * Try a different syntax * Try something simple * Move variables to the right place * Flip logic * Renamve variable * Give up on customizing jacoco.skip * Try to use variable to skp jacoco * Try different syntax * Move variable declaration * Try to set variable * Try PreSteps * Remove local variable * Remove unnecessary overwrite * Remove quotes Co-authored-by: JP Chen <[email protected]> * [Automation] Generate Fluent Lite from deviceprovisioningservices#package-2020-03 (#21938) Co-authored-by: timtay-microsoft <[email protected]> * Adds AsyncCloseable (#21991) * Adding AsyncCloseable with codesnippet. * Implementing AsyncCloseable and deleting AsyncAutoCloseable. * Add CHANGELOG entry. * Removing azure-core as an explicit dependency. * Fix use in AmqpReceiveLinkProcessor. * Sync eng/common directory with azure-sdk-tools for PR 1611 (#21853) * Add API status check * Increment package version after release of com.azure.resourcemanager azure-resourcemanager-deviceprovisioningservices (#21994) * Update Build Script to Perform Additional Tasks (#21993) * Arch board review feedback for ACR (#21913) * Update ACR changes * Update the swagger to the new values. * read me update * Add support for ACR beta 3 * Incorporate CR comments * Set AMQP connection idle timeout to 60 seconds. (#21995) * Angiurgiu/add missing chat thread async client options methods (#21939) * Removed the item return check on listReadReceipts for Live/Record tests. Removed .sleep statements * Added missing Options methods in ChatThreadAsyncClient * Updated incorrect test name used for logging Co-authored-by: Andrei Giurgiu <[email protected]> * add ut test for jre certificates (#21989) * Update the default authentication scope for the public cloud. (#22005) * Support getting rows as objects and map errors (#21997) * Update samples and map errors * Fix version tag * mgmt, support multiple source/destination ASG in NSG (#21980) * mgmt, support multiple source/destination ASG in NSG * checkstyle * changelog * Add integration test for keyvault certificate (#21573) * mgmt, fix sample as previous ARM template get deleted (#22011) * Add more test for jca integration test. (#21523) * azure-messaging-eventhubs-checkpointstore-blob Post Release Version Increment (#22010) * Update CODEOWNERs for Mixed Reality Authentication (#22004) This change adds me as a code owner of the Mixed Reality Authentication library. * Bump versions of core amqp and servicebus (#22020) * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22031) * Add autoscale RU support for azure-spring-data-cosmos (#21851) * Add autoscale RU support for azure-spring-data-cosmos Resolves #12711 * Added sample to read me for auto scale throughput * Fixed readme link Co-authored-by: Kushagra Thapar <[email protected]> * Adding a No Op version of the List RR with Options test, for code coverage (#22035) Co-authored-by: Andrei Giurgiu <[email protected]> * Prepare azure-sdk-bom for Release (#22001) Prepare azure-sdk-bom for Release * mgmt core, move ArmChallengeAuthenticationPolicy from experimental (#21961) * mgmt core, move ArmChallengeAuthenticationPolicy from experimental * reuse ArmChallengeAuthenticationPolicy in azure-resourcemanager-resources * Check if a queue exists but the name is used for a topic and vice versa (#19513) * add check existing queue * return an empty simple response * Make Library/Libraries Used in Bug Report More Explicit (#22047) Make Library/Libraries Used in Bug and Query Issue Templates More Explicit * Updaing AAP jar version for signed jar and moving it it azure devops feed from blob storage (#22046) * Add the ability to check for open pull request to a different repo. (#22059) Co-authored-by: Chidozie Ononiwu <[email protected]> * Use sparse-checkout When Performing a POM Only Release (#22037) Use sparse-checkout When Performing a POM Only Release * Dispose link immediately if updateDisposition timeout. (#22036) * Set azure-sdk-bom to In-Dev (#22052) Set azure-sdk-bom to In-Dev * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22062) * mgmt, aks support spot vm (#22016) * support spot vm in aks * changlog * rename method * Expose CbsAuthorizationType (#22072) * Adding CbsAuthorizationType model. * Deleting implementation CbsAuthorizationType. * Update AzureTokenManagerProvider to use ExpandableEnum CbsAuthorizationType. * Fix CbsAuthorizationType imports. * Fixing Event Hubs breaks. * Fix Service Bus breaks. * Addressed API Feedback for Storage STG77 (#22023) * Metrics Advisor SDK APIs aligning with most recent swagger updates (#21936) * Adding more doc to FeedType types and correcting typo in addFeedback API name * Using the name Sql, MongoDb, InfluxDb * Initial impl of credential entities and its integration with data feed * Apply Fluent, Immutable as appropriate * Updating listMetricEnrichedSeriesData signature to take detectionId as first argument * Renaming listAnomaliesForAlert and listAnomaliesForDetectionConfig to listAnomalies * Adding ClientOptions * Renaming listIncidentsForAlert and listIncidentsForDetectionConfig to listIncidents * Adding DimensionKey::get(..) and renaming TOPN enum-value to TOP_N * Add options overload API's * revert DataFeedIngestionOption changes * Updating BoundaryDirection, DataFeedRollupType, DataFeedSourceType and SingleBoundaryDirection to ExpandableStringEnum * Adding doc for DataFeedSource abstract type, renaming AzureCosmosDataFeedSource to AzureCosmosDbDataFeedSource, deleting unused ElasticsearchDataFeedSource and HttpRequestDataFeedSource * Removing setSubscriptionKey() and setApiKey(), instead adding an update method to atomically update the keys * MA Credentials: Removing Entity suffix and adding DataSource prefix * Rename ErrorCode to MetricsAdvisorErrorCode * update listDataFeedIngestionStatus * Addressing feedback for the last commit (Fixingspotbug and checkstyle) * consider datasource prefix for credential as one word (archfeedback) * Renaming DataSourceCredentialType to DatasourceCredentialType * Adding tests for Data Source Credentials. Rename userfacing type DataSourceAuthenticationType to DatasourceAuthenticationType (Datasource as one word) * Adding junit tests for data source cred async apis * Adding sync tests for Data Source Credentials and recordings * Adding samples and code snippets for Credential Entity API * Adding test skeleton for associating cred to datafeed * Use single word datasource for DataSourceDataLakeGen2SharedKey * Removing unsupported value 'Secondly' from Granularity * Hiding clientSecret getter from AzureLogAnalyticsDataFeedSource * Finishing Cred association with DataFeedSources * Completing tests for Cred association with DataFeedSources * Adding test recordings for Cred to DataFeedSource association * Adding cred association to AzureLogAnalytics DataFeed * Add valid cred for log analytics * rename to updateKey * rename env vars * Moving admin models to admininstration.models package * Removing equality assert on LogAna ids * Update Changelog (#7) * Fix pipeline error - export admin models (#8) * Moving MetricsAdvisorServiceVersion to root package * Override setDimensionFilter in Feedback types to ensure fluent chain * Adding addFeedbackWithResponse in sync client * Use the param name credentialId consistently, removing unsupported connectionstring cred from data-explorer * Rename DATA_LAKE_GEN2SHARED_KEY enum-val to DATA_LAKE_GEN2_SHARED_KEY, use DataFeedRollupSettings::rollupIdentificationValue param name consiistently * Use from prefix (instead of using prefix) for all factory methods to create data-source with credentials * Introduced MetricsAdvisorKeys that composes subscription and api key * Renaming error types to MetricsAdvisorError and MetricsAdvisorResponseException * update module info and add final Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> * Update AMQP Error Context and adding more AMQP error codes (#22060) * Adding documentation to potential Amqp errors. * Making valueMap for AmqpResponseCode final. * Update AmqpErrorContext to contain ErrorInfo. * Add revapi.json suppression. The serialization itself is compatible based on "Compatible changes" in https://docs.oracle.com/javase/6/docs/platform/serialization/spec/version.html#6678 * Adding test case. * Adding more error conditions. * Fixed mapping cosmos converter to handle value nodes (#22073) * Added value query suport to spring data cosmos query annotation * Fixed mapping cosmos converter regression * Test Wagon Changes to Determine Install Performance (#22082) Wagon Changes to Improve Install Performance * [Storage] Use FluxUtil for reliable download. (#22080) * first draft. * indent. * npes. * timeout. * fix empty case. * checkstyle * tests * Rename confidential ledger package (#22056) * Rename confidential ledger package * Use 1.0.0-beta.2 as dependency version * Added support for generating SAS tokens at the account and Table service level. (#21944) * Added support for generating SAS tokens at the Account and Table Service in all clients. Updated CHANGELOG. * Added partition key and row key values for SAS generation. * Fixed CheckStyle issues. * Fixed SpotBugs issue. * Removed more unused imports. * Renamed classes used for generating table-level SAS tokens. Made clients throw an exception when trying to generate SAS tokens if not authenticated with an AzureNamedKeyCredential. * Made client builders throw an IllegalStateException if more than one authentication setting is applied. * Changed module-info.java to export the tables package to all other packages. * Added tests for SAS models. * Added builder tests for when multiple forms of authentication are set. * Updated builders to throw when no endpoint or form of authentication are provided. * Fixed CheckStyle issues. * Fixed test name. * Removed unnecessary exports for implementation packages in module-info.java * Applied PR feedback: - Added extra clarity to when SAS models' toString() methods can return an empty String. - Removed unnecessary empty constructors in TableSasIpRange and TableSasPermission. - Changed builder parameter validation logic to the `buildClient()` and `buildAsyncClient()` methods. - Builders now also throw an IllegalStateException when calling `buildClient()` and `buildAsyncClient()` if multiple forms of authentication are provided, with the exception of 'sasToken' + 'connectionString'; or if 'endpoint' and/or 'sasToken' are set alongside a 'connectionString' and the endpoint and/or SAS token in the latter are different, respectively. - Removed "en-us" from all links in JavaDoc. - Updated CHANGELOG. * Added tests and renamed test classes to match clients and builders. * Updated CHANGELOG and client builders' JavaDoc. * Applied APIView feedback. * Updated CHANGELOG again. * Removed unused imports. Simplified SAS token comparison logic. * Fixed SAS token generation at the table level. Re-ordered query parameters in SAS tokens for both accounts and tables. Added tests for SAS tokens. * Updated CHANGELOG. * Fixed test and CheckStyle issues. * Added @Immutable and @Fluent annotations where appropriate. Made more models and classes in the sas package final. * Added more @Immutable annotations. * Fetch specific branch name only in git-branch-push script (#21998) Co-authored-by: Ben Broderick Phillips <[email protected]> * Use generate matrix job name parameter as display name (#22089) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update proton-j and qpid-proton-j-extensions (#22081) * Use sparse checkout for Update Package Version release stage (#22002) * Fix subscription bugs in ReactorSession and ReactorConnection (#22085) * Fix error where Mono for dispose of was not being subscribed to. * Fix error where close operations were not being subscribed to. * Fixing distinct to distinctUntilChanged * Update CHANGELOG with authorization type. * mgmt, support parameters in policy (#22103) * mgmt, support parameters in policy * changelog * use immutable collection * Fixing max length of userAgent header (#22018) * Fixing max length of userAgent header * Addressed CR feedback * Restricting the total UserAgent length to 255 characters * Fixing unit test regression Co-authored-by: Xiaobing Zhu <[email protected]> Co-authored-by: zhihaoguo <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: timtay-microsoft <[email protected]> Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Pallavi Taneja <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: angiurgiu <[email protected]> Co-authored-by: Andrei Giurgiu <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: lzc-1997-abel <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Craig Treasure <[email protected]> Co-authored-by: John Mannix <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]> Co-authored-by: Francesco Scuccimarri <[email protected]> Co-authored-by: Naveen Singh <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Gauri Prasad <[email protected]> Co-authored-by: Anu Thomas Chandy <[email protected]> Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Jianghao Lu <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]> * pr review fix (#22125) * pr review fix * pr review fix * Chrwhit/master update two (#22123) * Exposes management node in azure-core-amqp (#22095) * Update AmqpConnection to have a getManagementNode. * Adding AmqpManagementNode. * Update AmqpConnection, AmqpManagementNode, AmqpSession to use AsyncCloseable. * Adding AsyncCloseable to AmqpLink. * ClaimsBasedSecurityNode.java uses AsyncCloseable. * Implements CbsNode's closeAsync() and adds tests. * ReactorSession implements closeAsync() * ReactorConnection uses closeAsync(). Renames dispose() to closeAsync(). Fixes errors where some close operations were not subscribed to. * RequestResponseChannel. Remove close operation with message. * Adding DeliveryOutcome models and DeliveryState enum. * Add authorization scope to connection options. * Add MessageUtils to serialize and deserialize AmqpAnnotatedMessage * Update AmqpManagementNode to expose delivery outcomes because they can be associated with messages. * Adding MessageUtil support for converting DeliveryOutcome and Outcomes. * Fixing build breaks from ConnectionOptions. * Adding management channel class. * Adding management channel into ReactorConnection. * Update ExceptionUtil to return instead of throwing on unknown amqp error codes. * Moving ManagementChannel formatting. * Add javadocs to ReceivedDeliveryOutcome. * Add tests for ManagementChannel * Adding tests for message utils. * Fix javadoc on ModifiedDeliveryOutcome * ReactorConnection: Hook up dispose method. * EventHubs: Fixing instances of ConnectionOptions. * ServiceBus: Fix build errors using ConnectionOptions. * Adding MessageUtilsTests. * Updating CHANGELOG. * Annotate HttpRange with Immutable (#22119) * Cosmos Spark: Changing inferSchema.forceNullableProperties default to true (#22049) * Changing default * Docs * Tests * new test * doc update * Change log * Make getScopes in the ARM Authentication Policy Public (#22120) Make getScopes in the ARM Authentication Policy Public Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Matias Quaranta <[email protected]> * pr review fix (#22131) * PR review fix (#22138) * PR review fix * PR review fix * pr review fix * Chrwhit/merge master three (#22146) * Exposes management node in azure-core-amqp (#22095) * Update AmqpConnection to have a getManagementNode. * Adding AmqpManagementNode. * Update AmqpConnection, AmqpManagementNode, AmqpSession to use AsyncCloseable. * Adding AsyncCloseable to AmqpLink. * ClaimsBasedSecurityNode.java uses AsyncCloseable. * Implements CbsNode's closeAsync() and adds tests. * ReactorSession implements closeAsync() * ReactorConnection uses closeAsync(). Renames dispose() to closeAsync(). Fixes errors where some close operations were not subscribed to. * RequestResponseChannel. Remove close operation with message. * Adding DeliveryOutcome models and DeliveryState enum. * Add authorization scope to connection options. * Add MessageUtils to serialize and deserialize AmqpAnnotatedMessage * Update AmqpManagementNode to expose delivery outcomes because they can be associated with messages. * Adding MessageUtil support for converting DeliveryOutcome and Outcomes. * Fixing build breaks from ConnectionOptions. * Adding management channel class. * Adding management channel into ReactorConnection. * Update ExceptionUtil to return instead of throwing on unknown amqp error codes. * Moving ManagementChannel formatting. * Add javadocs to ReceivedDeliveryOutcome. * Add tests for ManagementChannel * Adding tests for message utils. * Fix javadoc on ModifiedDeliveryOutcome * ReactorConnection: Hook up dispose method. * EventHubs: Fixing instances of ConnectionOptions. * ServiceBus: Fix build errors using ConnectionOptions. * Adding MessageUtilsTests. * Updating CHANGELOG. * Annotate HttpRange with Immutable (#22119) * Cosmos Spark: Changing inferSchema.forceNullableProperties default to true (#22049) * Changing default * Docs * Tests * new test * doc update * Change log * Make getScopes in the ARM Authentication Policy Public (#22120) Make getScopes in the ARM Authentication Policy Public * [Communication]: Update version, changelog, and dependency for June release (#22061) * Update version, changelog, and dependency for June release * Update Chat, SMS, and PhoneNumbers for release * Correction for chat version number * Typo in chat pom * Unrelease Chat; update change logs for other sdks * Nit fix Co-authored-by: JP Chen <[email protected]> * Increment version for videoanalyzer releases (#21814) * Increment package version after release of com.azure azure-media-videoanalyzer-edge * Update version_client.txt Co-authored-by: giakas <[email protected]> * Add module-info to jca and jca test module and change package name of jca test module (#22041) * Fix error in aad-starter-sample (#22109) * EventGrid Add 4.4.0 new system events. (#22126) * Updates to monitor query based on API review feedback (#22114) * API consistency review feedback * Remove commented code * fix tests * Refactor building prefer header * Fix Management Bug (#22122) * Adding missing return statement. * Using common logic for status codes. * Adding isSuccessful. * mgmt, upgrade aks (#22136) * Add domain_hint in aad-stater. (#22134) * fix(*): update communication comon package version in callingServer Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: giakas <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Rujun Chen <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: gaohan <[email protected]> * Chrwhit/merge master four (#22151) * Exposes management node in azure-core-amqp (#22095) * Update AmqpConnection to have a getManagementNode. * Adding AmqpManagementNode. * Update AmqpConnection, AmqpManagementNode, AmqpSession to use AsyncCloseable. * Adding AsyncCloseable to AmqpLink. * ClaimsBasedSecurityNode.java uses AsyncCloseable. * Implements CbsNode's closeAsync() and adds tests. * ReactorSession implements closeAsync() * ReactorConnection uses closeAsync(). Renames dispose() to closeAsync(). Fixes errors where some close operations were not subscribed to. * RequestResponseChannel. Remove close operation with message. * Adding DeliveryOutcome models and DeliveryState enum. * Add authorization scope to connection options. * Add MessageUtils to serialize and deserialize AmqpAnnotatedMessage * Update AmqpManagementNode to expose delivery outcomes because they can be associated with messages. * Adding MessageUtil support for converting DeliveryOutcome and Outcomes. * Fixing build breaks from ConnectionOptions. * Adding management channel class. * Adding management channel into ReactorConnection. * Update ExceptionUtil to return instead of throwing on unknown amqp error codes. * Moving ManagementChannel formatting. * Add javadocs to ReceivedDeliveryOutcome. * Add tests for ManagementChannel * Adding tests for message utils. * Fix javadoc on ModifiedDeliveryOutcome * ReactorConnection: Hook up dispose method. * EventHubs: Fixing instances of ConnectionOptions. * ServiceBus: Fix build errors using ConnectionOptions. * Adding MessageUtilsTests. * Updating CHANGELOG. * Annotate HttpRange with Immutable (#22119) * Cosmos Spark: Changing inferSchema.forceNullableProperties default to true (#22049) * Changing default * Docs * Tests * new test * doc update * Change log * Make getScopes in the ARM Authentication Policy Public (#22120) Make getScopes in the ARM Authentication Policy Public * [Communication]: Update version, changelog, and dependency for June release (#22061) * Update version, changelog, and dependency for June release * Update Chat, SMS, and PhoneNumbers for release * Correction for chat version number * Typo in chat pom * Unrelease Chat; update change logs for other sdks * Nit fix Co-authored-by: JP Chen <[email protected]> * Increment version for videoanalyzer releases (#21814) * Increment package version after release of com.azure azure-media-videoanalyzer-edge * Update version_client.txt Co-authored-by: giakas <[email protected]> * Add module-info to jca and jca test module and change package name of jca test module (#22041) * Fix error in aad-starter-sample (#22109) * EventGrid Add 4.4.0 new system events. (#22126) * Updates to monitor query based on API review feedback (#22114) * API consistency review feedback * Remove commented code * fix tests * Refactor building prefer header * Fix Management Bug (#22122) * Adding missing return statement. * Using common logic for status codes. * Adding isSuccessful. * mgmt, upgrade aks (#22136) * Add domain_hint in aad-stater. (#22134) * Increment version for core releases (#22124) Increment package version after release of Core libraries * Update datafeed tests to remove error code asserts (#22121) * Made Tables service interfaces public (#22130) * Made service interfaces public for Key Vault and Tables impl clients. * Removed kvErrorStrings.properties files from Key Vault SDKs. Made KeyVaultErrorCodeStrings store the constants that were in the files. * Added check for null credentials in Key Vault Administration Builders. * Reverted changes made to KV libraries. * Adding lmolkova as owner for core, opentelemetry, and azure monitor exporter (#22128) * Re-generate EventGrid 4.4.0 events without FarmsBeat events (#22148) * Client throughput control: Deferring store invocation (#22144) * Dummy * Deferring teh request when ClinetThrouhgputControl is enabled * Client throughput control: defer store invocation * Adding additional test-coverage in throughput tests * Reacting to code review feedback. * Adding back createItem_withBulk test * Sync eng/common directory with azure-sdk-tools for PR 1633 (#22145) * Update format of new Changelog Entry * Add parsing of changelog sections * Update ChangeLog Logic Co-authored-by: Chidozie Ononiwu <[email protected]> * fix(*): update server calling pom Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: giakas <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Rujun Chen <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> * fix(*): add tests, 70% coverage * fix(*): remove var * new schema fix + new class model (#22164) * New swagger schema applied * New class model applied * roll back azure common lib (#22165) * Chrwhit/merge master five (#22177) * Exposes management node in azure-core-amqp (#22095) * Update AmqpConnection to have a getManagementNode. * Adding AmqpManagementNode. * Update AmqpConnection, AmqpManagementNode, AmqpSession to use AsyncCloseable. * Adding AsyncCloseable to AmqpLink. * ClaimsBasedSecurityNode.java uses AsyncCloseable. * Implements CbsNode's closeAsync() and adds tests. * ReactorSession implements closeAsync() * ReactorConnection uses closeAsync(). Renames dispose() to closeAsync(). Fixes errors where some close operations were not subscribed to. * RequestResponseChannel. Remove close operation with message. * Adding DeliveryOutcome models and DeliveryState enum. * Add authorization scope to connection options. * Add MessageUtils to serialize and deserialize AmqpAnnotatedMessage * Update AmqpManagementNode to expose delivery outcomes because they can be associated with messages. * Adding MessageUtil support for converting DeliveryOutcome and Outcomes. * Fixing build breaks from ConnectionOptions. * Adding management channel class. * Adding management channel into ReactorConnection. * Update ExceptionUtil to return instead of throwing on unknown amqp error codes. * Moving ManagementChannel formatting. * Add javadocs to ReceivedDeliveryOutcome. * Add tests for ManagementChannel * Adding tests for message utils. * Fix javadoc on ModifiedDeliveryOutcome * ReactorConnection: Hook up dispose method. * EventHubs: Fixing instances of ConnectionOptions. * ServiceBus: Fix build errors using ConnectionOptions. * Adding MessageUtilsTests. * Updating CHANGELOG. * Annotate HttpRange with Immutable (#22119) * Cosmos Spark: Changing inferSchema.forceNullableProperties default to true (#22049) * Changing default * Docs * Tests * new test * doc update * Change log * Make getScopes in the ARM Authentication Policy Public (#22120) Make getScopes in the ARM Authentication Policy Public * [Communication]: Update version, changelog, and dependency for June release (#22061) * Update version, changelog, and dependency for June release * Update Chat, SMS, and PhoneNumbers for release * Correction for chat version number * Typo in chat pom * Unrelease Chat; update change logs for other sdks * Nit fix Co-authored-by: JP Chen <[email protected]> * Increment version for videoanalyzer releases (#21814) * Increment package version after release of com.azure azure-media-videoanalyzer-edge * Update version_client.txt Co-authored-by: giakas <[email protected]> * Add module-info to jca and jca test module and change package name of jca test module (#22041) * Fix error in aad-starter-sample (#22109) * EventGrid Add 4.4.0 new system events. (#22126) * Updates to monitor query based on API review feedback (#22114) * API consistency review feedback * Remove commented code * fix tests * Refactor building prefer header * Fix Management Bug (#22122) * Adding missing return statement. * Using common logic for status codes. * Adding isSuccessful. * mgmt, upgrade aks (#22136) * Add domain_hint in aad-stater. (#22134) * Increment version for core releases (#22124) Increment package version after release of Core libraries * Update datafeed tests to remove error code asserts (#22121) * Made Tables service interfaces public (#22130) * Made service interfaces public for Key Vault and Tables impl clients. * Removed kvErrorStrings.properties files from Key Vault SDKs. Made KeyVaultErrorCodeStrings store the constants that were in the files. * Added check for null credentials in Key Vault Administration Builders. * Reverted changes made to KV libraries. * Adding lmolkova as owner for core, opentelemetry, and azure monitor exporter (#22128) * Re-generate EventGrid 4.4.0 events without FarmsBeat events (#22148) * Client throughput control: Deferring store invocation (#22144) * Dummy * Deferring teh request when ClinetThrouhgputControl is enabled * Client throughput control: defer store invocation * Adding additional test-coverage in throughput tests * Reacting to code review feedback. * Adding back createItem_withBulk test * Sync eng/common directory with azure-sdk-tools for PR 1633 (#22145) * Update format of new Changelog Entry * Add parsing of changelog sections * Update ChangeLog Logic Co-authored-by: Chidozie Ononiwu <[email protected]> * [Communication]: Update readme to release version (#22149) * Update readme to release version * Ignore transitive API errors from core Co-authored-by: JP Chen <[email protected]> * Update pom (#22155) Co-authored-by: JP Chen <[email protected]> * Update EventGrid Version to 4.4.0 (#22156) * Prepared storage for GA release of STG77 (#22152) * Identity versions Update June 2021 (#22153) * updated keyvault jca changelog for local jre keystore certificates (#22133) * mgmt, support vm boot diagnostics on managed storage account (#22162) * Cosmos Spark: Not-nullable properties to include "id" (#22143) * Id not nullable * Unit tests * Adding _ts * Integration tests * Update the release dates (#22169) Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: giakas <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Rujun Chen <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Gauri Prasad <[email protected]> Co-authored-by: Vinay Gera <[email protected]> Co-authored-by: ankitarorabit <[email protected]> * fix(calling-server): update common version * Adding ACS Recording Download SDK (#22026) This change adds new 'DownloadStream', 'DownloadStreamWithResponse', 'DownloadTo' and 'DownloadToWithResponse' methods to allow users to download their requested content related to ACS Recording. * new schema minor fix (#22183) * refactor and minor fixes * minor fixes * Making ProgressReporter.reportProgress to release the lock everytime. (#22182) * Rebasing master into feature/communication-ServerCalling (#22185) * Exposes management node in azure-core-amqp (#22095) * Update AmqpConnection to have a getManagementNode. * Adding AmqpManagementNode. * Update AmqpConnection, AmqpManagementNode, AmqpSession to use AsyncCloseable. * Adding AsyncCloseable to AmqpLink. * ClaimsBasedSecurityNode.java uses AsyncCloseable. * Implements CbsNode's closeAsync() and adds tests. * ReactorSession implements closeAsync() * ReactorConnection uses closeAsync(). Renames dispose() to closeAsync(). Fixes errors where some close operations were not subscribed to. * RequestResponseChannel. Remove close operation with message. * Adding DeliveryOutcome models and DeliveryState enum. * Add authorization scope to connection options. * Add MessageUtils to serialize and deserialize AmqpAnnotatedMessage * Update AmqpManagementNode to expose delivery outcomes because they can be associated with messages. * Adding MessageUtil support for converting DeliveryOutcome and Outcomes. * Fixing build breaks from ConnectionOptions. * Adding management channel class. * Adding management channel into ReactorConnection. * Update ExceptionUtil to return instead of throwing on unknown amqp error codes. * Moving ManagementChannel formatting. * Add javadocs to ReceivedDeliveryOutcome. * Add tests for ManagementChannel * Adding tests for message utils. * Fix javadoc on ModifiedDeliveryOutcome * ReactorConnection: Hook up dispose method. * EventHubs: Fixing instances of ConnectionOptions. * ServiceBus: Fix build errors using ConnectionOptions. * Adding MessageUtilsTests. * Updating CHANGELOG. * Annotate HttpRange with Immutable (#22119) * Cosmos Spark: Changing inferSchema.forceNullableProperties default to true (#22049) * Changing default * Docs * Tests * new test * doc update * Change log * Make getScopes in the ARM Authentication Policy Public (#22120) Make getScopes in the ARM Authentication Policy Public * [Communication]: Update version, changelog, and dependency for June release (#22061) * Update version, changelog, and dependency for June release * Update Chat, SMS, and PhoneNumbers for release * Correction for chat version number * Typo in chat pom * Unrelease Chat; update change logs for other sdks * Nit fix Co-authored-by: JP Chen <[email protected]> * Increment version for videoanalyzer releases (#21814) * Increment package version after release of com.azure azure-media-videoanalyzer-edge * Update version_client.txt Co-authored-by: giakas <[email protected]> * Add module-info to jca and jca test module and change package name of jca test module (#22041) * Fix error in aad-starter-sample (#22109) * EventGrid Add 4.4.0 new system events. (#22126) * Updates to monitor query based on API review feedback (#22114) * API consistency review feedback * Remove commented code * fix tests * Refactor building prefer header * Fix Management Bug (#22122) * Adding missing return statement. * Using common logic for status codes. * Adding isSuccessful. * mgmt, upgrade aks (#22136) * Add domain_hint in aad-stater. (#22134) * Increment version for core releases (#22124) Increment package version after release of Core libraries * Update datafeed tests to remove error code asserts (#22121) * Made Tables service interfaces public (#22130) * Made service interfaces public for Key Vault and Tables impl clients. * Removed kvErrorStrings.properties files from Key Vault SDKs. Made KeyVaultErrorCodeStrings store the constants that were in the files. * Added check for null credentials in Key Vault Administration Builders. * Reverted changes made to KV libraries. * Adding lmolkova as owner for core, opentelemetry, and azure monitor exporter (#22128) * Re-generate EventGrid 4.4.0 events without FarmsBeat events (#22148) * Client throughput control: Deferring store invocation (#22144) * Dummy * Deferring teh request when ClinetThrouhgputControl is enabled * Client throughput control: defer store invocation * Adding additional test-coverage in throughput tests * Reacting to code review feedback. * Adding back createItem_withBulk test * Sync eng/common directory with azure-sdk-tools for PR 1633 (#22145) * Update format of new Changelog Entry * Add parsing of changelog sections * Update ChangeLog Logic Co-authored-by: Chidozie Ononiwu <[email protected]> * [Communication]: Update readme to release version (#22149) * Update readme to release version * Ignore transitive API errors from core Co-authored-by: JP Chen <[email protected]> * Update pom (#22155) Co-authored-by: JP Chen <[email protected]> * Update EventGrid Version to 4.4.0 (#22156) * Prepared storage for GA release of STG77 (#22152) * Identity versions Update June 2021 (#22153) * updated keyvault jca changelog for local jre keystore certificates (#22133) * mgmt, support vm boot diagnostics on managed storage account (#22162) * Cosmos Spark: Not-nullable properties to include "id" (#22143) * Id not nullable * Unit tests * Adding _ts * Integration tests * Update the release dates (#22169) * Increment package version after release of com.azure azure-identity (#22168) * Added support for metadata in messages (#22158) * Added support for metadata in messages * Updated tests to reflect various PATCH scenarios. Reverted the autorest convention change * Re-added V2021_03_07 Co-authored-by: Andrei Giurgiu <[email protected]> * Fix Azure Core Amqp Sample issue #18806 by lihong 202105271344 (#21885) * Change Track 2 SB sendMessages() API for messages are being sent at a slow pace (#21014) * [BUG] Track 2 SB API (Batch Send Messages) doesn't seem to work. Messages are being sent at a slow pace. #16127 * Implement an Event Hubs Shared Access Key Credential (#21228) * Fix issue#16466 Implement an Event Hubs Shared Access Key Credential 202105061703 by LiHong * Prepare for metricsadvisor Beta release (#22175) * Prepare monitor query for release (#22166) * Increment version for communication releases (#22171) * Increment package version after release of com.azure azure-communication-identity * Increment package version after release of com.azure azure-communication-common * Increment package version after release of com.azure azure-communication-phonenumbers * Increment package version after release of com.azure azure-communication-sms * Increment package version after release of com.azure azure-ai-metricsadvisor (#22179) * Update azure-search-documents After Release (#22176) * Fix title in changelog (#22181) * Increment version for storage releases (#22172) * Increment package version after release of com.azure azure-storage-internal-avro * Increment package version after release of com.azure azure-storage-common * Increment package version after release of com.azure azure-storage-blob * Increment package version after release of com.azure azure-storage-queue * Increment package version after release of com.azure azure-storage-file-share * Increment package version after release of com.azure azure-storage-blob-batch * Increment package version after release of com.azure azure-storage-blob-nio * Increment package version after release of com.azure azure-storage-blob-cryptography * Increment package version after release of com.azure azure-storage-file-datalake * Increment package version after release of com.azure azure-storage-blob-changefeed * Adding IoT Hub connection string sample (#22157) * Adding IoTHubConnection string sample. * Tables list/get access policies changes (#22161) * Fixed serialization issues with listAccessPolicies() and setAccessPolicies in TableAsyncClient and TableClient. Added tests. * Added a test for service properties and statistics. * Fixed CheckStyle issues. * Applied PR feedback. * Fixed compilation error(?). * Made TableAccessPolicies final. * Fixed another CheckStyle issue. * Fixed another CheckStyle issue. Co-authored-by: Connie Yau <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Matias Quaranta <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: giakas <[email protected]> Co-authored-by: michaelqi793 <[email protected]> Co-authored-by: Rujun Chen <[email protected]> Co-authored-by: Yijun Xie <[email protected]> Co-authored-by: Srikanta <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: gaohan <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Fabian Meiswinkel <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Gauri Prasad <[email protected]> Co-authored-by: Vinay Gera <[email protected]> Co-authored-by: ankitarorabit <[email protected]> Co-authored-by: angiurgiu <[email protected]> Co-authored-by: Andrei Giurgiu <[email protected]> Co-authored-by: Hong Li(MSFT) <[email protected]> * fix(serverCalling): update some test recordings * Onboard Communication CallingServer Client SDK. * fix(callingServer): correct most style issues (#21915) * fix(callingServer): correct most style issues * fix(callingServer): correct most style issues * fix(*): revert generated files out of scope * Update FarmBeats SDK (#21836) * Update FarmBeats SDK * Release prep * Fix build. * fix(*): finish style check, add test base (#21941) * Update swagger location and obj models. * Zihzhan/communication server calling (#21943) * Update swagger location and obj models. * Fix sourceAlternateIdentity not pass issue. * Style check fix. * Update API version. * unit test for CallClientBuilder and other samll fixes (#21964) * fix(*): add unit tests * fix(*): add sync conversation client tests * Fix AddParticipant issues (#21967) * Playback unit test for CallClient and CallAsyncClient (#22014) * Added Unit tests for CallClient and CallAsyncClient * comment change * Add-remove participant unit tests (#22025) * fix(*): remove test url * fix(*): style issues * Using the latest swagger file (#22038) * Added join call, add-remove participant for out-call (#22040) * sync with dot net sdk (#22044) * Adding PlayAudio Api to Conversation Client (Out-Call) (#22021) * Added the PlayAudio Api for Out-call/ConversationClient * Added test for the playAudio apis * Fixed test caused due to merge coonflicts * Minor fixes Co-authored-by: Paresh Arvind Patil <[email protected]> * Refactor code (#22053) * Deserialize events (#22064) * Fix review suggestions (#22068) * fix(*): fix issue with tests failing in maven (#22067) * fix(*): fix issue with tests failing in maven * fix(*): remove pom changes * fix review feedbacks (#22071) * unit tests for out-call add/remove (#22074) * unit tests for delete call (#22075) * remove unused generated events (#22076) * fix(*): fix package version issues * fix(*): add callingserver to version.txt * fix(*): update readme.md (not complete) * fix(*): fix package version issues * fix(*): update readme.md * fix(*): update readme.md * fix(*): remove instances of 'var' and adding correct type. 'var' fails in CI. * fix(*): update readme.md * fix(*): update readme.md * fix(*): fix pom issue * fix event de-serialization issue by adding deafult constructors (#22090) * PR review fixes (#22099) * fix review feedbacks * fix reviews * Use JSON annotated event definition (#22101) * Use json annotated event definition * update newly generated classes * pr review fix (#22108) * PR review fixes * PR review fixes * Merge latest master (#22113) * Use different connection strings for Spring ServiceBus binders integration tests. (#21966) * update changelog (#21427) * update changelog for 3.5.0 entry * Upgrade Spring UTs/ITs to use JUnit 5. (#21670) * Fix Broken Link Explaining Spring Duration Conversions (#21942) * [Communication]: Remove unused code in pom and test files (#21654) * Remove unused code in pom and test files * Restore unintended change * Revert a test file change * Restore tests.yml * Remove unused env variable in tests.yml * Remove tests.yml * Keep skipping SMS tests in INT * Try to skip jacoco in INT * try different syntax * Try use string as much as we can * Try escape quotes * Try use a variable inside loop * Fix a typo * Move variable to a different place * Try Macro syntax * Remove variable, use stage name instead * Fix syntax * Try a different syntax * Try something simple * Move variables to the right place * Flip logic * Renamve variable * Give up on customizing jacoco.skip * Try to use variable to skp jacoco * Try different syntax * Move variable declaration * Try to set variable * Try PreSteps * Remove local variable * Remove unnecessary overwrite * Remove quotes Co-authored-by: JP Chen <[email protected]> * [Automation] Generate Fluent Lite from deviceprovisioningservices#package-2020-03 (#21938) Co-authored-by: timtay-microsoft <[email protected]> * Adds AsyncCloseable (#21991) * Adding AsyncCloseable with codesnippet. * Implementing AsyncCloseable and deleting AsyncAutoCloseable. * Add CHANGELOG entry. * Removing azure-core as an explicit dependency. * Fix use in AmqpReceiveLinkProcessor. * Sync eng/common directory with azure-sdk-tools for PR 1611 (#21853) * Add API status check * Increment package version after release of com.azure.resourcemanager azure-resourcemanager-deviceprovisioningservices (#21994) * Update Build Script to Perform Additional Tasks (#21993) * Arch board review feedback for ACR (#21913) * Update ACR changes * Update the swagger to the new values. * read me update * Add support for ACR beta 3 * Incorporate CR comments * Set AMQP connection idle timeout to 60 seconds. (#21995) * Angiurgiu/add missing chat thread async client options methods (#21939) * Removed the item return check on listReadReceipts for Live/Record tests. Removed .sleep statements * Added missing Options methods in ChatThreadAsyncClient * Updated incorrect test name used for logging Co-authored-by: Andrei Giurgiu <[email protected]> * add ut test for jre certificates (#21989) * Update the default authentication scope for the public cloud. (#22005) * Support getting rows as objects and map errors (#21997) * Update samples and map errors * Fix version tag * mgmt, support multiple source/destination ASG in NSG (#21980) * mgmt, support multiple source/destination ASG in NSG * checkstyle * changelog * Add integration test for keyvault certificate (#21573) * mgmt, fix sample as previous ARM template get deleted (#22011) * Add more test for jca integration test. (#21523) * azure-messaging-eventhubs-checkpointstore-blob Post Release Version Increment (#22010) * Update CODEOWNERs for Mixed Reality Authentication (#22004) This change adds me as a code owner of the Mixed Reality Authentication library. * Bump versions of core amqp and servicebus (#22020) * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22031) * Add autoscale RU support for azure-spring-data-cosmos (#21851) * Add autoscale RU support for azure-spring-data-cosmos Resolves #12711 * Added sample to read me for auto scale throughput * Fixed readme link Co-authored-by: Kushagra Thapar <[email protected]> * Adding a No Op version of the List RR with Options test, for code coverage (#22035) Co-authored-by: Andrei Giurgiu <[email protected]> * Prepare azure-sdk-bom for Release (#22001) Prepare azure-sdk-bom for Release * mgmt core, move ArmChallengeAuthenticationPolicy from experimental (#21961) * mgmt core, move ArmChallengeAuthenticationPolicy from experimental * reuse ArmChallengeAuthenticationPolicy in azure-resourcemanager-resources * Check if a queue exists but the name is used for a topic and vice versa (#19513) * add check existing queue * return an empty simple response * Make Library/Libraries Used in Bug Report More Explicit (#22047) Make Library/Libraries Used in Bug and Query Issue Templates More Explicit * Updaing AAP jar version for signed jar and moving it it azure devops feed from blob storage (#22046) * Add the ability to check for open pull request to a different repo. (#22059) Co-authored-by: Chidozie Ononiwu <[email protected]> * Use sparse-checkout When Performing a POM Only Release (#22037) Use sparse-checkout When Performing a POM Only Release * Dispose link immediately if updateDisposition timeout. (#22036) * Set azure-sdk-bom to In-Dev (#22052) Set azure-sdk-bom to In-Dev * Update azure-sdk-build-tools Repository Resource Refs in Yaml files (#22062) * mgmt, aks support spot vm (#22016) * support spot vm in aks * changlog * rename method * Expose CbsAuthorizationType (#22072) * Adding CbsAuthorizationType model. * Deleting implementation CbsAuthorizationType. * Update AzureTokenManagerProvider to use ExpandableEnum CbsAuthorizationType. * Fix CbsAuthorizationType imports. * Fixing Event Hubs breaks. * Fix Service Bus breaks. * Addressed API Feedback for Storage STG77 (#22023) * Metrics Advisor SDK APIs aligning with most recent swagger updates (#21936) * Adding more doc to FeedType types and correcting typo in addFeedback API name * Using the name Sql, MongoDb, InfluxDb * Initial impl of credential entities and its integration with data feed * Apply Fluent, Immutable as appropriate * Updating listMetricEnrichedSeriesData signature to take detectionId as first argument * Renaming listAnomaliesForAlert and listAnomaliesForDetectionConfig to listAnomalies * Adding ClientOptions * Renaming listIncidentsForAlert and listIncidentsForDetectionConfig to listIncidents * Adding DimensionKey::get(..) and renaming TOPN enum-value to TOP_N * Add options overload API's * revert DataFeedIngestionOption changes * Updating BoundaryDirection, DataFeedRollupType, DataFeedSourceType and SingleBoundaryDirection to ExpandableStringEnum * Adding doc for DataFeedSource abstract type, renaming AzureCosmosDataFeedSource to AzureCosmosDbDataFeedSource, deleting unused ElasticsearchDataFeedSource and HttpRequestDataFeedSource * Removing setSubscriptionKey() and setApiKey(), instead adding an update method to atomically update the keys * MA Credentials: Removing Entity suffix and adding DataSource prefix * Rename ErrorCode to MetricsAdvisorErrorCode * update listDataFeedIngestionStatus * Addressing feedback for the last commit (Fixingspotbug and checkstyle) * consider datasource prefix for credential as one word (archfeedback) * Renaming DataSourceCredentialType to DatasourceCredentialType * Adding tests for Data Source Credentials. Rename userfacing type DataSourceAuthenticationType to DatasourceAuthenticationType (Datasource as one word) * Adding junit tests for data source cred async apis * Adding sync tests for Data Source Credentials and recordings * Adding samples and code snippets for Credential Entity API * Adding test skeleton for associating cred to datafeed * Use single word datasource for DataSourceDataLakeGen2SharedKey * Removing unsupported value 'Secondly' from Granularity * Hiding clientSecret getter from AzureLogAnalyticsDataFeedSource * Finishing Cred association with DataFeedSources * Completing tests for Cred association with DataFeedSources * Adding test recordings for Cred to DataFeedSource association * Adding cred association to AzureLogAnalytics DataFeed * Add valid cred for log analytics * rename to updateKey * rename env vars * Moving admin models to admininstration.models package * Removing equality assert on LogAna ids * Update Changelog (#7) * Fix pipeline error - export admin models (#8) * Moving MetricsAdvisorServiceVersion to root package * Override setDimensionFilter in Feedback types to ensure fluent chain * Adding addFeedbackWithResponse in sync client * Use the param name credentialId consistently, removing unsupported connectionstring cred from data-explorer * Rename DATA_LAKE_GEN2SHARED_KEY enum-val to DATA_LAKE_GEN2_SHARED_KEY, use DataFeedRollupSettings::rollupIdentificationValue param name consiistently * Use from prefix (instead of using prefix) for all factory methods to create data-source with credentials * Introduced MetricsAdvisorKeys that composes subscription and api key * Renaming error types to MetricsAdvisorError and MetricsAdvisorResponseException * update module info and add final Co-authored-by: samvaity <[email protected]> Co-authored-by: Sameeksha Vaity <[email protected]> * Update AMQP Error Context and adding more AMQP error codes (#22060) * Adding documentation to potential Amqp errors. * Making valueMap for AmqpResponseCode final. * Update AmqpErrorContext to contain ErrorInfo. * Add revapi.json suppression. The serialization itself is compatible based on "Compatible changes" in https://docs.oracle.com/javase/6/docs/platform/serialization/spec/version.html#6678 * Adding test case. * Adding more error conditions. * Fixed mapping cosmos converter to handle value nodes (#22073) * Added value query suport to spring data cosmos query annotation * Fixed mapping cosmos converter regression * Test Wagon Changes to Determine Install Performance (#22082) Wagon Changes to Improve Install Performance * [Storage] Use FluxUtil for reliable download. (#22080) * first draft. * indent. * npes. * timeout. * fix empty case. * checkstyle * tests * Rename confidential ledger package (#22056) * Rename confidential ledger package * Use 1.0.0-beta.2 as dependency version * Added support for generating SAS tokens at the account and Table service level. (#21944) * Added support for generating SAS tokens at the Account and Table Service in all clients. Updated CHANGELOG. * Added partition key and row key values for SAS generation. * Fixed CheckStyle issues. * Fixed SpotBugs issue. * Removed more unused imports. * Renamed classes used for generating table-level SAS tokens. Made clients throw an exception when trying to generate SAS tokens if not authenticated with an AzureNamedKeyCredential. * Made client builders throw an IllegalStateException if more than one authentication setting is applied. * Changed module-info.java to export the tables package to all other packages. * Added tests for SAS models. * Added builder tests for when multiple forms of authentication are set. * Updated builders to throw when no endpoint or form of authentication are provided. * Fixed CheckStyle issues. * Fixed test name. * Removed unnecessary exports for implementation packages in module-info.java * Applied PR feedback: - Added extra clarity to when SAS models' toString() methods can return an empty String. - Removed unnecessary empty constructors in TableSasIpRange and TableSasPermission. - Changed builder parameter validation logic to the `buildClient()` and `buildAsyncClient()` methods. - Builders now also throw an IllegalStateException when calling `buildClient()` and `buildAsyncClient()` if multiple forms of authentication are provided, with the exception of 'sasToken' + 'connectionString'; or if 'endpoint' and/or 'sasToken' are set alongside a 'connectionString' and the endpoint and/or SAS token in the latter are different, respectively. - Removed "en-us" from all links in JavaDoc. - Updated CHANGELOG. * Added tests and renamed test classes to match clients and builders. * Updated CHANGELOG and client builders' JavaDoc. * Applied APIView feedback. * Updated CHANGELOG again. * Removed unused imports. Simplified SAS token comparison logic. * Fixed SAS token generation at the table level. Re-ordered query parameters in SAS tokens for both accounts and tables. Added tests for SAS tokens. * Updated CHANGELOG. * Fixed test and CheckStyle issues. * Added @Immutable and @Fluent annotations where appropriate. Made more models and classes in the sas package final. * Added more @Immutable annotations. * Fetch specific branch name only in git-branch-push script (#21998) Co-authored-by: Ben Broderick Phillips <[email protected]> * Use generate matrix job name parameter as display name (#22089) Co-authored-by: Ben Broderick Phillips <[email protected]> * Update proton-j and qpid-proton-j-extensions (#22081) * Use sparse checkout for Update Package Version release stage (#22002) * Fix subscription bugs in ReactorSession and ReactorConnection (#22085) * Fix error where Mono for dispose of was not being subscribed to. * Fix error where close operations were not being subscribed to. * Fixing distinct to distinctUntilChanged * Update CHANGELOG with authorization type. * mgmt, support parameters in policy (#22103) * mgmt, support parameters in policy * changelog * use immutable collection * Fixing max length of userAgent header (#22018) * Fixing max length of userAgent header * Addressed CR feedback * Restricting the total UserAgent length to 255 characters * Fixing unit test regression Co-authored-by: Xiaobing Zhu <[email protected]> Co-authored-by: zhihaoguo <[email protected]> Co-authored-by: Alan Zimmer <[email protected]> Co-authored-by: Jianping Chen <[email protected]> Co-authored-by: JP Chen <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: timtay-microsoft <[email protected]>…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't have connection idle timeout. In some cases, most likely in Linux environments, the SDK won't actively close the connection or get a connection error and retry when a connection to the service is dead for a few minutes or even longer.
There are 2 options to set this value:
We can firstly do option 1 with hardcode for 1 minute (like JS and C#) for now as a quick fix and expose it if we need to in the future.
closes #21823