-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Annotation to Parameterize Tests with more Complex Scenarios #20484
Add Custom Annotation to Parameterize Tests with more Complex Scenarios #20484
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
...st/src/main/java/com/azure/core/test/annotation/HttpClientServiceVersionAugmentedSource.java
Outdated
Show resolved
Hide resolved
...st/src/main/java/com/azure/core/test/annotation/HttpClientServiceVersionAugmentedSource.java
Outdated
Show resolved
Hide resolved
...st/src/main/java/com/azure/core/test/annotation/HttpClientServiceVersionAugmentedSource.java
Outdated
Show resolved
Hide resolved
...st/src/main/java/com/azure/core/test/annotation/HttpClientServiceVersionAugmentedSource.java
Outdated
Show resolved
Hide resolved
… level annotation
sdk/core/azure-core-test/src/main/java/com/azure/core/test/annotation/AzureMethodSource.java
Show resolved
Hide resolved
...ore/azure-core-test/src/main/java/com/azure/core/test/annotation/TestingServiceVersions.java
Outdated
Show resolved
Hide resolved
…or live service versions
sdk/core/azure-core-test/src/main/java/com/azure/core/test/annotation/PlaybackOnly.java
Outdated
Show resolved
Hide resolved
...ore/azure-core-test/src/main/java/com/azure/core/test/annotation/TestingServiceVersions.java
Outdated
Show resolved
Hide resolved
...ore/azure-core-test/src/main/java/com/azure/core/test/annotation/TestingServiceVersions.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/src/main/java/com/azure/core/test/annotation/AzureMethodSource.java
Show resolved
Hide resolved
...ore/azure-core-test/src/main/java/com/azure/core/test/annotation/TestingServiceVersions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #21171
This PR adds the
AzureTestMethod
andTestingServiceVersions
annotations which allows for configuring a test class and test method to be parameterized by the following:HttpClient
.ServiceVersion
.TestingServiceVersions
is a class level annotation which configures allServiceVersion
s that tests methods annotated byAzureTestMethod
could be ran against.AzureTestMethod
also provides the ability to set a minimumServiceVersion
to run against, used in cases for when new feature functionality is added.TestingServiceVersions
only applies when running inTestMode.LIVE
asTestMode.PLAYBACK
andTestMode.RECORD
only support a singleServiceVersion
.The following are example:
This is the
ServiceVersion
class:Test that supports all ServiceVersions
This will run two tests using service versions
V1
andV2
.Test that only supports certain SeviceVersions
This will only run against service version
V2
.