Modify the dependency httpclient5 to httpclient4. #20191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han-gao
requested review from
backwind1233,
chenrujun,
jialindai,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
|
Hi, @han-gao , please:
|
han-gao
requested review from
alzimmermsft,
danieljurek,
g2vinay,
JimSuplizio,
mitchdenny and
samvaity
as code owners
|
Hi, @han-gao , please resolve the conflicts and fix the pipeline failure. |
added 5 commits
March 30, 2021 10:44
…to modify_jca_dependencies # Conflicts: # sdk/keyvault/azure-security-keyvault-jca/pom.xml
…to modify_jca_dependencies
yiliuTo
reviewed
Apr 1, 2021
| } catch (IOException ioe) { | ||
| ioe.printStackTrace(); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| private ResponseHandler<String> responseHandler() { |
There was a problem hiding this comment.
Shall we change the function name to "createResponseHandler"
There was a problem hiding this comment.
ok, it's easier to understand.
added 3 commits
April 1, 2021 13:46
added 2 commits
April 2, 2021 16:48
…lient-side and azure-spring-boot-sample-keyvault-certificates-server-side.
|
/check-enforcer override |
benbp
pushed a commit
that referenced
this pull request
Apr 28, 2021
* Modify the dependency httpclient5 to httpclient4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to resolve this comment, remove httpclient5 dependency from jca.