Adding a parameter to catalogs, Pipeline and Recurrence information, and object refactoring #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and object refactoring * Catalogs.java: added a parameter, called basic, to indicate that you want basic information rather than nested information about a table (i.e., list tables method) for performance increase * Adding Pipeline and Recurrence information to jobs * Added methods to get such information * Refactoring and comment changes
* Refactoring and comment changes
* Code gen based on this PR: Azure/azure-rest-api-specs#1429 * Modifying the gulpfile to align with the directory revamp of the Swagger repo * Modifying the test files to work with the object-refactoring changes in the PR * Adding a few more tests to align with the well-covered tests for .NET SDK * Removing "import com.microsoft.azure.SubResource"
* For JobOperationsTests, I found a server side bug while testing this call in the .NET SDK, so I was not surprised to see that it fails here as well. * For CatalogOperationsTests, I commented out "BUCKETS" from the script because apparently that keyword is deprecated. Furthermore, I commented out the "canCreateUpdateDeleteSecretsAndCredentials" test because the scripts that are being used are deprecated. According to the error message, I must use Azure Powershell cmdlets for such opeartions. I am not surprised at this because, to my knowledge, it's been a while since this test case was run. I will look into how I can test this in the near future. * Other than that, I made sure that JobOperationsTests as well as AccountOperationsTests (for both ADLA and ADLS) passed.
|
@ro-joowan, |
|
Can one of the admins verify this patch? |
* Removing the unused import java.io.IOException across files to pass Maven style check
* This is so that Travis passes!
* Three variables in DataLakeAnalyticsMangementTestBase.java weren't recorded
|
@jianghaolu Travis finally passes!!! |
* Apparently the cache is restored every 5 minutes
jianghaolu
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PART 1: stuff I worked on with Ben Goldsmith] - commits from late July
Catalogs.java: added a parameter, called basic, to indicate that you want basic information rather than nested information about a table (i.e., list tables method) for performance increase
Adding Pipeline and Recurrence information to jobs
Added methods to get such information
Object refactoring and comment changes
[PART 2: code gen based on this PR: https://github.com/Azure/azure-rest-api-specs/pull/1429] - commits from Aug 27th
Code gen based on this PR: BREAKING CHANGE: Adl object refactor azure-rest-api-specs#1429
Modifying the gulpfile to align with the directory revamp of the Swagger repo
Modifying the test files to work with the object-refactoring changes in the PR
Adding a few more tests to align with the well-covered tests for .NET SDK
Removing "import com.microsoft.azure.SubResource"