-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http Class Name Cleanup #18911
Http Class Name Cleanup #18911
Conversation
@JonathanGiles, @srnagar could you review the name changes as this should be merged before shipping azure-core again. |
...ure-core-http-okhttp/src/main/java/com/azure/core/http/okhttp/OkHttpAsyncClientProvider.java
Show resolved
Hide resolved
...re-core-http-netty/src/main/java/com/azure/core/http/netty/NettyAsyncHttpClientProvider.java
Show resolved
Hide resolved
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/azp run java - core - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/** | ||
* Helper class containing utility methods. | ||
*/ | ||
public final class Utility { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of how many Utility classes we have - can this be made into, e.g. NettyUtility or similar
/check-enforcer override |
The CI checks from the manually triggered run passed https://dev.azure.com/azure-sdk/public/_build/results?buildId=715867&view=results |
Add Network Preview Version 2022-04-01-preview (Azure#18911) * Base New Version * Update version * fix scope connection * fix scope connection * fix bug * fix bug * remove operationstatus API * fix as comments
This PR standardizes the naming conventions used by our HttpClient implementations, most importantly it standardizes the SPI implementation name which has recently been moved into the public API.