Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Class Name Cleanup #18911

Merged
merged 8 commits into from
Feb 3, 2021

Conversation

alzimmermsft
Copy link
Member

This PR standardizes the naming conventions used by our HttpClient implementations, most importantly it standardizes the SPI implementation name which has recently been moved into the public API.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. HttpClient labels Feb 1, 2021
@alzimmermsft alzimmermsft self-assigned this Feb 1, 2021
@ghost ghost added the Azure.Core azure-core label Feb 1, 2021
@alzimmermsft
Copy link
Member Author

@JonathanGiles, @srnagar could you review the name changes as this should be merged before shipping azure-core again.

@check-enforcer
Copy link

check-enforcer bot commented Feb 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@alzimmermsft alzimmermsft requested a review from srnagar February 2, 2021 19:54
@alzimmermsft
Copy link
Member Author

/azp run java - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

/**
* Helper class containing utility methods.
*/
public final class Utility {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of how many Utility classes we have - can this be made into, e.g. NettyUtility or similar

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft
Copy link
Member Author

The CI checks from the manually triggered run passed

https://dev.azure.com/azure-sdk/public/_build/results?buildId=715867&view=results

@alzimmermsft alzimmermsft merged commit 8f97528 into Azure:master Feb 3, 2021
@alzimmermsft alzimmermsft deleted the AzHttp_NamingAndTestCleanup branch February 3, 2021 00:56
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 23, 2022
Add Network Preview Version 2022-04-01-preview (Azure#18911)

* Base New Version

* Update version

* fix scope connection

* fix scope connection

* fix bug

* fix bug

* remove operationstatus API

* fix as comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants