Migrated file shares to new generator #18818

gapra-msft · 2021-01-26T20:19:57Z

No description provided.

check-enforcer · 2021-01-26T21:51:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

gapra-msft · 2021-01-27T03:53:26Z

/azp run java - storage - tests

azure-pipelines · 2021-01-27T03:53:37Z

Azure Pipelines successfully started running 1 pipeline(s).

gapra-msft · 2021-01-29T20:26:07Z

/azp run java - storage - tests

azure-pipelines · 2021-01-29T20:26:18Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/storage/azure-storage-file-share/swagger/README.md

...gger/src/main/java/com/azure/storage/file/share/customization/ShareStorageCustomization.java

...file-share/src/main/java/com/azure/storage/file/share/specialized/ShareLeaseAsyncClient.java

gapra-msft · 2021-02-03T00:04:01Z

/azp run java - storage - tests

azure-pipelines · 2021-02-03T00:04:29Z

Azure Pipelines failed to run 1 pipeline(s).

gapra-msft · 2021-02-03T16:46:20Z

/azp run java - storage - tests

azure-pipelines · 2021-02-03T16:46:37Z

Azure Pipelines successfully started running 1 pipeline(s).

...-share/src/main/java/com/azure/storage/file/share/implementation/models/CopyFileSmbInfo.java

...zure/storage/file/share/implementation/models/CustomFileAndDirectoryListingDeserializer.java

gapra-msft · 2021-02-03T22:55:34Z

/azp run java - storage - tests

azure-pipelines · 2021-02-03T22:55:45Z

Azure Pipelines successfully started running 1 pipeline(s).

rickle-msft · 2021-02-11T22:52:58Z

...c/main/java/com/azure/storage/file/share/implementation/models/DirectoriesCreateHeaders.java

+import java.time.OffsetDateTime;
+
+/** The DirectoriesCreateHeaders model. */
+@JacksonXmlRootElement(localName = "null")


This seems a little weird. I'm guessing its because this is actually deserializing headers and not xml?

rickle-msft · 2021-02-11T23:09:49Z

sdk/storage/azure-storage-file-share/swagger/README.md

@@ -644,21 +648,6 @@ directive:
    $["x-ms-parameter-location"] = "method";
 ```

-### Add the CustomFileAndDirectoryListingDeserializer attribute


Why did we delete this? It looks like the custom deserializer is still there

Deleted this and added it to the ShareStorageCustomization clas. This way no longer works with the new generator

rickle-msft · 2021-02-11T23:10:33Z

...gger/src/main/java/com/azure/storage/file/share/customization/ShareStorageCustomization.java

+/**
+ * Customization class for File Share Storage.
+ */
+public class ShareStorageCustomization extends Customization {


Is this something to do with the transforms?

Yeah this is the new way to modify generated code

Review request for Microsoft.ContainerService to add version 2022-04-01 (Azure#18991) * Adds base for updating Microsoft.ContainerService from version stable/2022-03-01 to version 2022-04-01 * Updates readme * Updates API version in new specs and examples * update readme (Azure#18715) * add storage profile into managedcluster (Azure#18818) Signed-off-by: Ji An Liu <[email protected]> * GA mc alias minor version in 0401 (Azure#18821) * GA mc alias minor version in 0401 * unify info to be consistent with ap alias minor version * update the title of kuberneteVersion * add title for currentKubernetesVersion * make currentKubernetesVersion language consistency with AP currentOrchestratorVersion * GA agent pool alisa minor version (Azure#18814) * GA agent pool alisa minor version * Unify description with MC * Add read-only field * Rematch description with MC Co-authored-by: Xia ZHU <[email protected]> Co-authored-by: Ji'an Liu <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Thalia Wang <[email protected]>

Migrated file shares to new generator

a8fbef6

ghost added the Storage Storage Service (Queues, Blobs, Files) label Jan 26, 2021

gapra-msft added 4 commits January 26, 2021 12:44

Version policy move

065843f

Added some test recordings

10688fb

Added fake java doc for version policy

840da4c

Fixed share lease recordings

2f62f78

gapra-msft added 8 commits January 26, 2021 15:16

Encoded the time correctly

f96fff2

Fixed a few more tests

40d29a3

Added list shares with args tests

bc89d28

Fixed a few more records

bb58ad6

All playback tests should work now

b958fc8

Forgot 2 tests

6e962ff

Fix analyze

ad1ca13

Fixed Java 11 issue

506de12

gapra-msft added 3 commits January 28, 2021 15:32

Added ability to set version

e0aaec1

Merge branch 'master' into storage/migrateFilesToNewGenerator

bd2310f

Actually add stuff

2920aaa

gapra-msft commented Jan 29, 2021

View reviewed changes

sdk/storage/azure-storage-file-share/swagger/README.md Outdated Show resolved Hide resolved

gapra-msft commented Jan 29, 2021

View reviewed changes

...gger/src/main/java/com/azure/storage/file/share/customization/ShareStorageCustomization.java Outdated Show resolved Hide resolved

gapra-msft commented Jan 30, 2021

View reviewed changes

...file-share/src/main/java/com/azure/storage/file/share/specialized/ShareLeaseAsyncClient.java Outdated Show resolved Hide resolved

gapra-msft added 2 commits February 2, 2021 09:42

Merge branch 'master' into storage/migrateFilesToNewGenerator

333bc08

Added correct getUrl code to file share

4ad300e

gapra-msft commented Feb 3, 2021

View reviewed changes

...-share/src/main/java/com/azure/storage/file/share/implementation/models/CopyFileSmbInfo.java Outdated Show resolved Hide resolved

gapra-msft commented Feb 3, 2021

View reviewed changes

...zure/storage/file/share/implementation/models/CustomFileAndDirectoryListingDeserializer.java Show resolved Hide resolved

Updated the customization class

e2ffd45

gapra-msft marked this pull request as ready for review February 3, 2021 22:53

gapra-msft requested review from alzimmermsft, amishra-dev, jaschrep-msft, kasobol-msft and rickle-msft as code owners February 3, 2021 22:53

gapra-msft requested review from jianghaolu and srnagar February 3, 2021 22:53

rickle-msft reviewed Feb 11, 2021

View reviewed changes

rickle-msft approved these changes Feb 11, 2021

View reviewed changes

gapra-msft added 3 commits February 12, 2021 13:22

Updated interfaces to public

9d0273e

Fixed README

3840216

Fixed CopyFileSmbInfo

f283440

gapra-msft merged commit 362e9c0 into Azure:master Feb 17, 2021

gapra-msft deleted the storage/migrateFilesToNewGenerator branch February 17, 2021 22:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrated file shares to new generator #18818

Migrated file shares to new generator #18818

gapra-msft commented Jan 26, 2021 •

edited

Loading

check-enforcer bot commented Jan 26, 2021

gapra-msft commented Jan 27, 2021

azure-pipelines bot commented Jan 27, 2021

gapra-msft commented Jan 29, 2021

azure-pipelines bot commented Jan 29, 2021

gapra-msft commented Feb 3, 2021

azure-pipelines bot commented Feb 3, 2021

gapra-msft commented Feb 3, 2021

azure-pipelines bot commented Feb 3, 2021

gapra-msft commented Feb 3, 2021

azure-pipelines bot commented Feb 3, 2021

rickle-msft Feb 11, 2021

rickle-msft Feb 11, 2021

gapra-msft Feb 17, 2021

rickle-msft Feb 11, 2021

gapra-msft Feb 17, 2021

Migrated file shares to new generator #18818

Migrated file shares to new generator #18818

Conversation

gapra-msft commented Jan 26, 2021 • edited Loading

check-enforcer bot commented Jan 26, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

gapra-msft commented Jan 27, 2021

azure-pipelines bot commented Jan 27, 2021

gapra-msft commented Jan 29, 2021

azure-pipelines bot commented Jan 29, 2021

gapra-msft commented Feb 3, 2021

azure-pipelines bot commented Feb 3, 2021

gapra-msft commented Feb 3, 2021

azure-pipelines bot commented Feb 3, 2021

gapra-msft commented Feb 3, 2021

azure-pipelines bot commented Feb 3, 2021

rickle-msft Feb 11, 2021

Choose a reason for hiding this comment

rickle-msft Feb 11, 2021

Choose a reason for hiding this comment

gapra-msft Feb 17, 2021

Choose a reason for hiding this comment

rickle-msft Feb 11, 2021

Choose a reason for hiding this comment

gapra-msft Feb 17, 2021

Choose a reason for hiding this comment

gapra-msft commented Jan 26, 2021 •

edited

Loading