[TA] CodeGen based on 3.1-preview.3 #17177
Conversation
mssfang
added
Client
| @@ -7,7 +7,7 @@ | |||
| import com.azure.ai.textanalytics.implementation.models.DocumentError; | |||
| import com.azure.ai.textanalytics.implementation.models.EntitiesResult; | |||
| import com.azure.ai.textanalytics.implementation.models.MultiLanguageBatchInput; | |||
| import com.azure.ai.textanalytics.implementation.models.PiiEntitiesResult; | |||
There was a problem hiding this comment.
service renamed it to PiiResult
| * model. | ||
| */ | ||
| @Fluent | ||
| public class Components15Gvwi3SchemasTasksstatePropertiesTasksPropertiesEntityrecognitiontasksItemsAllof1 { |
There was a problem hiding this comment.
The name of this class is messed up?
There was a problem hiding this comment.
Yes. Autogenerated.
I think it can be removed. Want a confirm from @suhas92
There was a problem hiding this comment.
Those classes are duplicate classes. Somehow the autogene/swagger mess these up. I removed them already.
There was a problem hiding this comment.
Manually removed?
If yes, we should check with the autorest crew on this and not do manual updates to generated code.
There was a problem hiding this comment.
it is the swagger issue. I think it is safe to remove since they are useless.
| * model. | ||
| */ | ||
| @Fluent | ||
| public class Components15X8E9LSchemasTasksstatePropertiesTasksPropertiesEntityrecognitionpiitasksItemsAllof1 { |
There was a problem hiding this comment.
same here.
Are other langs seeing this too?
cc: @maririos @iscai-msft
There was a problem hiding this comment.
talked offline with @suhas92, .NET has the same issue. it is from the swagger. I remove these 3 classes right now, since these class are exactly same as TasksStateTasksEntityRecognitionTasksItem, etc.
There was a problem hiding this comment.
We can add these classes back once it is fixed. Currently, there is not usage of these classes.
There was a problem hiding this comment.
Make sure the swagger issue is tracked and resolved.
There was a problem hiding this comment.
Yes. Suhas has it on the issue tracker.
|
Create a feature branch to have all v3.1-preview.3 changes. |
This PR focus on generating code for Text Analytics swagger 3.1-preview.3
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json