End to End TLS SSL step #2 #16708
Merged
End to End TLS SSL step #2 #16708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnriem
requested review from
backwind1233,
chenrujun,
g2vinay,
jialindai,
samvaity,
saragluna,
vcolin7 and
yiliuTo
as code owners
ghost
added
chenrujun
reviewed
Oct 23, 2020
chenrujun
suggested changes
Oct 23, 2020
...security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultCertificate.java
Outdated
Show resolved
Hide resolved
vcolin7
reviewed
Oct 25, 2020
|
|
||
| # Troubleshooting | ||
| ## Testing the version under development |
There was a problem hiding this comment.
This section should be somewhere other than the bottom to have more visibility. What about as a part of "Getting Started"?
| @@ -263,7 +263,7 @@ To build and install the starter use the following command line: | |||
| ``` | |||
|
|
|||
|
|
|||
| # Azure KeyVault Certificates client library for Java | |||
| # Azure Key Vault Certificates client library for Java | |||
There was a problem hiding this comment.
We should not include these sections just so that the CI pipelines don't complain. I think that, for the sake of consistency, we should make it so that this README is in line with the one for the Secrets Spring Boot Starter. We can always include the information above in a section where it makes sense, even additional to the ones below if you think that's better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.