Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the azure-spring-cloud-starter-appconfiguration-config module from sdk/spring to sdk/appconfiguration #14894

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Move the azure-spring-cloud-starter-appconfiguration-config module from sdk/spring to sdk/appconfiguration #14894

merged 4 commits into from
Sep 8, 2020

Conversation

jacko9et
Copy link
Contributor

@jacko9et jacko9et commented Sep 8, 2020 

Move the azure-spring-cloud-starter-appconfiguration-config module from sdk/spring to sdk/appconfiguration

@ghost ghost added App Configuration Azure.ApplicationModel.Configuration azure-spring All azure-spring related issues labels Sep 8, 2020
@jacko9et jacko9et requested a review from mitchdenny as a code owner September 8, 2020 08:25
chenrujun
chenrujun suggested changes Sep 8, 2020
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use relative links.

https://github.com/Azure/azure-sdk/blob/master/docs/policies/README-TEMPLATE.md#link-guidelines

https://github.com/Azure/azure-sdk-for-java/pull/13989/files#diff-bbc5dba8ff02aedfeed94fd0f102c996

sdk/spring/azure-spring-boot-samples/azure-spring-cloud-appconfiguration-sample/README.md Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-cloud-appconfiguration-sample/README.md Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-cloud-feature-management-sample/README.md Show resolved Hide resolved
sdk/spring/azure-spring-boot-samples/azure-spring-cloud-feature-management-web-sample/README.md Show resolved Hide resolved
chenrujun
chenrujun approved these changes Sep 8, 2020
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this PR and merge it.
Please create another PR to fix the issue about link.

@chenrujun chenrujun merged commit 9f0ec7c into Azure:master Sep 8, 2020
@jacko9et
Copy link
Contributor Author

jacko9et commented Sep 8, 2020

Fix the issue ablut link：#14901

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jul 6, 2021
CodeGen from PR 14894 in Azure/azure-rest-api-specs
15d0170 
[Iothub] Adding new properties in IothubProperties [stable version: 2021-07-01] (Azure#14894)

* Adds base for updating Microsoft.Devices from version stable/2021-03-31 to version 2021-07-01

* Updates readme

* Updates API version in new specs and examples

* adding new properties in iothu properties

* Adding isVerified property in preview version

* validation fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@jialindai jialindai Awaiting requested review from jialindai

@mssfang mssfang Awaiting requested review from mssfang

@saragluna saragluna Awaiting requested review from saragluna

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhoufenqin zhoufenqin Awaiting requested review from zhoufenqin

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacko9et @chenrujun