modify eventhub reademe #14778
Merged
modify eventhub reademe #14778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiliuTo
requested review from
chenrujun,
jialindai,
saragluna and
zhoufenqin
as code owners
saragluna
requested changes
Sep 3, 2020
There was a problem hiding this comment.
Generally great, but if we follow the Link Guidelines:
- No locale info should be contained in the URL.
- We should not use relative URLs.
And I suggest that we put the URLs together at the bottom of README file which will make the content short and easy to edit.
sdk/spring/azure-spring-cloud-eventhubs-stream-binder/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory-b2c/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-cloud-eventhubs-stream-binder/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-cloud-eventhubs-stream-binder/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-cloud-starter-eventhubs-kafka/README.md
Outdated
Show resolved
Hide resolved
|
@saragluna If we seperate readme modification into multiple PRs, then will there be conflicts when we merge each of them? |
|
If each PR modifies a subset of README files then it should be fine. |
yiliuTo
force-pushed
the
modify-spring-cloud-eventhub-readme
branch
from
96276a2 to
e7fc76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify README files of spring cloud eventhub modules for the release