Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ]Keep Open Telemetry attributes prefixed with db.comsosdb.* for dependency/span events #34128

Open
2 tasks done
FabianMeiswinkel opened this issue Mar 20, 2023 · 5 comments · May be fixed by #42460
Open
2 tasks done

[FEATURE REQ]Keep Open Telemetry attributes prefixed with db.comsosdb.* for dependency/span events #34128

FabianMeiswinkel opened this issue Mar 20, 2023 · 5 comments · May be fixed by #42460
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation

Comments

@FabianMeiswinkel
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the applicationInsights-agent (3.4.10) is not adding attributes prefixed with db.cosmosdb.* to the dependency entity - see https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java. The .Net AI DependencyCollector is keeping them - which allows customers to see and query them. Is it possible to adjust the behavior in Java as well?

Describe the solution you'd like
Like in .Net - https://github.com/microsoft/ApplicationInsights-dotnet/blob/24e5b04e8f8a08de8efd1a973293e65914dd3df5/WEB/Src/DependencyCollector/DependencyCollector/Implementation/AzureSdk/AzureSdkDiagnosticsEventHandler.cs#L378 - keep the attributes prefixed with "db.cosmosdb.*" on the dependency entity in AI.

Describe alternatives you've considered
n/a

Additional context
n/a

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Description Added
  • Expected solution specified
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 20, 2023
@lmolkova lmolkova added Monitor Monitor, Monitor Ingestion, Monitor Query Client This issue points to a problem in the data-plane of the library. Monitor - Exporter and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 20, 2023
@lmolkova
Copy link
Member

lmolkova commented Mar 20, 2023 •
edited
Loading

@heyams @trask wdyt?

in .net we're adding all attributes (generic and db.cosmosdb) including db.name that are transformed into AI schema to the custom dimensions. This allows cosmos team to document telemetry in a vendor-agnostic way and support folks to know what specific things mean. Users can also query using db.name without having a need to parse AppInsights target, name and other properties.

Would it be possible to follow the same approach in Java?

@heyams
Copy link
Member

heyams commented Mar 23, 2023

@lmolkova yes, we can do the same in Java to ensure feature parity. I can add it in the next exporter release.

@trask
Copy link
Member

trask commented May 23, 2023

Discussed with @lmolkova, we are going to make the following proposal to all languages for the Azure Monitor OpenTelemetry exporters:

  • Maintain list of specific attributes to exclude, e.g.
    • db.statement (because mapped 1-1)
    • net.transport (because noisy)
  • All others attributes are mapped to custom dimensions

@srnagar srnagar added OpenTelemetry OpenTelemetry instrumentation and removed Monitor - Exporter labels Aug 24, 2023
@FabianMeiswinkel
Copy link
Member Author

@trask / @lmolkova - do you have any idea when you would be able to pick this up? Or would it make more sense for me or someone from the Cosmos DB SDK team to contribute to it?

@trask trask linked a pull request Oct 18, 2024 that will close this issue
Open
@trask
Copy link
Member

trask commented Oct 18, 2024

@FabianMeiswinkel sorry we lost track of this, I've just sent a PR to address it: #42460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep db.cosmosdb.* attributes trask/azure-sdk-for-java
5 participants
@trask @lmolkova @FabianMeiswinkel @srnagar @heyams