Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management and unification with Spring's bom and azure-sdk-bom #21283

Closed
8 tasks
conniey opened this issue May 10, 2021 · 4 comments
Closed
8 tasks
Assignees
Labels
azure-sdk-bom Azure Java SDK BOM (Bill of Materials) azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. dependency-issue Issue that is caused by dependency conflicts Epic feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@conniey
Copy link
Member

conniey commented May 10, 2021

Description

One of the problems we have is that there are dependency conflicts between the boms shipped from Spring and our azure-sdk bom. We need a way to resolve it.

Option 1

A layered approach where the boms use azure-sdk-bom.

  1. azure-spring-cloud-dependencies
  2. azure-spring-boot-bom

Option 2

We ship another azure-sdk-dependencies bom that azure-spring-cloud-dependencies and azure-spring-boot-bom use. Investigation work item #21306

Work items

General

Tooling

Notes

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 10, 2021
@conniey conniey added azure-spring All azure-spring related issues dependency-issue Issue that is caused by dependency conflicts labels May 11, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 11, 2021
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Epic labels May 11, 2021
@conniey conniey added the azure-sdk-bom Azure Java SDK BOM (Bill of Materials) label May 11, 2021
@conniey conniey self-assigned this May 11, 2021
@joshfree
Copy link
Member

joshfree commented Jul 6, 2021

Tagging @pallavit who is working on the azure-sdk-bom tooling and increasing the shipping cadence of the bom to monthly this semester

@stliu stliu added this to the Backlog milestone Aug 9, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
@saragluna
Copy link
Member

FYI, the latest version of Spring Cloud Azure BOM has been renamed to spring-cloud-azure-dependencies and it shipped with the azure-sdk-bom. Check the ref doc for more details https://microsoft.github.io/spring-cloud-azure/current/reference/html/index.html#bill-of-material-bom.

@stliu stliu added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 3, 2022
@stevenylai
Copy link

Hi, in our case, we want to use a specific version of Azure library and would like to find the most recent spring starter which works with it. The one we want is: azure-schemaregistry-kafka-avro:1.0.0-beta.7 which depends on azure-data-schemaregistry:1.1.1. We also want to use azure-sdk-bom since we have other services such as CosmosDB in our projects. The 'schemaregistry' version we need is from azure-sdk-bom:1.2.1. But from version table it's not clear if it's OK to upgrade our SpingBoot from 2.6.x to 2.7.x. We tried 2.7.4 but got the same 'NoSuchMethodError: reactor.core.publisher.MonoSink.contextView()' error as shown here.

It looks like the not found method was introduced in reactor-core:3.4.18 and we are better off staying with no later than spring-boot-starter-webflux:2.6.7

It would be nice if the version table could also provide this kind of information

@saragluna
Copy link
Member

@stevenylai you could find it from our changelog https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/CHANGELOG.md, and the Spring Cloud Azure version compatible with azure-sdk-bom version 1.2.1 is https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/CHANGELOG.md#410-2022-05-05.

@pallavit pallavit removed their assignment Nov 16, 2022
@stliu stliu removed their assignment Dec 5, 2022
@conniey conniey closed this as completed Mar 6, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Spring Cloud Azure Mar 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-sdk-bom Azure Java SDK BOM (Bill of Materials) azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. dependency-issue Issue that is caused by dependency conflicts Epic feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Archived in project
Development

No branches or pull requests

7 participants