Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DeclarationOrder check for azure-spring package related files #18291

Closed
samvaity opened this issue Dec 21, 2020 · 6 comments
Closed

Enable DeclarationOrder check for azure-spring package related files #18291

samvaity opened this issue Dec 21, 2020 · 6 comments
Assignees
@saragluna
Labels
azure-spring All azure-spring related issues Checkstyle Label for tracking tasks related to checkstyle rules Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
2022-05

Comments

@samvaity
Copy link
Member

samvaity commented Dec 21, 2020 •
edited
Loading

Recently we added the DeclarationOrderCheck in this PR. Enable this check and necessary updates for spring packages need to be made.

Enable

<suppress checks="EmptyCatchBlock" files="com.azure.spring.security.keyvault.certificates.starter.KeyVaultCertificatesEnvironmentPostProcessor.java"/>
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 21, 2020
@samvaity samvaity changed the title Fix DeclarationOrder check errored spring files Enable DeclarationOrder check for azure-spring package related files Dec 21, 2020
@saragluna
Copy link
Member

Hi @samvaity, I'm seeing this issue from PR #18025, is this issue going to be assigned to the spring team?

@alzimmermsft alzimmermsft added azure-spring All azure-spring related issues Checkstyle Label for tracking tasks related to checkstyle rules labels Dec 28, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 28, 2020
@samvaity
Copy link
Member Author

Hi @samvaity, I'm seeing this issue from PR #18025, is this issue going to be assigned to the spring team?

Yes @saragluna, we should assign this to the spring team.

@saragluna
Copy link
Member

Thanks, @samvaity. Added the assignees.

@saragluna saragluna added the Client This issue points to a problem in the data-plane of the library. label Mar 5, 2021
@yiliuTo yiliuTo added this to the Backlog milestone Mar 19, 2021
@chenrujun chenrujun removed their assignment Jun 1, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Nov 5, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this issue Mar 22, 2022
@zjpjack @matthchr
CodeGen from PR 18324 in Azure/azure-rest-api-specs
6344b2f 
Review request for Microsoft.ContainerService to add version 2022-02-01 (Azure#18324)

* Adds base for updating Microsoft.ContainerService from version stable/2022-01-01 to version 2022-02-01

* Updates readme

* Updates API version in new specs and examples

* Update readmes for the 2022-02-01 dev branch of container service (Azure#17887)

* update readme

* remove useless -only tags

* Fix violated rule R2026 for 2022-02-01 managedCluster swagger (Azure#18024)

* fix allof

* add missing type

* GA alias minor version (Azure#18038)

* GA alias minor version

* polish more details on kubernetesVersion and currentKubernetesVersion

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2022-02-01/managedClusters.json

minor revision

Co-authored-by: Matthew Christopher <[email protected]>

Co-authored-by: Matthew Christopher <[email protected]>

* add missing type object (Azure#18115)

* Revert "GA alias minor version (Azure#18038)" (Azure#18291)

This reverts commit 3a99cda3cb48e05c74923f5467c0737014322b0f.

* Align modifications of several common definitions with 2022-02-02-preview for container service 2022-02-01 (Azure#18216)

* sync modification

* fix ref

Co-authored-by: Jianping Zeng <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
@stliu stliu modified the milestones: Backlog, [2022] May Apr 2, 2022
@stliu
Copy link
Member

stliu commented Apr 2, 2022

@saragluna not sure if this is still valid, if it does, let's get this done in May, thanks

@stliu stliu added azure-spring-copper feature-request This issue requires a new behavior in the product in order be resolved. labels Apr 2, 2022
@saragluna
Copy link
Member

@samvaity is this feature request still valid?

@samvaity
Copy link
Member Author

This request is not valid anymore.

Repository owner moved this from Todo to Done in Spring Cloud Azure Apr 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues Checkstyle Label for tracking tasks related to checkstyle rules Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
2022-05
Development

No branches or pull requests
7 participants
@stliu @backwind1233 @chenrujun @samvaity @saragluna @alzimmermsft @yiliuTo