Skip to content

Commit

Permalink
[CODEOWNERS] Fix duplicate entries for messaging (#39155)
Browse files Browse the repository at this point in the history
The focus of these changes is to fix service label duplication that would cause inappropriate matches for the messaging services.

### Important context:

- The `Service Attention` label is ignored during match logic.

- Service label matches follow the same rules as paths for pull requests.  This means that ordering of rules is important; scanning starts at the bottom of the file and progresses towards the top.   Once the first match is found, it is used and scanning stops.

This means that the `/<NotInRepo>/` section at the bottom of this file will be the first matches found for most service tags, causing automated triage to consider these tags to be service-owned and assigned.
  • Loading branch information
jsquire authored and drielenr committed Mar 28, 2024
1 parent 7da1f23 commit 6fb90c4
Showing 1 changed file with 10 additions and 14 deletions.
24 changes: 10 additions & 14 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,16 @@
/sdk/modelsrepository/ @drwill-ms @timtay-microsoft @abhipsaMisra @digimaun @andyk-ms @brycewang-microsoft @tmahmood-microsoft @ngastelum-ms

# AzureSdkOwners: @billwert
# ServiceOwners: @jfggdl
# ServiceLabel: %Event Grid

# PRLabel: %Event Grid
/sdk/eventgrid/ @billwert @mssfang @srnagar @lmolkova

# AzureSdkOwners: @conniey @anuchandy @lmolkova
# ServiceOwners: @serkantkaraca @sjkwak
# ServiceLabel: %Event Hubs

# PRLabel: %Event Hubs
/sdk/eventhubs/ @conniey @anuchandy @lmolkova

Expand Down Expand Up @@ -196,9 +200,11 @@
/sdk/remoterendering/ @MichaelZp0 @ChristopherManthei

# AzureSdkOwners: @conniey
# ServiceOwners: @hmlam
# ServiceLabel: %Schema Registry

# PRLabel: %Schema Registry
/sdk/schemaregistry/ @conniey @sjkwak @srnagar
/sdk/schemaregistry/ @conniey @srnagar

# AzureSdkOwners: @alzimmermsft @jairmyree
# ServiceLabel: %Search
Expand All @@ -211,11 +217,13 @@
/sdk/serialization/ @alzimmermsft @srnagar

# AzureSdkOwners: @anuchandy
# ServiceOwners: @EldertGrootenboer
# ServiceLabel: %Service Bus

# PRLabel: %Service Bus
/sdk/servicebus/ @anuchandy @conniey @lmolkova

# ServiceLabel: %Service Bus %Service Attention %Track 1
# ServiceLabel: %Service Bus %Track 1
# PRLabel: %Service Bus
/sdk/servicebus/microsoft-azure-servicebus/ @shankarsama @yvgopal

Expand Down Expand Up @@ -533,12 +541,6 @@
# ServiceLabel: %Digital Twins %Service Attention
#/<NotInRepo>/ @@drwill-ms @@timtay-microsoft @@abhipsaMisra @@vinagesh @@azabbasi @@barustum @@jamdavi

# ServiceLabel: %Event Grid %Service Attention
#/<NotInRepo>/ @jfggdl

# ServiceLabel: %Event Hubs %Service Attention
#/<NotInRepo>/ @kasun04

# ServiceLabel: %Functions %Service Attention
#/<NotInRepo>/ @ahmedelnably @fabiocav

Expand Down Expand Up @@ -701,15 +703,9 @@
# ServiceLabel: %Security %Service Attention
#/<NotInRepo>/ @chlahav

# ServiceLabel: %Service Attention %Service Bus
#/<NotInRepo>/ @EldertGrootenboer

# ServiceLabel: %Service Attention %Service Fabric
#/<NotInRepo>/ @QingChenmsft @vaishnavk @juhacket

# ServiceLabel: %Schema Registry %Service Attention
#/<NotInRepo>/ @arerlend @alzimmermsft

# ServiceLabel: %Service Attention %SignalR
#/<NotInRepo>/ @sffamily @chenkennt

Expand Down

0 comments on commit 6fb90c4

Please sign in to comment.