Refactor handling of setting file expiry policy #21378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using a struct containing explicit fields instead of an interface to improve discovery and self-documentation.
jhendrixMSFT
requested review from
siminsavani-msft,
souravgupta-msft,
tasherif-msft,
gapra-msft and
vibhansa-msft
as code owners
jhendrixMSFT
commented
Aug 15, 2023
| createFileOpts := &file.CreateOptions{ | ||
| Expiry: expiry, | ||
| Expiry: file.CreateExpiryValues{ | ||
| ExpiresOn: time.Now().Add(8 * time.Second).UTC().Format(http.TimeFormat), |
There was a problem hiding this comment.
Note that this does put the onus on the developer to get this correct. We could add helper funcs to create a well-formed instance. Maybe we do this later based on customer feedback.
There was a problem hiding this comment.
Yea, let's see customer feedback. I will include examples of this in my PR after we merge this PR.
There was a problem hiding this comment.
I would just reverse the initialization order because the mental model is:
- Select an expiry type first and then
- Set ExpiresOn (if necessary)
tasherif-msft
approved these changes
Aug 15, 2023
|
I'm ok with these changes. Please ignore the ci issues, these are resolved in another PR. I have gone ahead and approved |
|
/check-enforcer override |
JeffreyRichter
approved these changes
Aug 16, 2023
| createFileOpts := &file.CreateOptions{ | ||
| Expiry: expiry, | ||
| Expiry: file.CreateExpiryValues{ | ||
| ExpiresOn: time.Now().Add(8 * time.Second).UTC().Format(http.TimeFormat), |
There was a problem hiding this comment.
I would just reverse the initialization order because the mental model is:
- Select an expiry type first and then
- Set ExpiresOn (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using a struct containing explicit fields instead of an interface to improve discovery and self-documentation.