Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator tool fix #21320

Merged
merged 2 commits into from
Aug 3, 2023
Merged

generator tool fix #21320

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a9659
generator tool fix
Alancere Aug 3, 2023
66f6dca
fix README.md.tpl
Alancere Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion eng/tools/generator/cmd/v2/release/releaseCmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ func (c *commandContext) generate(sdkRepo repo.SDKRepository, specCommitHash str
}

func (c *commandContext) generateFromRequest(sdkRepo repo.SDKRepository, specRepoParam, specCommitHash string) error {
var generateErr []error
var pullRequestUrls = make(map[string]string)
var pushBranch = make(map[string]struct {
requestLink string
Expand Down Expand Up @@ -220,7 +221,8 @@ func (c *commandContext) generateFromRequest(sdkRepo repo.SDKRepository, specRep
}
err = c.generate(sdkRepo, specCommitHash)
if err != nil {
return err
generateErr = append(generateErr, err)
continue
}

// get current branch name
Expand Down Expand Up @@ -289,5 +291,12 @@ func (c *commandContext) generateFromRequest(sdkRepo repo.SDKRepository, specRep
}
}

if len(generateErr) != 0 {
fmt.Println("generator error:")
for _, e := range generateErr {
fmt.Println(e)
}
}

return nil
}