Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shallow cloning azcore.Client instances (#21065) #21098

Conversation

jhendrixMSFT
Copy link
Member

This allows for multiple clients to share the same underlying pipeline while having the correct client name string in traces.

This is a cherry-pick of 1d8ba7b with a slightly modified CHANGELOG to reflect the current sequence of releases. The feature's implementation has also been slightly changed as the current incarnation in main was built on features added in the v1.7.0-beta series.

@jhendrixMSFT
Copy link
Member Author

We have a bit of a problem here. The latest preview of armmonitor is using [email protected] for fakes and tracing. Removing that content breaks the dependency check. While we can override it here, I don't believe we can in the release pipeline.

I see a few options.

  • Fix dependency checking. This is ideal but seems difficult with release week coming up.
  • Add a flag to CI to allow skipping of dependency checking.
  • Release azcore as v1.6.2 instead of v1.7.0.

Frankly, releasing as v1.6.2 simplifies the upcoming releases but that violates semver rules. So I think the only option at present is bullet 2 unless folks thing that fixing dependency checking to account for this scenario can happen in the next few days. Thoughts?

@jhendrixMSFT
Copy link
Member Author

Opened #21116 to track the CI issue.

* Add support for shallow cloning azcore.Client instances

This allows for multiple clients to share the same underlying pipeline
while having the correct client name string in traces.

* improved field names
@jhendrixMSFT
Copy link
Member Author

@benbp what's the correct way for me to rerun this with the flag Skip.DependencyCheck set to true?

@benbp
Copy link
Member

benbp commented Jul 12, 2023

@jhendrixMSFT you can't manually set variables in our public pipeline project for security reasons. However, you can run the internal version of this pipeline and then override approvals from the public failure. Go to the pipeline, click Run pipeline, set the branch to be refs/pull/21098/merge, then click Variables and add your variable value.

NOTE: as it's manually run, the internal pipeline will try to create a release stage, but you can just deny that, or also set a Skip.Release variable to true

@jhendrixMSFT
Copy link
Member Author

/check-enforcer override

@jhendrixMSFT jhendrixMSFT merged commit 62a8079 into Azure:release/azcore-1.7.0 Jul 12, 2023
@jhendrixMSFT jhendrixMSFT deleted the withclientname_cherrypick branch July 12, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants