Add optional auth challenge handling to BearerTokenPolicy #19448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Client
chlowell
requested review from
RickWinter,
jhendrixMSFT and
richardpark-msft
as code owners
There was a problem hiding this comment.
Seems reasonable to me. Leave the final judgement to @jhendrixMSFT, of course.
RickWinter
reviewed
Oct 31, 2022
jhendrixMSFT
reviewed
Nov 1, 2022
jhendrixMSFT
reviewed
Nov 1, 2022
jhendrixMSFT
reviewed
Nov 1, 2022
jhendrixMSFT
approved these changes
Nov 2, 2022
JeffreyRichter
approved these changes
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17554 by adding a couple of extension points SDK developers can use to insert custom logic around BearerTokenPolicy's default behavior. These allow clients to elicit challenges (to discover auth parameters) and to handle them, without having to copy and tweak BearerTokenPolicy, as we've done for Key Vault and ARM. This will simplify supporting CAE and ARM cross-tenant authentication. #19447 has a draft implementation for Key Vault showing this new API in use.