Feature/generics #17381
Merged
Feature/generics #17381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jhendrixMSFT
commented
Mar 25, 2022
jhendrixMSFT
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
* Update CI to use Go 1.18beta.2 * add prerelease install template revert some unneeded changes * fix parameters references * fix curl * use archive names * fix param * update linter * build linters from source, display Go version * lint clean * fix smoke test version detection
Specify 1.18 in go.mod file.
* Disable linter for now Blows up on generic type parameters so disabling until it's working. Restored installation to its original form. * skip on linter install failure
NullValue now takes a generic type parameter instead of an interface arg to determine the type of null sentinel value to create. IsNullValue infers its generic parameter to determine the type of null sentinel value to look for. At present, there is no way to express a 'nillable' generic type constraint so the funcs simply take a [T any] which should be fine as they typically take/return pointer-to-types. The 'to' package has been reduced to two funcs.
* Disable publishing test results for now It's broken due to lack of generics support. Test failures will still block CI though. * revert fake failure * exclude track 2 from track 1 Format Check CI step * refine track 1 gofmt check
* Add generic pager implementation * refine first page flag and processor vars * refine per feedback, start adding tests * fix LRO case, add remaining tests * more consolidation * update changelog * remove page param, use unmarshal instead
Due to lack of support for type aliasing a generic type, we have duplicate definitions for ARM and data-plane. We can consolidate the definitions when type aliasing support is added in the future.
* Clean-up in prep for merging feature/generics to main Removed some temporary CI changes after rebasing on main. Added missing entries to the changelog. Bumped version to v0.23.0 for breaking changes. * bump golangci-lint to latest version * switch to temporary fork of gocov
jhendrixMSFT
requested review from
benbp,
weshaggard,
RickWinter,
chlowell,
richardpark-msft and
seankane-msft
as code owners
|
Fixes #16874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.