Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15.1.0 #1498

Merged
merged 15 commits into from
Apr 9, 2018
Merged

v15.1.0 #1498

merged 15 commits into from
Apr 9, 2018

Conversation

jhendrixMSFT
Copy link
Member

Thanks you for your contribution to the Azure-SDK-for-Go! We will triage and review it as quickly as we can.

As part of your submission, please make sure that you can make the following assertions:

  • I'm not making changes to Auto-Generated files which will just get erased next time there's a release.
  • I've tested my changes, adding unit tests where applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  • I'm submitting this PR to the dev branch, or I'm fixing a bug that warrants its own release and I'm targeting the master branch.
  • If I'm targeting the master branch, I've also added a note to CHANGELOG.md.
  • I've mentioned any relevant open issues in this PR, making clear the context for the contribution.

@jhendrixMSFT jhendrixMSFT self-assigned this Apr 3, 2018
@azuresdkci
Copy link

Can one of the admins verify this patch?

@ghost ghost added the review label Apr 3, 2018
@vladbarosan
Copy link

vladbarosan commented Apr 4, 2018

#1487 I reproed the issue.

2 causes:

  1. We didn't regenerate the preview folder so some types are mismatchign ( the repo name switch from uuid to go.uuid from Satori) . Let's fot 15.1 maybe manually fix the profile so at least go get works. then after Handle preview specs properly #1136 is done it should work.

  2. For some reason some Automation operations and Iot although they have a rsourcegroup parameter in all operations , one of them thinks is a client property not a parameter. I had a look at the specs for Automation in Dscconfiguration and couldn't see a reason for it. All methods have it correctly except the PATCH operation.

Note that for 2, fixing it would mean making one client call a breaking change but at this point is not working either way.

@vladbarosan
Copy link

Also the CI should catch these issues. Even looking at the PR CI here there are packages that dont work ( Automation, Cognitive Services ). https://travis-ci.org/Azure/azure-sdk-for-go/jobs/361872520

We cannot merge like this.

@vladbarosan
Copy link

@mcardosos can you have a look at why the CI didn't catch these ? I know there was a similar issue in the samples repo

@vladbarosan
Copy link

@mcardosos apparently it takes the exit code of the last command we need to check for the status code of each command. and fail if its non 0

@jhendrixMSFT jhendrixMSFT merged commit 0b74583 into Azure:master Apr 9, 2018
@ghost ghost removed the review label Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants