Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Disks for VMs #560

Closed
rrudduck opened this issue Feb 27, 2017 · 4 comments
Closed

Managed Disks for VMs #560

rrudduck opened this issue Feb 27, 2017 · 4 comments

Comments

@rrudduck
Copy link

rrudduck commented Feb 27, 2017

Is creating VMs and Scale Sets with managed disks currently supported?

Looking at the current sdk, it appears the compute provider has not been updated to api version 2016-04-30-preview yet, which would explain the Bad Request and validation errors I'm running into. Any timeline on that happening?

Thanks.

EDIT: Specifically I'm talking about the implicit create support. Not creating disks themselves.

More details: hashicorp/terraform#11874

@brandontosch
Copy link

FYI, looks like there is a pull request open for this: #561

@marstr
Copy link
Member

marstr commented Mar 1, 2017

Howdy folks. As @brandontosch mentioned, support for this is currently in review and should be approved and released in the next several days.

@colemickens
Copy link
Contributor

released in the next several days.

15 minutes later... 😉. Thanks for this!

@marstr
Copy link
Member

marstr commented Mar 2, 2017

under-promise over-deliver! What can I say :)

ArcturusZhang added a commit that referenced this issue Oct 15, 2019
* Ensures go.mod exists before doing actual work

* Fix wrong module name

* Add a new test scenario

* Some refinement on testcases for versioner

* Update version in version.go

* Only keep one line of tag in version.go

* Minor fix

* No need to print tag to stdout

* New test scenario

* Fix linter problem

* Return error from filepath.Abs

* Add test for update version.go file

* Remove method that ensures existence of go.mod file, and some redaudent
test cases

* Formatting code after versioning done

* Refine tests

* Fix a bug that when update applied to v2, the go.mod file does not
update as v2

* Clean up

* Purely file rename, nothing else changed

* Add functionality for run tool in root folder

* Add root command again

* Fix format

* Typo fix

* Add test for list all stage folders

* Add two functions for programmatically call

* Fix CI failure

* Format stage folder first to avoid un-expected changes in code

* Add a new test case for more realistic

* Fix errors in the new test case

* Fix gofmt issues

* Add a new struct to cover this scenario

* Add test for go vet

* Add new test case for one line import

* Fix a bug in regex used for multiline import statement

* Initial commit of tool moduler

* Add copyright info in front of every new file

* Add profile building

* Fix CI failure

* Fix dry-run

* Do not need to update repo

* Refine

* Refine and add tests for moduler

* Update tests
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants