Make the CAPath option available on all OSes and change to throw on runtime on non-linux. #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime on non-linux.
antkmsft
approved these changes
Nov 29, 2023
antkmsft
reviewed
Nov 29, 2023
LarryOsterman
approved these changes
Nov 30, 2023
|
Let's get this one done tomorrow! |
ahsonkhan
requested review from
RickWinter,
vhvb1989 and
gearama
as code owners
microzchang
added a commit
that referenced
this pull request
Feb 18, 2024
* Sync eng/common directory with azure-sdk-tools for PR 7459 (#5237) * check for the presence of a compatible powershell. ensure that we always return a list of tags * allow the script to require pshell6+ * remove the en-us from the link --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Fix image tag for multiimage deployments (#5238) Co-authored-by: Liudmila Molkova <[email protected]> * Options Http Enum add to Core (#5246) * Options Http Enum add * spaces * Make the CAPath option available on all OSes and change to throw on runtime on non-linux. (#5207) * Make the CAPath option available on all OSes and change to throw on runtime on non-linux. * Address PR feedback, update test, and let curl fail on unsupported platforms. * Options UT (#5249) * Options Http Enum add * spaces * options UT * remove Options * Revert "remove Options" This reverts commit 0da5d2c. * Add a remark in CAInfo doc comment mentioning it is Linux only. (#5248) * Fixes for CVE-2024-21646 (#5251) * Fixes for CVE-2024-21646 * Added note about this fix to CHANGELOG.md * Sync eng/common directory with azure-sdk-tools for PR 7445 (#5247) * Add package filter parameter to select recursively found packages in release * Handle empty value for packageFilter --------- Co-authored-by: Ben Broderick Phillips <[email protected]> * Core-Core (GA) + Core-AMQP (Beta) + Event Hubs (Beta) January Releases (#5243) * Core-Core + Core-AMQP + Event Hubs January Releases * Update CHANGELOG.md --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Identity January Release (#5242) Co-authored-by: Anton Kolesnyk <[email protected]> * Increment version for core releases (#5255) * Increment package version after release of azure-core * Increment package version after release of azure-core-amqp * Increment package version after release of azure-messaging-eventhubs (#5256) * Increment package version after release of azure-identity (#5257) * Storage tables implementation (#5137) * dss * first pass at a client and tests * constructors work * working request, need to fix the response parsing * basic tests working for service client * refactored the constructors * testproxy and tests * format file * got client and one API working * list working * all apis recorded * new assets.json * assets.json regen * format json * adding word to cspell * fix build issues * fix one more break * typo * clangs * one more issue * more fixezez * regen recordings * try again * clangs * clangs again * new assets * new test proxy * regen tests based on new merge * hmmm * restore * add debug env for test proxy * resync cmake presets from main * gor get and set working * get stats * table client and create * delete * get/set acls * list tables * some cleanup * Create /update/merge/delete * upsert * query entities * generated tests * clangs * some fixes * some more errors * cspells * got transaction API working * transactions working , need to parse response * get data out of the response * clangs * batch1 * regen tests * part 2 * batch3 * batch4 * clangs * regen tests * regen tests * try again * live only * added some more tests for the transaction body * small refactor for tests * oops * some oter update * darn includes * sddfsd * erorr fix * key clients * sas * small cleanup * All tests passing * test recordings * clangs * missing ENV for test * attempt1 * retry * couple recordings * regen some tests * clangs * again * again * comments * comments * headers and footers * some cleanjup * Move folders step1 * revert assets and test resources in storage * revert to main * cspell * readme * comments * revert ci.yml * liveonly test * clangs * camke * ci2 * try again * fdssfs * fdsfsd * some cleanup * dasda * dsdsds * asda * assets * comments * a few more bits and pieces * some other updates for cspell * typo * more docs * spell * another doc error * clangs docs * docs * test cov * dasdas * hg * stress test * cspell * Update sdk/storage/azure-storage-common/test/ut/CMakeLists.txt Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/storage/azure-storage-common/test/ut/shared_key_policy_lite_test.cpp Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/CHANGELOG.md Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/CMakeLists.txt Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/test/stress/scenarios-matrix.yaml Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/test/stress/Dockerfile Co-authored-by: Anton Kolesnyk <[email protected]> * PR comments * respurces cleanup * cleanup 2 * respurce fix * revddrt * weqq * oops * try again * Update sdk/tables/azure-data-tables/vcpkg/vcpkg.json Co-authored-by: Anton Kolesnyk <[email protected]> * try * test fix * samples * readmes * readmes * readmes * api view settings * qualify friends * try * moving usings * refactor for API View tool * some more * clangs * Update sdk/tables/README.md Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/core/azure-core/inc/azure/core/http/http.hpp Co-authored-by: Ahson Khan <[email protected]> * Update sdk/core/azure-core/src/http/transport_policy.cpp Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/inc/azure/data/tables/rest_client.hpp Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/CHANGELOG.md Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/test/ut/CMakeLists.txt Co-authored-by: Anton Kolesnyk <[email protected]> * Update sdk/tables/azure-data-tables/src/rest_client.cpp Co-authored-by: Anton Kolesnyk <[email protected]> * some comments * comments * comments part N * clang * try now * clang * comments * update file names * update test to check for the final signature * ccc * rename shared key policy lite * cleanup some includes * add a couple more tests * small update * clang * increase test limits * xml transition * service_version_policy * shared creds and key policy lite * switch to secondary policy * code done * remove last storage vestiges * put back some code * readme/changelog * Update sdk/tables/azure-data-tables/src/serializers.cpp Co-authored-by: Rick Winter <[email protected]> * Add the shared key policy for Larry * Larry comments * curlybracify the initializers * Update sdk/core/azure-core-xml/inc/azure/core/xml/dll_import_export.hpp Co-authored-by: Rick Winter <[email protected]> * Update sdk/core/azure-core-xml/vcpkg.json Co-authored-by: Rick Winter <[email protected]> * Update sdk/tables/azure-data-tables/inc/azure/data/tables.hpp Co-authored-by: Rick Winter <[email protected]> * Rick's comments one more namespace change for serializers * whiteline * typo * oops * includes and clangs * cleanup * jhfjdhjfd * hjkjdhf * daas * Anton's comments * clang * revert some changes * fdss * Update sdk/core/azure-core-xml/CHANGELOG.md Co-authored-by: Anton Kolesnyk <[email protected]> * everything works * clangs and vcpkg test * test remove azure-core-xml * vcpkg json * remove the code * merge main * saa * wqw * last comments * clang --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Rick Winter <[email protected]> * Remove 'using namespace' from header files (#5260) Co-authored-by: Anton Kolesnyk <[email protected]> * Larry's comments (#5261) * Larry's comments * clang * revenge of the clang * Sync eng/common directory with azure-sdk-tools for PR 7451 (#5264) * Added script and pipeline for spec location validation SDK release pipeline would run this validation to ensure the spec comes from the main branch of Azure/azure-rest-api-specs repo * Update parameter * Use github rest api to validate commit * Added token parameter * Support more yaml cases and other languages * Removed the default setting in yaml template * Only validate in case of GA package * Follow APIView to retrieve package version for verification * Get github token from env variable * Removed obsolete parameter --------- Co-authored-by: raychen <[email protected]> * Correct the variable name in spec location validation script (#5265) Co-authored-by: raychen <[email protected]> * [CODEOWNERS] Remove automation section (#5269) The focus of these changes is to remove the automation section, as CODEOWNERS changes no longer require manual syncing. * fix export (#5270) * fix export * naming * quotes * more quotes * last quotes (#5271) * mroe quotes * dssf * sqa * Key Vault January Releases (#5241) * Key Vault January Releases --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Tables January Release (#5239) * Tables January Release --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Fix broken link (#5273) Co-authored-by: Anton Kolesnyk <[email protected]> * Increment package version after release of azure-data-tables (#5274) * Filter packages at verify step (#5275) Co-authored-by: Ben Broderick Phillips <[email protected]> * Increment version for keyvault releases (#5276) * Increment package version after release of azure-security-keyvault-keys * Increment package version after release of azure-security-keyvault-certificates * Increment package version after release of azure-security-keyvault-secrets * Increment package version after release of azure-security-keyvault-administration * Sync eng/common directory with azure-sdk-tools for PR 7512 (#5258) * generate an artifact with the updated files * bring in Wes's feedback --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Re-enable UWP CI pipeline (#5226) Co-authored-by: Anton Kolesnyk <[email protected]> * Attempt to diagnose WinHTTP CI pipeline errors. (#5259) * Fixes for CVE-2024-21646 * Added note about this fix to CHANGELOG.md * Tweaks to investigate CI pipeline error * Changelog entry for winhttp bug fix (#5277) * Changelog entry for winhttp bug fix * Updated changelog with further suggestions * Sync eng/common directory with azure-sdk-tools for PR 7537 (#5278) * Add ConflictedFile to git-helpers.ps1, add git-helpers.tests.ps1 to exercise basic functionality. * Add `resolve-asset-conflict.ps1` a script that can autoresolve an assets.json file. --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> * Synchronous AMQP Close (#5281) * First cut at blocking close * Removed synchronous ifdefs * Add git commit details to stress environment (#5280) Co-authored-by: Ben Broderick Phillips <[email protected]> * Fix Language value for JS (#5283) Co-authored-by: raychen <[email protected]> * Fix typos in ps1 scripts (#5285) Co-authored-by: Lukasz Kokot <[email protected]> * use merge instead of cherry-pick in merge-proxy-tags.ps1 (#5286) Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> * Fixed bug in Eventhubs live tests (#5290) * Fixed bug in Eventhubs live tests * switched back to DAC for tests * Ported uAMQP bug fix to C++ repo (#5291) * Sync eng/common directory with azure-sdk-tools for PR 7580 (#5292) * Support creating resources with user auth * Log warning if TestApplicationId is set * missing space * regenerate md file * Rename * Update link --------- Co-authored-by: jolov <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 7569 (#5289) * Correct the name of JS package folder * Uncomment the package verification * Logging more info for troubleshooting * Get sdkType and directory from the package info --------- Co-authored-by: Ray Chen <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 7584 (#5294) * Fix role assignment for user auth * PR fb * Apply suggestions from code review Co-authored-by: Heath Stewart <[email protected]> --------- Co-authored-by: jolov <[email protected]> Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * AMQP Session related fixes. (#5299) * Implemented connection handle table to fix half closed session problem * Correctly handle session begin after connection is open * Split out amqp settle mode to separate header; added test coverage for AMQP Transfer and Detach performatives * Use absolute path for settle mode header * Sync eng/common directory with azure-sdk-tools for PR 7585 (#5302) * Remove package retrieval when verify pkg version * Modified description of PackageName parameter --------- Co-authored-by: Ray Chen <[email protected]> * Removed dead script (#5306) * Step 1 in adding (more)perf tests for Core and Identity. (#5300) * mroe quotes * dssf * sqa * first identity test no caching * cache no cache * cleanup cache shortcircuit * some cleanup * Update sdk/core/perf/src/base_test.cpp Co-authored-by: Anton Kolesnyk <[email protected]> * PR comments * remove cache option * wqq * dsd * saa * wqq * clang * Update sdk/core/perf/inc/azure/perf/dynamic_test_options.hpp Co-authored-by: Anton Kolesnyk <[email protected]> * PR comments * PT comments * clang --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Azure Core February Releases (#5304) Co-authored-by: Anton Kolesnyk <[email protected]> * Fixed nightly CI pipeline build error (#5311) * Fixed nightly CI pipeline build error * printf format string errors * Azure Core February Releases (#5312) Co-authored-by: Anton Kolesnyk <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 7615 (#5313) * Prepare-Release.ps1: Make dateTime.ToString("MM/dd/yyyy") to work on exotic set-ups On my machine, I experimented with the registry, and the worst part is that I don't remember/know how to reset it back. The work items that script produces, do have datetimes for the upcoming releases in the `MM-dd-yyyy` format, and then I have to correct them by hand. `dateTime.ToString("MM/dd/yyyy")` does produce the date in the format of `MM-dd-yyyy` on my machine. This also happens if I write a corresponding .NET app. The fix that I am proposing makes it work on my specific setup and hopefully breaks no one else. I understand if you are hesitant to take it. Let me know, I'll see how I can restore my setting. But on the other hand, I don't think it makes anything worse, it only makes things more robust, so maybe take it? * Use [CultureInfo]::InvarialtCulture Co-authored-by: Wes Haggard <[email protected]> * Update eng/common/scripts/Prepare-Release.ps1 * Update eng/common/scripts/Prepare-Release.ps1 --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Wes Haggard <[email protected]> * Fix issue in Verify-Link.ps1 after PS 7.4 update (#5314) https://learn.microsoft.com/en-us/powershell/scripting/whats-new/what-s-new-in-powershell-74?view=powershell-7.4 - Add AllowInsecureRedirect switch to Web cmdlets (#18546) That new option cause a new exception type that exposed a bug where we assumed if InnerException property existed that it was not null. This fix verifies that the property is not null. Co-authored-by: Wes Haggard <[email protected]> * Http Transport perf test (#5309) * mroe quotes * dssf * sqa * first identity test no caching * cache no cache * cleanup cache shortcircuit * some cleanup * http test 1 * Update sdk/core/perf/src/base_test.cpp Co-authored-by: Anton Kolesnyk <[email protected]> * PR comments * remove cache option * wqq * dsd * saa * wqq * dfs * clang * http get post curl winhttp * Update sdk/core/perf/inc/azure/perf/dynamic_test_options.hpp Co-authored-by: Anton Kolesnyk <[email protected]> * rtter * PR comments * PT comments * clang * http transport test * Update sdk/core/perf/src/base_test.cpp Co-authored-by: Anton Kolesnyk <[email protected]> * PR comments * remove cache option * wqq * dsd * saa * wqq * dfs * clang * http get post curl winhttp * rtter * PR comments * PT comments * clang * http transport test * PR comments * clangs --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Pipeline tests (#5310) * mroe quotes * dssf * sqa * pipeline and policies * PR comments * cast int * Increment version for core releases (#5316) * Increment package version after release of azure-core * Increment package version after release of azure-core-amqp * Move the connection back to the connection pool when HTTP error 404 was received (#5308) * Move the connection back to the connection pool when HTTP error 404 was received * Use symbolic name for 404 status code * Update Azure Core changelog after #5308 (#5317) Co-authored-by: Anton Kolesnyk <[email protected]> * Retroactively update AMQP's changelog (#5321) Co-authored-by: Anton Kolesnyk <[email protected]> * Fix BOM issue Generate-DocIndex.ps1 (#5318) Co-authored-by: Daniel Jurek <[email protected]> * Domain-specific changes to fix docindex (#5319) * Add domains-specific changes needed for updated Generate-DocIndex.ps1 to work * Spelling * Sync eng/common directory with azure-sdk-tools for PR 7634 (#5323) * Fix sparse-checkout git command line behavior * Use command arg parsing behavior in sparse-checkout.yml --------- Co-authored-by: Daniel Jurek <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 7630 (#5325) * Add ContentType header to Update-GitHubIssue * replaced application/json * Update eng/common/scripts/Invoke-GitHubAPI.ps1 Co-authored-by: Daniel Jurek <[email protected]> --------- Co-authored-by: Peng Jiahui <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> * Eventhubs February Release (#5305) * Increment package version after release of azure-messaging-eventhubs (#5327) * Workaround for vcpkg-tool regression bug (#5328) Co-authored-by: Anton Kolesnyk <[email protected]> * Upload logs on cmake generate/build failure (#5293) * Upload logs on cmake generate/build failure * Copy relevant files to staging location, clean up after publishing * Update cspell words * Test: break cmake generate in a way that'll produce SOME log files. * Revert "Test: break cmake generate in a way that'll produce SOME log files." This reverts commit d5a3005. * Show failure logs instead of uploading artifacts. Only show log files for vcpkg at this time * Reapply "Test: break cmake generate in a way that'll produce SOME log files." This reverts commit 582629a. * Revert "Reapply "Test: break cmake generate in a way that'll produce SOME log files."" This reverts commit 7a35250. * Another type of test * Revert inadvertent whitespace changes * Revert "Another type of test" This reverts commit e38013f. * More logging * Json test (#5324) * mroe quotes * dssf * sqa * Json test p1 * qw * re * pr build * cast part 2 * ew * jj * Pin azure/login action step to v1.5.1 (#5333) Co-authored-by: James Suplizio <[email protected]> * Multithreaded support for Eventhubs management family of APIs (#5315) * Enabled multithreaded calls to eventhubs management APIs * Added partition client properties tests, removed unused variables in consumer client tests * Restructured properties APIs in eventhubs to simplify producer client and consumer client implementations * Fixed test crash in LinkAttachDetach AMQP test * Added test cases for management authn failures * Don't emit body contents in AmqpMessage insertion operator * Don't take numeric value parameters by value to ostream insertion operators * Updated eventhubs dependency to match reality * Added value based tests for enumeration stream inserters * Add stress test arm/bicep template prefix to New-TestResources ResourceType set (#5340) Co-authored-by: Ben Broderick Phillips <[email protected]> * Enable proactive renewal of Managed Identity tokens. (#5336) * Enable proactive renewal of Managed Identity tokens. * Address PR feedback - move helpers to anonymous namespace and renames. * Address local variable rename suggestion. * Azure Identity February Release (#5307) * Azure Identity February Release * Update CHANGELOG.md release date to Thurs * Update release date. * Remove empty CL sections. * For new surface area, classes marked as final should not have virtual methods. (#5331) * Classes marked as final should not have virtual methods. (cherry picked from commit 7413384c111b73be448f78527a08a544fd1f6ec6) * Update changelog. * Address PR feedback and use named-macro. * Only use the macro for testing_build final classes. * Add a new compile definition _azure_TESTING_BUILD. * Add test as a friend class and put the test in a Identity specific test namespace. * Remove the macro for final expansion since doxygen struggles with it. * Address PR feedback, add ifdef guard around _azure_VIRTUAL_FOR_TESTS. * Increment package version after release of azure-identity (#5343) * Fix case-sensitive spelling in non-common /eng (#5346) * PR Feedback * Remove unnecessary instance --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Guard against Windows' min/max macros (#5348) * Guard against Windows' min/max macros * Add NOMINMAX and LEAN_AND_MEAN + clang-format * clang-format --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Update vcpkg SHA (#5347) Co-authored-by: Anton Kolesnyk <[email protected]> * Fix case-sensitive spelling in scripts that get deployed to C++ repo (#5349) Co-authored-by: Anton Kolesnyk <[email protected]> * Move emitter-package.json scripts to eng/common (#5353) Co-authored-by: Patrick Hallisey <[email protected]> * Install Docs Updates (#5339) * initial update * moving instructions on using betas to integration samples * added requirements section, more options for addition install and config methods, build and run instructions and removed old install and config instructions * spell check fixes * fixes for broken links * removing sample project repo option until ready * Adding C++ compiler to the prereqs section * removed un-needed parts of vcpkg.json example * Update CodeOwners (#5357) * Winhttp flaky test (#5356) * mroe quotes * dssf * attempt 2 * updated test and logs * clang * update PR * changelog update * Update sdk/core/azure-core/CHANGELOG.md Co-authored-by: Larry Osterman <[email protected]> * Update sdk/core/azure-core/CHANGELOG.md Co-authored-by: Anton Kolesnyk <[email protected]> --------- Co-authored-by: Larry Osterman <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> * Update CodeOwners (#5359) * Update CodeOwners * Remove the package that doesn't exist * Add more individuals to Tables * Publishing to vcpkg-betas syncs vcpkg baseline to our repo (#5330) * Publishing to vcpkg-betas syncs vcpkg baseline to our repo * PR Feedback --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Update GitHubEventProcessorVersion (#5361) Co-authored-by: James Suplizio <[email protected]> * Updates to tools for the CodeownersUtils updates (#5362) Co-authored-by: James Suplizio <[email protected]> * Fix up codeowner syntax (#5364) * Azure Core 1.11.2 Release (#5360) * Azure Core 1.11.2 Release * Update release date to 2/16 --------- Co-authored-by: Anton Kolesnyk <[email protected]> * Core perf tests consolidation (#5363) * mroe quotes * dssf * compact the tests in the proper folder * 2 more tests * eqwq * enabled all except http * endline * Increment package version after release of azure-core (#5366) --------- Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Scott Beddall (from Dev Box) <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: George Arama <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Larry Osterman <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Ahson Khan <[email protected]> Co-authored-by: Rick Winter <[email protected]> Co-authored-by: raychen <[email protected]> Co-authored-by: Jesse Squire <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Lukasz Kokot <[email protected]> Co-authored-by: jolov <[email protected]> Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Mykhailo Chelnokov <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Peng Jiahui <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Ronnie Geraghty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.