-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientCertificateCredential
: better exception message for unsupported file extensions
#5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antkmsft
added
Azure.Identity
MQ
This issue is part of a "milestone of quality" initiative.
labels
Nov 27, 2023
antkmsft
changed the title
Nov 27, 2023
CLientCertificateCredential
: better exception message for unsupported file extensionsClientCertificateCredential
: better exception message for unsupported file extensions
antkmsft
requested review from
schaabs,
ahsonkhan,
RickWinter,
vhvb1989,
gearama,
LarryOsterman and
a team
as code owners
November 27, 2023 05:42
antkmsft
requested review from
christothes,
joshfree,
pvaneck,
chlowell and
mpodwysocki
November 27, 2023 05:42
RickWinter
approved these changes
Nov 27, 2023
ahsonkhan
reviewed
Nov 29, 2023
ahsonkhan
reviewed
Nov 29, 2023
ahsonkhan
reviewed
Nov 29, 2023
ahsonkhan
reviewed
Nov 29, 2023
sdk/identity/azure-identity/test/ut/client_certificate_credential_test.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4907.
--
UWP CI is currently blocked until microsoft/vcpkg#35279 is fixed / microsoft/vcpkg#35116 is merged (#5181 would unblock)